Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #24624

spcheema · 2023-08-16T12:38:38Z

Details

Fixed Issues

$ #24389
PROPOSAL: #24389 (comment)

Tests

Scenario 1.

Open a chat room from LHN
Request a money
Click on any of the IOU message avatars
It should open the details page on RHN
Clicking on each menu item on the details page should open the respective profile page

Scenario 2.

Open a chat room from LHN
Request a money
Click IOU message avatars and it'll open the thread
Clicking on avatars in the thread header and it should open the details page on RHN
Clicking on each menu item on the details page should open the respective profile page

Verify that no errors appear in the JS console

Offline tests

QA Steps

Scenario 1.

Open a chat room from LHN
Request a money
Click on any of the IOU message avatars
It should open the details page on RHN
Clicking on each menu item on the details page should open the respective profile page

Scenario 2.

Open a chat room from LHN
Request a money
Click IOU message avatars and it'll open the thread
Clicking on avatars in the thread header and it should open the details page on RHN
Clicking on each menu item on the details page should open the respective profile page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Web.mp4

Mobile Web - Chrome

Mobile.-.chrome.mp4

Mobile Web - Safari

Mobile.-.safari.mp4

Desktop

Desktop.1.mp4

iOS

Screen.Recording.2023-08-17.at.12.45.37.pm.mp4

Android

Re_.Meet.-.buf-ooot-azm.-.17.August.2023.mp4

melvin-bot · 2023-08-16T13:18:14Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

spcheema · 2023-08-16T13:19:51Z

@narefyev91 I am currently experiencing issues while building ios & android apps on emulators. I'll upload videos for both ios & android later.

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

narefyev91

Investigating potential crash

narefyev91 · 2023-08-17T13:59:56Z

Small note - during testing some other PR - get crashes on Android - which shows that props.iouReport.reportID - props.iouReport was undefined - not sure why. But tested on the latest main - was not able to reproduce

pecanoro · 2023-08-17T19:42:33Z

Hmm, it's crashing for me when I click on the avatars on web:

…ort preview

spcheema · 2023-08-17T21:40:11Z

Hmm, it's crashing for me when I click on the avatars on the web:

I can see from the logs you have shared participants list is undefined.
@narefyev91 @pecanoro I am not sure in which case the participants' list will be undefined or empty. But I have replaced it in order to prevent crashes anymore.

and thanks for sharing logs, it helped to quickly spot the issue.

pecanoro · 2023-08-18T08:56:58Z

It seems to be working well now, but we agreed on fixing it for all cases too and this view is still not opening the participant list 😄

spcheema · 2023-08-18T10:02:45Z

I believe we are only fixing for IOU message.

Reason being I discussed here the behaviour of header clicking and then agreed to fix clicking on an avatar in request only.

#24389 (comment)

pecanoro · 2023-08-18T10:22:07Z

I mentioned here that we should be fixing this in all cases in which it wasn't working, even the IOU header.

spcheema · 2023-08-18T10:56:26Z

It's not a big one I'll have a look.

spcheema · 2023-08-18T18:03:49Z

@pecanoro Can you please decide regarding this #24389 (comment)?

spcheema · 2023-08-22T02:01:46Z

@narefyev91 PR is ready for review.

Now clicking on avatars in the request money header will show the details page for multiple participants and profiles page if there is only one:

Here is the discussion:

[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] [$1000] Web - Request a money - Clicking on the avatar open a wrong profile #24389 (comment)
[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] [$1000] Web - Request a money - Clicking on the avatar open a wrong profile #24389 (comment)

…atar-open-a-wrong-profile

narefyev91 · 2023-08-22T09:16:40Z

@pecanoro Checked latest code and record additional videos for test cases - looks good from my side

pecanoro · 2023-08-22T14:44:42Z

Testing everything again!

pecanoro

It's working well from what I tested!

OSBotify · 2023-08-22T16:36:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fedirjh · 2023-08-22T18:37:55Z

cc @pecanoro, We have an open PR to implement the Details page for Expense/IOU reports :

PR: Implement details page for expense/iouReport #24533
Issue: [Awaiting C+ payment confo] [HOLD for payment 2023-10-12] [$1000] The avatar located in the header of the Money Request/Owes chat is not opening on click. #19342

dummy-1111 · 2023-08-23T15:11:14Z

src/pages/home/report/ReportActionItemSingle.js

@@ -111,7 +111,7 @@ function ReportActionItemSingle(props) {

    // If this is a report preview, display names and avatars of both people involved
    let secondaryAvatar = {};
-    const displayAllActors = props.action.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW && props.iouReport;
+    const displayAllActors = useMemo(() => props.action.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW && props.iouReport, [props.action.actionName, props.iouReport]);


There is no need to use useMemo here. I don't understand why it's used
Please tell me if I missed something

We should use it because - it's used inside deps for useCallback - const showActorDetails = useCallback(() => {,
and any new render will create displayAllActors (without memo) which will re-creates useCallback - which should not be

either we should not use useMemo and useCallback or should use it correctly with memoizing deps

displayAllActors would change depends on props.action.actionName and props.iouReport regardless the use of useMemo. If those props don't change, displayAllActors won't be changed.

yes - and if displayAllActors (if we use useMemo) will not changed - useCallback will also not be changed
Without useMemo - displayAllActors will be as usual variable - which will be re-created every time - and will cause re-creation of useCallback

I agree with @s-alves10 (this one). Btw, displayAllActors will return props.iouReport object if it's true instead of a boolean. I think we should wrap it with a Boolean? (Boolean(props.iouReport))

After some checks - i agree that simple passed variable will not trigger recreation of useCallback. Here can be 2 options either leave as it's now in case props.iouReport is object and useMemo needed here or refactor as @bernhardoj suggested to Boolean(props.iouReport) and remove useMemo. I think it's not critical

If nothing is going to break, I think we can leave it as is and maybe we can clean up in the future. It's just semantics, I also missed it, I thought it was necessary, but it is also true you guys are probably more knowledgable about React that me 😄

@pecanoro @narefyev91 Is there any action we need to take now? Or we have decided to refactor later.

We good to jump on it later

OSBotify · 2023-08-24T03:36:04Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-28T18:53:29Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-29T00:07:45Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.57-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:22:32Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

spcheema marked this pull request as ready for review August 16, 2023 13:18

spcheema requested a review from a team as a code owner August 16, 2023 13:18

melvin-bot bot requested review from narefyev91 and removed request for a team August 16, 2023 13:18

narefyev91 reviewed Aug 17, 2023

View reviewed changes

src/pages/home/report/ReportActionItemSingle.js Show resolved Hide resolved

narefyev91 approved these changes Aug 17, 2023

View reviewed changes

melvin-bot bot requested a review from pecanoro August 17, 2023 09:33

spcheema requested a review from blacksaru August 17, 2023 11:39

narefyev91 suggested changes Aug 17, 2023

View reviewed changes

narefyev91 approved these changes Aug 17, 2023

View reviewed changes

spcheema added 3 commits August 18, 2023 07:14

Display participants list when there are multiple avatars for IOU rep…

d6c7de8

…ort preview

Memoized dependency variable

d162c91

Buld participants list

b84c560

spcheema force-pushed the fix/24389-request-a-money-clicking-on-the-avatar-open-a-wrong-profile branch from 9798a1e to b84c560 Compare August 17, 2023 21:39

Update comment

085f972

Display participants list on clicking avatars on IOU report header

85ad12e

spcheema added 3 commits August 20, 2023 00:18

Remove report util changes

988ae48

Code lint

001b04a

Show details/profile on clicking request money header avatars

9c476bb

spcheema added 2 commits August 22, 2023 14:17

Merge branch 'main' into fix/24389-request-a-money-clicking-on-the-av…

9256f94

…atar-open-a-wrong-profile

Merge branch 'main' into fix/24389-request-a-money-clicking-on-the-av…

5594626

…atar-open-a-wrong-profile

pecanoro approved these changes Aug 22, 2023

View reviewed changes

pecanoro merged commit 8251519 into Expensify:main Aug 22, 2023

dummy-1111 reviewed Aug 23, 2023

View reviewed changes

OSBotify mentioned this pull request Aug 24, 2023

Deploy Checklist: New Expensify 2023-08-24 #25813

Closed

73 tasks

spcheema deleted the fix/24389-request-a-money-clicking-on-the-avatar-open-a-wrong-profile branch August 24, 2023 04:04

spcheema mentioned this pull request Aug 24, 2023

[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] [$1000] Web - Request a money - Clicking on the avatar open a wrong profile #24389

Closed

6 tasks

narefyev91 mentioned this pull request Aug 24, 2023

[CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #25847

Merged

58 tasks

hungvu193 mentioned this pull request Aug 27, 2023

[HOLD for payment 2023-09-06] [HOLD for payment 2023-09-04] Web - Blank members page displayed when open the cash amount page header for the first time #26027

Closed

6 tasks

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

trjExpensify mentioned this pull request Sep 1, 2023

[HOLD for payment 2023-09-11] [$500] Report message naming logic is messed up #26450

Closed

bernhardoj mentioned this pull request Jun 20, 2024

[HOLD for payment 2024-07-24] [$250] IOU - Members page is blank #44040

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #24624

Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #24624

spcheema commented Aug 16, 2023 •

edited

Loading

melvin-bot bot commented Aug 16, 2023

spcheema commented Aug 16, 2023

narefyev91 commented Aug 17, 2023 •

edited

Loading

narefyev91 left a comment

narefyev91 left a comment

narefyev91 commented Aug 17, 2023 •

edited

Loading

pecanoro commented Aug 17, 2023

spcheema commented Aug 17, 2023 •

edited

Loading

pecanoro commented Aug 18, 2023

spcheema commented Aug 18, 2023

pecanoro commented Aug 18, 2023

spcheema commented Aug 18, 2023

spcheema commented Aug 18, 2023

spcheema commented Aug 22, 2023 •

edited

Loading

narefyev91 commented Aug 22, 2023

pecanoro commented Aug 22, 2023

pecanoro left a comment

OSBotify commented Aug 22, 2023

fedirjh commented Aug 22, 2023

dummy-1111 Aug 23, 2023

narefyev91 Aug 23, 2023 •

edited

Loading

narefyev91 Aug 23, 2023

dummy-1111 Aug 23, 2023

narefyev91 Aug 23, 2023

bernhardoj Aug 23, 2023

narefyev91 Aug 23, 2023

pecanoro Aug 23, 2023

spcheema Aug 24, 2023

narefyev91 Aug 24, 2023

OSBotify commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #24624

Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #24624

Conversation

spcheema commented Aug 16, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 16, 2023

spcheema commented Aug 16, 2023

narefyev91 commented Aug 17, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment

Choose a reason for hiding this comment

narefyev91 left a comment

Choose a reason for hiding this comment

narefyev91 commented Aug 17, 2023 • edited Loading

pecanoro commented Aug 17, 2023

spcheema commented Aug 17, 2023 • edited Loading

pecanoro commented Aug 18, 2023

spcheema commented Aug 18, 2023

pecanoro commented Aug 18, 2023

spcheema commented Aug 18, 2023

spcheema commented Aug 18, 2023

spcheema commented Aug 22, 2023 • edited Loading

narefyev91 commented Aug 22, 2023

pecanoro commented Aug 22, 2023

pecanoro left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 22, 2023

fedirjh commented Aug 22, 2023

Choose a reason for hiding this comment

narefyev91 Aug 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

spcheema commented Aug 16, 2023 •

edited

Loading

narefyev91 commented Aug 17, 2023 •

edited

Loading

narefyev91 commented Aug 17, 2023 •

edited

Loading

spcheema commented Aug 17, 2023 •

edited

Loading

spcheema commented Aug 22, 2023 •

edited

Loading

narefyev91 Aug 23, 2023 •

edited

Loading