Deploy Checklist: New Expensify 2023-08-28

[OSBotify]

Release Version: 1.3.58-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• refactor: SelectionList multiple selection #22622
• Extract emojis from paste text #23153
• Fix Tooltip content only have comma in content when hovering group chat with non-register users #23807
• fix keyboard flashing while clicking "Add attachment" #23994
• [UI]-Dropdown Button #24034
• [No QA] Onyx type core data #24054
• migrate ReportScreen.js #24111
• Fix: Quickly press different menu items opens them one by one #24173
• migrate native AttachmentPicker to functional component #24364
• Fix/22929 forwardref console error #24405
• Display status emojis in the LHN (including the user's own status) #24414
• DateUtils refactor, remove moment from the code, timezone fixes. #24446
• Fix emoji picker hide itself when there is an archived chat in the navigation stack #24479
• Fix: Edit composer moves focus to main composer after press LHN menu item #24481
• chore: update extensions allowed by ios app #24493
• fix: popover without overlay changes #24515
• Create SaaStr Demo flow #24535
• Disable Drag & Drop by default #24536
• fix: move emoji suggestions to portals #24541
• The popup menu overlaps the + icon on room #24542
• fix: sync draft and edit status of thread first chat #24544
• [No QA] Allow distance requests to be viewed #24556
• Remove policy expense chat beta #24579
• [No QA] Add details for distance requests in MoneyRequestView #24589
• Fix/24389 - Request a money - Clicking on the avatar open a wrong profile #24624
• Fix: Copy to clipboard button does not copy content of an IOU edit comment #24630
• fix:copy-update admin only posting rooms #24643
• Display single waypoint #25161
• [NoQA] Optimistically update receipt state to OPEN when the request is edited #25385
• Migrate BaseOptionsList.js to functional component #25401
• Add Download Banner to mWeb #25418
• Add edit request button to the report action context menu #25429
• Display Route #25434
• Add subscriber to money request view to immediately update view #25435
• Migrate OnfidoPrivacy.js to functional component #25458
• Category MenuItem and CategoryPicker component #25470
• [CP Staging] fix: do not show link on just BlockingView #25516
• Add GTM to helpDot #25519
• fix: 23958 reload attachment preview and close, app displays random chat for few seconds #25521
• Fix: 24375 Navigation arrows are not shown on PDF until navigated to an image #25529
• [No QA] Fix require cycle from subscribeToReportCommentPushNotifications #25544
• Performance: Onyx new storage wrapper (idk-keyval) #25565
• Migrate ImageView to a functional component #25579
• Fix scroll on native when going back to the login page  #25590
• #25561: apply flex1 to MenuItems titleStyle in MoneyRequestConfirmationList #25593
• Fix "Copy URL to clipboard" not working by long tap #25599
• fix: allow vertical scroll on multiline horizontal scrollable code block for Android Chrome #25605
• Remove navigating to assignee page from task header action button #25609
• [CP Staging] Polish displaying receipts in chat #25613
• App allows '÷×' symbols in legal name even though error states that 'Name can only include letters' #25615
• Return early for hidden notification preference #25618
• Do not parse to reportActionID to int when building comment linking url #25623
• fix: use stripped amount for new selection #25624
• [No QA] Consolidate mapbox SDK setup in with setupNode #25628
• [No QA] Pass required secrets to setupNode #25630
• [No QA] Forward secrets to called workflows #25631
• [No QA] Add some notes about secrets in GitHub Actions #25635
• add show link back home on profile page #25642
• Fix iframe for Google Sign-In #25645
• [No QA] Configure MapBox separately from node #25651
• Fix Issue 24522: User should not access add debit card with no permissions #25652
• fix IllustratedHeaderPageLayout.js padding bottom #25654
• [No QA] Configure MapBox before running pod install #25655
• Implement backTo param for ProfilePage navigation #25658
• fix: last backtick should be in inline codeblock when sending a text wrapped with two backticks #25659
• Mention list doesnt automatically popup when typing @ #25660
• [CP Staging]Remove zero prefix from time #25665
• fix: hide the edit modal if request can not be edited #25666
• Show the delete option on transaction thread correctly #25669
• rewrite BaseModal to a functional component #25672
• Fix different grayness levels on parent and child messages. #25675
• Create Card-Rev-Share-for-Approved-Partners.md #25677
• Make sure to use the link as a key for transaction #25682
• fix: don't show merchant info for split bill #25684
• [CP Staging] Remove global styling in BaseHTMLEngineProvider #25691
• Imitate web event in native image renderer #25700
• Edit merchant field of money requests #25702
• Fix for frozen UI state on desktop after redirect from 3rd party sign in #25706
• Fixing the freeze on ios when we choose multiple emojis quickly #25708
• Fix Apple Sign In token path #25710
• [CP Staging] Pass merchant back when editing money requests #25719
• fix: allow decimal values without integer in reimbursement amount #25723
• Revert "Merge pull request #24544 from eh2077/21527-fix-sync-draft-and-edit-status-of-thread-first-chat" #25724
• Fix admin post only welcome message #25726
• Block emoji reaction on report actions of report with errors #25729
• Only pass strings with a valid number to Str.fromUSDToNumber #25734
• [CP] impose max length on merchant name in money requests #25738
• Fix: Android - Error attempting to download an attachment #25742
• [24231] Fixed completed task in English instead of Spanish. #25743
• [No QA][TS migration] Migrate 'getPlatform' constants dependency to TypeScript #25745
• [No QA][TS migration] Migrate 'NAVIGATORS.js' constant to TypeScript #25746
• [NO QA] [TS migration] Migrate 'SCREENS.js' constant to TypeScript #25747
• [No QA] [TS migration] Migrate roundToNearestMultipleOfFour function to TypeScript #25749
• [No QA] migrate config to ts #25753
• [No QA] [TS migration] Migrate 'writingDirection.js' style to TypeScript #25755
• Add developmentDebug to debuggableVariants #25757
• Performance: chat input #25758
• fix: Inconsistent error messages shown on wrong magic code #25762
• [No QA][TS migration] Migrate 'CONST.js' constant to TypeScript #25764
• [No QA] [TS migration] Migrate sizing.js to TypeScript #25766
• [CP Staging] Unread messages fix: change from Etc/UTC to UTC #25772
• Revert "fix: revalidate upon input and refocus if error occurs" #25781
• Cleanup tab selector translations #25782
• Hide Overflow of Google Signin Button [DEPLOY BLOCKER] #25789
• Make the merchant field be populated #25794
• [CP Staging] fix "Google icon on sign in page shows overflow horizontal scrolling bars" #25799
• [CP Staging] Stop showing receipt images for cash requests #25800
• [CP staging] Disable assigning users who do not yet exist to tasks #25806
• Performance: optimize getDefaultAvatar calculation #25816
• [No QA] [TS migration] Migrate 'wordBreak' style to TypeScript #25825
• [No QA] [TS migration] Migrate 'whiteSpace' style to TypeScript #25826
• [No QA] [TS migration] Migrate 'visibility' style to TypeScript #25828
• [No QA] [TS migration] Migrate 'flex.js' style to TypeScript #25831
• [No QA] [TS migration] Migrate 'userSelect' style to TypeScript #25832
• [No QA] [TS migration] Migrate 'pointerEventsAuto' style to TypeScript #25840
• [No QA] [TS migration] Migrate 'overflowXHidden' style to TypeScript #25842
• [No QA] [TS Migration] Migrate overflowAuto to TypeScript #25844
• [No QA] [TS migration] Migrate 'optionAlternateTextPlatformStyles' style to Typescript #25848
• [No QA] [TS migration] Migrate 'italic' style to TypeScript #25849
• [No QA] [TS migration] Migrate 'getPopOverVerticalOffset' style to TypeScript #25858
• [NoQA] Look for patch files changes in set up node action #25861
• [No QA][TS migration] Update Typescript guidelines: 'satisfies' keyword + module augmentation #25862
• Fixing the race condition on history.go due to buggy queue async callbacks #25866
• fix: suppress highlight on iOS for workspace bills #25873
• add margin bottom below show more #25876
• Fixed composer not catching paste events when unfocused #25900
• Fix PDF zooming to top left on double tap #25907
• Fix: Inconsistent auto capitalize between legal name page and display name page. #25911
• Fix multiple metro versions #25912
• Update money request related pages PropTypes #25914
• [No QA] [TS Migration] convert ThemeStylesContext.js style to TypeScript #25915
• [No QA] [TS migration] Migrate 'optionRowStyles' style to TypeScript #25916
• [No QA] [TS migration] Migrate 'codeStyles' style to TypeScript #25917
• [No QA] [TS migration] Migrate 'fontFamily' style to TypeScript #25918
• [No QA] [TS migration] Migrate 'getNavigationModalCardStyles' style to TypeScript #25923
• Default to empty merchant for receipt requests #25924
• [No QA] [TS migration] Migrate 'variables.js' style to TypeScript #25943
• [No QA] [TS migration] Migrate 'overflow.js' style to TypeScript #25944
• Make sure composer doesn't render in loading state (null) #25957
• Update en.js #25958
• Fix: skeleton ui does not show when contact are loading #25959
• [NoQA] Revert "Fixing the race condition on history.go due to buggy queue async callbacks" #25963
• Don't focus when ref composer is unmounted #25981
• match Dev logo color to Staging and fix clipping of logo in smaller screens #25986
• [NO QA] fix getPlatform method by deleting index.js file #26023
• remove screenwrapper causing extra padding in large devices #26042
• Fix BaseModal #26045
• [CP Staging] Fix/24389 - Request a money - Clicking on the avatar open a wrong profile  #26055
• Fix: use focusWithDelay #26057
• [No QA] [TS migration] Add naming conventions for prop types #26081
• [CP Staging] Modified buildTransactionThread function to accept requestReportID #26118
• Revert "Fix different grayness levels on parent and child messages." #26211
• [CP stag] 26193-Attachment- Uploading PDF displays error #26218
• Fix null reports #26257
• fix crash when clicking UP key from keyboard after requesting money #26265

Deploy Blockers:

• [HOLD for payment 2023-09-07] [HOLD for payment 2023-09-06] Web - Request money details are missing if money requested in offline mode #26115
• Web - When click on requested IOU, the message "This is the beginning of the chat" is displayed for a brief period #26116
• Share code shows wrong default avatar #26135
• IOU - “Hmm... it’s not here...” page is open if tap on Request Money #26137
• Web - After refreshing the page, the task title and description fields do not automatically focus #26139
• [HOLD for payment 2023-10-13] Chat - Chat history not loading after returning from offline #26143
• [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] [mWeb] - Chat - Context menu doesn't close after user goes to the previous page #26178
• [HOLD for payment 2023-09-08] Web - App Crashes when reloading after editing the Merchant #26181
• Web - Thread - The parent thread becomes blank and all messages are deleted momenterly when refreshing the page after assigning tasks #26189
• [HOLD for payment 2023-10-09] [$500] Login - Abracadabra/2FA page displays but user can't login/continue until page is reloaded #26190
• LHN - Transaction thread changes to [Deleted message] after reloading #26191
• [HOLD for payment 2023-09-07] [HOLD for payment 2023-09-06] [$1000] Attachment- Uploading PDF displays error #26193
• IOU - IOU details page crashes after refreshing #26195
• Workspace - Infinite loading UI skeleton in invite new members after refresh #26196
• [HOLD for payment 2023-09-07] [HOLD for payment 2023-09-06] Chat - App crashes when returning online after sending message offline #26204
• Workspace - Specific error message which number should BA end not displayed when adding BA #26208
• [HOLD for payment 2023-09-07] [HOLD for payment 2023-09-06] [$1000] Request money: App Crashes when clicking UP key from keyboard after requesting money #26209
• [HOLD for payment 2023-10-02] [$500] Workspace - In Invite new members the "Contacts" caption does not disappear when scrolling #26243
• [HOLD for payment 2023-09-07] [$500] [HOLD for payment 2023-09-06] Web - App crashes for user B when user A deletes IOU request while both users opens the same request #26251
• [$1000] App crashed when revisiting thread from left room #26256

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.58-0 🚀

[luacmartins]

Checking off #26139. Demoted to NAB.

[luacmartins]

Checking off #26115. We merged a fix and it's being CPed to staging.

[mvtglobally]

Took me a while :phew: but checking off below as they were deployed in previous builds

#22622
#23153
#23994
#24034
#24364
#24446
#24481
#24515
#24535
#24536
#24544
#24579
#24624
#24630
#24643
#25161
#25418
#25434
#25435
#25470
#25516
#25593
#25599
#25609
#25613
#25615
#25623
#25642
#25645
#25658
#25665
#25666
#25669
#25677
#25682
#25684
#25691
#25702
#25706
#25710
#25719
#25723
#25724
#25726
#25729
#25734
#25738
#25772
#25781
#25789
#25794
#25799
#25800
#25806

[amyevans]

Couldn't repro #26196 and also it doesn't need to block deploy, so checking it off

[luacmartins]

Checking off #26181, #26191, #26195 fix is in Web-E

[luacmartins]

Checking off #26193. We CPed a fix

[luacmartins]

Checking off #26243. It's repro in prod.

[mvtglobally]

@luacmartins Regression is completed

#24111 is failing #26136. repro in PROD checking off
#24414 is failing #26129. repro in PROD checking off
#25429 is failing #26137
#25458 is failing #26207. repro in PROD checking off
#25565 there not specific issues linked to this as regression. Are we ok to check off?
#25660 is failing #25649. repro in PROD , checking off
#25757 (comment) checking off
#25907 is blocked on Android by #26193, IOS is pass
Checking off #25914 (comment)
Validating 2 CPs
#26211
#26218

[luacmartins]

Checking off #26251. We CPed a fix

[luacmartins]

Checking off #26256 - reproducible in prod

[luacmartins]

Checking off #26208. Demoted to NAB.

[luacmartins]

Checking off #26190. Demoted to NAB.

[luacmartins]

Checking off #26178. Demoted to NAB.

[luacmartins]

Checking off #26209. Demoted to NAB.

[luacmartins]

Checking off #25429. I tested on staging and it's a pass!

[luacmartins]

Checking off #25565. Regression tests should have covered everything here.

[luacmartins]

Checking off #26218. Tested on staging and it's a pass.

[luacmartins]

Checking off #26257. Tested on staging and it's a pass.

[luacmartins]

Seems like we have a blocker in dev - https://expensify.slack.com/archives/C01GTK53T8Q/p1693346447509569

[luacmartins]

We cleared all blockers. Checklist is clean. Kicking off the deploy.

[luacmartins]