Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Wallet - An error in console then navigated to enable payments page #26207

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 29, 2023 · 31 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 29, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


issue found when executing PR #25458

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Open enable payments page http://staging.new.expensify.com/enable-payments

Expected Result:

No any error in console

Actual Result:

Error in console appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Widows / Chrome
  • MacOS / Desktop

Version Number: 1.3.58-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.6064.mp4

image

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013b278b7230ab63f1
  • Upwork Job ID: 1701552628230569984
  • Last Price Increase: 2023-09-19
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@CortneyOfstad
Copy link
Contributor

Hmm, I don't get the error that you're seeing:

Screenshot 2023-08-29 at 8 51 38 AM

Can we confirm that this is not just a local issue @lanitochka17?

@b4s36t4
Copy link
Contributor

b4s36t4 commented Aug 29, 2023

I don't see any error with attached video, is this an issue?

@CortneyOfstad
Copy link
Contributor

Same — I don't see the error in the video, only the screenshot

@CortneyOfstad
Copy link
Contributor

@lanitochka17 bump on the comments above ^^^

@lanitochka17
Copy link
Author

Issue reproducible on Build 1.3.62-1
Console error displayed
Windows10/Chrome

Recording.22.mp4

@b4s36t4
Copy link
Contributor

b4s36t4 commented Sep 2, 2023

@lanitochka17 I think those errors are way before, it's issue with how browser and HTTP works. @CortneyOfstad We can ask in the slack weather to continue or not. I saw quite a few related to same issue.

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

@CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@CortneyOfstad
Copy link
Contributor

Going to get some internal eyes on this as well 👍

@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@CortneyOfstad
Copy link
Contributor

@youssef-lr bump on this — thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@CortneyOfstad
Copy link
Contributor

@youssef-lr bump on the above. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

@youssef-lr @CortneyOfstad this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@youssef-lr
Copy link
Contributor

I'm guessing this is coming from a library we use. I think we can make this external to look into it further.

@youssef-lr youssef-lr added the External Added to denote the issue can be worked on by a contributor label Sep 12, 2023
@melvin-bot melvin-bot bot changed the title Wallet - An error in console then navigated to enable payments page [$500] Wallet - An error in console then navigated to enable payments page Sep 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013b278b7230ab63f1

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

@zukilover
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error in console appears in enable payments page

What is the root cause of that problem?

Some content origins are not whitelisted using the Content-Security-Policy HTTP header.

What changes do you think we should make in order to solve the problem?

Add a whitelist for some external resources that we deem safe, e.g.:

<meta http-equiv="Content-Security-Policy" content="default-src 'self' data: gap: https://polyfill.io 'unsafe-inline' 'unsafe-eval';** ">

What alternative solutions did you explore? (Optional)

N/A

@melvin-bot melvin-bot bot added the Overdue label Sep 15, 2023
@CortneyOfstad
Copy link
Contributor

@ArekChr any thoughts on the proposal?

@melvin-bot melvin-bot bot removed the Overdue label Sep 15, 2023
@ArekChr
Copy link
Contributor

ArekChr commented Sep 18, 2023

I could not reproduce the issue on macOS using Chrome, and I don't have access to a Windows machine for testing. @CortneyOfstad Could you please reassign me, as I won't be able to complete the review for this checklist?

@situchan
Copy link
Contributor

situchan commented Sep 18, 2023

I can be assigned (discussed with @ArekChr on slack) but to me, this happens on mac chrome as well.

@ArekChr
Copy link
Contributor

ArekChr commented Sep 18, 2023

@situchan This console error shows randomly?

@situchan
Copy link
Contributor

@situchan This console error shows randomly?

For me, always happens on app launch or refresh

Screen.Recording.2023-09-18.at.3.00.26.PM.mov

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

@youssef-lr @CortneyOfstad @ArekChr this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Sep 20, 2023
@CortneyOfstad
Copy link
Contributor

Bump @ArekChr on @situchan's comment above

@melvin-bot melvin-bot bot removed the Overdue label Sep 20, 2023
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@CortneyOfstad
Copy link
Contributor

Alright, @youssef-lr any thoughts on this? We can consistently seem to recreate this. Any ideas?

@melvin-bot melvin-bot bot added the Overdue label Sep 25, 2023
@CortneyOfstad
Copy link
Contributor

Bump @youssef-lr

@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2023
@youssef-lr
Copy link
Contributor

Can't reproduce either, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

8 participants