Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Room - Hmm... it's not here page appears when leaving the room on another device #26136

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 28, 2023 · 46 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 28, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #24111

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Login with any Expensifail account in 2 different device
  3. Create the room with WS that have some members
  4. Send a simple text message, a picture and request to split bill
  5. Exit the room on another device

Expected Result:

You get navigated to concierge

Actual Result:

Hmm... it's not here page appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.58-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.6053.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a94d6a85e6b14ed3
  • Upwork Job ID: 1699144974222155776
  • Last Price Increase: 2023-09-05
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 28, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 28, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

@johncschuster Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

@johncschuster Still overdue 6 days?! Let's take care of this!

@johncschuster johncschuster added Engineering External Added to denote the issue can be worked on by a contributor and removed Engineering labels Sep 5, 2023
@melvin-bot melvin-bot bot changed the title Room - Hmm... it's not here page appears when leaving the room on another device [$500] Room - Hmm... it's not here page appears when leaving the room on another device Sep 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01a94d6a85e6b14ed3

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

Current assignee @johncschuster is eligible for the External assigner, not assigning anyone new.

@Expensify Expensify deleted a comment from melvin-bot bot Sep 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot removed Overdue labels Sep 5, 2023
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

📣 @sobitneupane Please request via NewDot manual requests for the Contributor role ($500)

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@johncschuster @sobitneupane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@johncschuster, @sobitneupane Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Sep 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

Current assignee @sobitneupane is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

@johncschuster, @sobitneupane Eep! 4 days overdue now. Issues have feelings too...

@sobitneupane
Copy link
Contributor

@pradeepmdk The PR you mentioned has merged. Is this issue still reproducible in your end?

@melvin-bot melvin-bot bot removed the Overdue label Sep 25, 2023
@pradeepmdk
Copy link
Contributor

pradeepmdk commented Sep 25, 2023

@sobitneupane It is working now as expected.

Screen.Recording.2023-09-25.at.9.08.35.PM.mov

@sobitneupane some blink is there before navigating to navigateToConciergeChat Can we fix it here?

@sobitneupane
Copy link
Contributor

sobitneupane commented Sep 26, 2023

some blink is there before navigating to navigateToConciergeChat Can we fix it here?

@pradeepmdk Yes. I think we should fix it. Do you have proposal?

@melvin-bot melvin-bot bot added the Overdue label Sep 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 29, 2023

@johncschuster, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

@johncschuster, @sobitneupane Still overdue 6 days?! Let's take care of this!

@johncschuster
Copy link
Contributor

bump @pradeepmdk!

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2023
@pradeepmdk
Copy link
Contributor

@johncschuster Sorry I missed the notification. let me update you now.

@pradeepmdk
Copy link
Contributor

@johncschuster @sobitneupane this issue was pusher sending delay response. before sending USER_IS_LEAVING_ROOM its send the multipleEvents so that its showing Hmm...page after getting the USER_IS_LEAVING_ROOM events its redirected to ConciergeChat.

but at the code level we are sending the USER_IS_LEAVING_ROOM first even though its sending the multipleEvents first.

broadcastUserIsLeavingRoom(reportID);

Screen.Recording.2023-10-05.at.9.26.59.PM.mov

so currently i don't have any idea how to boost USER_IS_LEAVING_ROOM pusher event first.

Note: sometime USER_IS_LEAVING_ROOM is triggered first at the time we don't have this issue.

Screen.Recording.2023-10-05.at.9.29.46.PM.mov

@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

@johncschuster, @sobitneupane Huh... This is 4 days overdue. Who can take care of this?

@johncschuster
Copy link
Contributor

@sobitneupane bump!

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@sobitneupane
Copy link
Contributor

sobitneupane commented Oct 11, 2023

Thanks for the update @pradeepmdk. Appreciate your help in the issue.

@sobitneupane
Copy link
Contributor

The nature of the issue has changed a bit. The "Hmm... it's not here page" appears only for short duration. We are looking on proposals to see if we can get rid of the Not found page.

@melvin-bot melvin-bot bot added the Overdue label Oct 13, 2023
@johncschuster
Copy link
Contributor

johncschuster commented Oct 13, 2023

Thanks for that, @sobitneupane! How would you re-title this issue to better reflect what we're looking for?

Also, do the reproduction steps still match?

(I'll update the OP and post for proposals)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

@johncschuster, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

@ayazalavi
Copy link
Contributor

The nature of the issue has changed a bit. The "Hmm... it's not here page" appears only for short duration. We are looking on proposals to see if we can get rid of the Not found page.

This bug is not reproducible anymore, page is directly going to concierage page.

@johncschuster
Copy link
Contributor

Thanks, @ayazalavi! It sounds like this behavior may have been resolved by a different issue/PR. I'm going to go ahead and close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

6 participants