fix: popover without overlay changes #24515

allroundexperts · 2023-08-13T21:16:13Z

Details

This PR fixes the following issues:
#24256
https://expensify.slack.com/archives/C049HHMV9SM/p1691745427354299
https://expensify.slack.com/archives/C049HHMV9SM/p1691745372419819

Fixed Issues

$ #24256
PROPOSAL: #24256

Tests

Login and click on the + icon in the LHN.
Press CMD+K and verify that the popover closes and search page opens.
Open any chat and right click on any message.
Move the cursor to the left in the same row, and then right click again.
Verify that the row remains hovered.
Open any popover.
Right click inside the popover.
Verify that the native context menu opens up and the popover remains visible.

Verify that no errors appear in the JS console

Offline tests

Same as test steps.

QA Steps

Same as test steps.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-14.at.11.46.29.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-14.at.12.01.25.PM.mov

Mobile Web - Safari

Screen.Recording.2023-08-14.at.12.00.40.PM.mov

Desktop

Screen.Recording.2023-08-14.at.11.55.49.AM.mov

iOS

Screen.Recording.2023-08-14.at.12.05.43.PM.mov

Android

Screen.Recording.2023-08-14.at.12.14.12.PM.mov

melvin-bot · 2023-08-14T07:26:09Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2023-08-20T21:12:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif · 2023-08-20T21:12:47Z

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

+                    horizontal: nativeEvent.pageX + CONST.MODAL.POPOVER_ANCHOR_SHIFT,
+                    vertical: nativeEvent.pageY - CONST.MODAL.POPOVER_ANCHOR_SHIFT,


Isn't there better way without changing position?

Wasn't able to find any better way. Do you have a suggestion?

Issue exported: #25582
So I think we can just revert this change and let contributors fix on that issue.

Sure thing!

is this a solution for https://expensify.slack.com/archives/C049HHMV9SM/p1691745427354299? if so this is not fixing the root cause, the hover effect will be lost when you move the mouse out, but it will stay initially right? please correct me if i am wrong.

@aimane-chnaif Reverted!

@getusha My understanding was that the hover effect was being lost because the pointer was inside the popover when it shifted. Thus I added a shift of 2px (which is considering a border of 1px for menu) which seemed to do the job.

yes you're right, that's what i thought initially, the fact that the hover wasn't lost the first time made me suspect that the issue isn't caused by that and it wasn't. additionally the hover should not be lost if the popover is active and mouseLeave triggers.

aimane-chnaif

LGTM

Beamanator · 2023-08-22T06:50:20Z

src/components/PopoverProvider/index.js

@@ -48,7 +48,10 @@ function PopoverContextProvider(props) {
    }, [closePopover]);

    React.useEffect(() => {
-        const listener = () => {
+        const listener = (e) => {
+            if (!activePopoverRef.current || !activePopoverRef.current.ref || !activePopoverRef.current.ref.current || activePopoverRef.current.ref.current.contains(e.target)) {


Oh my goodness i wish we allowed optional chaining 😅

OSBotify · 2023-08-22T06:54:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-24T03:36:31Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-28T18:54:03Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-29T00:08:12Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.57-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:23:05Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: popover without overlay changes

7884caf

allroundexperts marked this pull request as ready for review August 14, 2023 07:26

allroundexperts requested a review from a team as a code owner August 14, 2023 07:26

melvin-bot bot requested review from aimane-chnaif and removed request for a team August 14, 2023 07:26

allroundexperts added 2 commits August 14, 2023 12:27

fix: lint errors

23f3b49

Merge branch 'main' into fix-15289-followup

f84dd4b

aimane-chnaif reviewed Aug 20, 2023

View reviewed changes

aimane-chnaif mentioned this pull request Aug 21, 2023

[HOLD for payment 2023-10-16] [$1000] Web - Chat - Hover effect lost after opening popover again before closing it. #25582

Closed

6 tasks

allroundexperts added 2 commits August 22, 2023 01:59

fix: revert changes for hover lost

00f6e4f

fix: revert const changes

9ba7700

aimane-chnaif approved these changes Aug 21, 2023

View reviewed changes

melvin-bot bot requested a review from Beamanator August 21, 2023 21:09

Beamanator approved these changes Aug 22, 2023

View reviewed changes

Beamanator merged commit 6609308 into Expensify:main Aug 22, 2023

OSBotify mentioned this pull request Aug 24, 2023

Deploy Checklist: New Expensify 2023-08-24 #25813

Closed

73 tasks

melvin-bot bot mentioned this pull request Aug 28, 2023

[HOLD for payment 2023-09-04] [$1000] Chat - Pressing CMD+K when Global create is open closes the menu and doesn’t open search #24256

Closed

6 tasks

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

youssef-lr mentioned this pull request Aug 29, 2023

[HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] [mWeb] - Chat - Context menu doesn't close after user goes to the previous page #26178

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: popover without overlay changes #24515

fix: popover without overlay changes #24515

allroundexperts commented Aug 13, 2023 •

edited

Loading

melvin-bot bot commented Aug 14, 2023

aimane-chnaif commented Aug 20, 2023

aimane-chnaif Aug 20, 2023

allroundexperts Aug 21, 2023

aimane-chnaif Aug 21, 2023

allroundexperts Aug 21, 2023

getusha Aug 21, 2023

allroundexperts Aug 21, 2023

allroundexperts Aug 21, 2023

getusha Aug 21, 2023

aimane-chnaif left a comment

Beamanator Aug 22, 2023

OSBotify commented Aug 22, 2023

OSBotify commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

		horizontal: nativeEvent.pageX + CONST.MODAL.POPOVER_ANCHOR_SHIFT,
		vertical: nativeEvent.pageY - CONST.MODAL.POPOVER_ANCHOR_SHIFT,

fix: popover without overlay changes #24515

fix: popover without overlay changes #24515

Conversation

allroundexperts commented Aug 13, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 14, 2023

aimane-chnaif commented Aug 20, 2023

Reviewer Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aimane-chnaif left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Aug 22, 2023

OSBotify commented Aug 24, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

allroundexperts commented Aug 13, 2023 •

edited

Loading