DateUtils refactor, remove moment from the code, timezone fixes. #24446

waterim · 2023-08-11T17:08:46Z

Details

This PR is about refactoring DateUtils and usage of it, removing all moment and timezone configuration.

Fixed Issues

$ #19810
PROPOSAL: #19810 (comment)

Tests

Login to the app
Go to some report
Verify all dates and time

Verify that no errors appear in the JS console

Offline tests

N/A automated tests

QA Steps

Login to the app
Go to some report
Verify all dates and time

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

N/A automated tests

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

…sage of moment

tests/unit/DateUtilsTest.js

src/libs/DateUtils.js

tests/unit/DateUtilsTest.js

src/libs/DateUtils.js

rezkiy37

Left a couple comments

melvin-bot · 2023-08-14T13:27:07Z

@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thienlnam · 2023-08-14T14:32:37Z

Doesn't look like the reviewers were linked correctly - updating from the issue

allroundexperts · 2023-08-15T18:45:20Z

src/libs/DateUtils.js

-// IMPORTANT: load any locales (other than english) that might be passed to moment.locale()
-import 'moment/locale/es';
+import {zonedTimeToUtc, utcToZonedTime, formatInTimeZone} from 'date-fns-tz';
+import {es, enGB} from 'date-fns/locale';


Nice. I love the alternative!

It's 3x smaller.

mountiny

Thank you @waterim and everyone who has reviewed this til now. Looking good to me, going to wait for @allroundexperts review and testing

allroundexperts · 2023-08-16T09:57:47Z

Hi @waterim!

Can you please mention clear test steps for this?

waterim · 2023-08-16T10:40:34Z

Hey @allroundexperts
Added tests, you need to verify all dates and time to be correct in reports

allroundexperts · 2023-08-16T11:38:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-22.at.1.24.57.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-22.at.1.39.27.AM.mov

Mobile Web - Safari

Screen.Recording.2023-08-22.at.1.42.46.AM.mov

Desktop

Screen.Recording.2023-08-22.at.1.31.57.AM.mov

iOS

Screen.Recording.2023-08-22.at.1.43.53.AM.mov

Android

Screen.Recording.2023-08-22.at.1.41.31.AM.mov

allroundexperts · 2023-08-16T14:14:03Z

Getting the following error on iOS Safari:

allroundexperts · 2023-08-16T14:14:37Z

@waterim Can you please upload the screen recordings on all the platforms?

allroundexperts · 2023-08-16T14:15:22Z

Getting this on iOS native:

waterim · 2023-08-16T14:24:12Z

@allroundexperts oh, I see, verifying it rn
"Can you please upload the screen recordings on all the platforms?" screenshots with report screen?

mountiny · 2023-08-16T14:30:31Z

Yep, screenshots should work

waterim · 2023-08-18T15:54:47Z

@mountiny your list is correct, as I can see it has full IANA support

waterim · 2023-08-18T16:27:59Z

@allroundexperts Not sure if I understand you correctly, but polyfill works correctly, it takes only IANA timezones, meanwhile on web(without polyfill) Intl.supportedValuesOf("timeZone") is taking different standard ECMAScript Internationalization API which is breaking date-fns functions.

mountiny · 2023-08-21T13:11:17Z

@waterim could you leave a link in the timezones page what is the source so its traceable, thanks!

@allroundexperts also ready for another look

waterim · 2023-08-21T14:46:18Z

@mountiny Added

src/pages/settings/Profile/TimezoneSelectPage.js

allroundexperts

Working good now. Thanks for the changes @waterim!

melvin-bot · 2023-08-21T20:54:48Z

🎯 @allroundexperts, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #25619.

mountiny

Nice, thanks everyone!

OSBotify · 2023-08-22T01:17:00Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.56-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

quinthar · 2023-08-22T02:52:21Z

FYI, a regression was found here: https://expensify.slack.com/archives/C049HHMV9SM/p1692671896444999

mvtglobally · 2023-08-22T03:38:07Z

#25650 issue for above

marcaaron · 2023-08-23T02:40:24Z

Heads up this also caused a regression related to marking things as unread on iOS. Web is unaffected.

OSBotify · 2023-08-24T03:05:53Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-28T18:54:33Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:23:35Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

0xmiros · 2024-01-05T15:38:47Z

src/libs/DateUtils.js

    let todayAt = Localize.translate(locale, 'common.todayAt');
    let tomorrowAt = Localize.translate(locale, 'common.tomorrowAt');
    let yesterdayAt = Localize.translate(locale, 'common.yesterdayAt');
    const at = Localize.translate(locale, 'common.conjunctionAt');

+    const startOfCurrentWeek = startOfWeek(new Date(), {weekStartsOn: 1}); // Assuming Monday is the start of the week
+    const endOfCurrentWeek = endOfWeek(new Date(), {weekStartsOn: 1}); // Assuming Monday is the start of the week
+


This caused regression.
While updating week start day to Monday on header, body still remains as Sunday for the start day

DylanDylann · 2024-05-20T07:10:51Z

src/libs/DateUtils.js


    // If the date is equal to the end of today
-    if (input.isSame(endOfToday)) {
+    if (isSameDay(input, endOfToday)) {


It caused this bug because if we set custom time after 30 minutes, the isSameDay function still returns true

refactored DateUtils, timezone fixes, additional tests, removed all u…

2661c3e

…sage of moment

BeeMargarida reviewed Aug 14, 2023

View reviewed changes

tests/unit/DateUtilsTest.js Outdated Show resolved Hide resolved

BeeMargarida reviewed Aug 14, 2023

View reviewed changes