Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Infinite loading UI skeleton in invite new members after refresh #26196

Closed
1 of 6 tasks
izarutskaya opened this issue Aug 29, 2023 · 11 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed

Comments

@izarutskaya
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open settings then workspaces open any workspace
  2. Click members then Invite to open the Invite new members page
  3. refresh the page

Expected Result:

The suggested acounts should be displayed in the Invite new members page

Actual Result:

Infinite loading UI skeleton in invite new members after refresh

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.58-1

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screencast.From.29-08-23.06.30.13.mp4
Recording.1358.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Ahmed-Abdella)

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693280180858769

View all open jobs on GitHub

@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@izarutskaya izarutskaya added the DeployBlockerCash This issue or pull request should block deployment label Aug 29, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 29, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@aimane-chnaif
Copy link
Contributor

Dupe of #22508

@Ahmed-Abdella
Copy link
Contributor

Please note that the behavior in staging differs from production. In production the invite new members page is blank

@aimane-chnaif
Copy link
Contributor

In production the invite new members page is blank

This is also bug. We should show skeleton

@amyevans
Copy link
Contributor

Hmm I can't reproduce (tried on both staging and local)

Staging:

26196-staging.mov

Local:

26196-local.mov

@jliexpensify could you try as well? In any event, this shouldn't block deploy.

@amyevans amyevans added Daily KSv2 Needs Reproduction Reproducible steps needed and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 29, 2023
@aimane-chnaif
Copy link
Contributor

This is interesting bug. Some people can reproduce but some people not. May depend on device, OS, browser versions.
Because of that, #22508 was closed, reopened and then closed again.
More details about the root cause: #22850 (comment)

@jliexpensify
Copy link
Contributor

So this happened to me:

image

Here were my repro steps:

  1. Open settings then workspaces open any workspace
  2. Click out of New.Dot and into this GH
  3. Click back into New.Dot tab and see it crash

So I couldn't even complete this the first time.

I tried again a second time, after refreshing, and wasn't able to reproduce. I think it's probably to do with general instability, since it's not always reproducible? cc @amyevans

@amyevans
Copy link
Contributor

Okay thanks for giving it a shot. Regardless it seems pretty inconsistent and definitely an edge case. Given that, I don't think it's worth expending more effort on it at the moment, so going to close. Feel free to reopen though if you disagree @jliexpensify!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

6 participants