[HOLD for payment 2023-09-06] [$1000] skeleton ui does not show when contact are loading

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. go to Settings > Workspaces >members
2. click on invite button

Expected Result:

skeleton ui should show while contacts are loading

Actual Result:

contact appears after 1 second and does not show skeleton ui

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.57-2

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-23.At.1.25.12.Pm.mp4

Recording.1319.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692777344552489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f892a2c55733ea89
• Upwork Job ID: 1695095374712561664
• Last Price Increase: 2023-08-25

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No skeleton on workspace invite page

What is the root cause of that problem?

While migrating from OptionSelector to SelectionList we haven't used the prop showLoadingPlaceholder in place of shouldShowOptions seems the cause of the issue.
https://github.com/Expensify/App/pull/22622/files#diff-7040f9d045bb4fd912718e140643e494268c688306bec7a1928376d9003566daL227

What changes do you think we should make in order to solve the problem?

Use showLoadingPlaceholder for SelectionList in the WorkspaceInvitePage with the conditions which we are using earlier.

showLoadingPlaceholder={!didScreenTransitionEnd || !OptionsListUtils.isPersonalDetailsReady(props.personalDetails)}

Result

Screen.Recording.2023-08-25.at.02.07.42.mov

[hayata-suenaga]

Confirmed this is only on staging

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f892a2c55733ea89

[melvin-bot]

Triggered auto assignment to @lschurr (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[hayata-suenaga]

@ntdiary can you review @Pujan92's proposal?

[ntdiary]

@hayata-suenaga, sure , will start reproducing this issue and reviewing this shortly. 🙂

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.58-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: skeleton ui does not show when contact are loading #25959

If no regressions arise, payment will be issued on 2023-09-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter @gadhiyamanan $250
• Contributor that fixed the issue @Pujan92 $1500
• Contributor+ that helped on the issue and/or PR @aimane-chnaif $1500

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment
• @aimane-chnaif requires payment
• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[tjferriss]

The PR was merged in under three days so contributor and C+ are eligible for the bonus.

@Pujan92 @aimane-chnaif @gadhiyamanan Can you all please apply to the job in Upworks: https://www.upwork.com/jobs/~01f892a2c55733ea89

[gadhiyamanan]

Applied to upwork job

[tjferriss]

@gadhiyamanan I've hired you in Upworks.

@aimane-chnaif can you please get started on the checklist?

[melvin-bot]

@tjferriss, @Pujan92, @aimane-chnaif, @hayata-suenaga Huh... This is 4 days overdue. Who can take care of this?

[aimane-chnaif]

The regression came from SelectionList migration refactor in #22622.
Since it was huge PR, this could have been easily missed.

We can reuse Regression Test in #18828 (comment) but just replace "loading animation" with "skeleton" in last step per each case.

[hayata-suenaga]

I think this issue is waiting for payment. Not overdue

[tjferriss]

@aimane-chnaif @Pujan92 I've sent you both an offer via Upworks for payment.

[melvin-bot]

@tjferriss, @Pujan92, @aimane-chnaif, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hayata-suenaga]

waiting for the offer to be accepted

[aimane-chnaif]

accepted invite already

[Pujan92]

@aimane-chnaif @Pujan92 I've sent you both an offer via Upworks for payment.

@tjferriss Accepted!

[tjferriss]

@aimane-chnaif I just accepted your offer. @Pujan92 I just paid you.

[tjferriss]

Everyone has been paid