-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-06-01] [$1000] Opening workspace settings by link displays 'hmm it's not here' page for few seconds #18828
Comments
Triggered auto assignment to @slafortune ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Opening workspace settings by link displays 'hmm it's not here' page for few seconds What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?We need show a Fullscreen loading indicator if if we're fetching OpenApp API. To do it, we can:
|
looks good! |
Job added to Upwork: https://www.upwork.com/jobs/~01cd95e1be49eca753 |
Current assignee @slafortune is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr ( |
Triggered auto assignment to @dangrous ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.When navigating to the Workspace Settings page by link and login, App displays 'hmm it's not here' page until page is loaded. What is the root cause of that problem?In here
this.props.policy is empty. When we navigate to the Workspace Settings page by link and login, the policy wasn't loaded yet (using the OpenApp API), so it shows Not Found briefly until the policy is loaded.
What changes do you think we should make in order to solve the problem?The same issue happens for the
We need to check for both conditions because if we only check for the
to
propTypes and defaultProps for the isLoadingReportData . That approach to checking if report data is loaded has been used the same in other places like here.
What alternative solutions did you explore? (Optional)I'd also suggest to retest all pages that use the |
@dangrous @slafortune the proposal from @dukenv0307 looks good to me! 🎀 👀 🎀 C+ reviewed! |
Yep, that makes sense to me - assigning now! |
📣 @dukenv0307 You have been assigned to this job by @dangrous! |
@dangrous, @slafortune, @mollfpr, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-06-01. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@dhanashree-sawant, @mollfpr @dukenv0307 Offers sent! |
No offending PR. This is an improvement to show the loading state while the policy is fetched.
The regression step should be enough.
Yes!
The regression step will cover the place where PR has the changes. Mostly the step is the same. Test cases
|
Paid! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
App should display loading animation until page is loaded
Actual Result:
App displays 'hmm it's not here' page until page is loaded
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.13.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
hmm.its.not.here.on.login.and.workspace.settings.mp4
Recording.574.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683803147715459
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: