Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - There is no separating line for members #25966

Closed
6 tasks done
lanitochka17 opened this issue Aug 25, 2023 · 8 comments
Closed
6 tasks done

Workspace - There is no separating line for members #25966

lanitochka17 opened this issue Aug 25, 2023 · 8 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 25, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to workspace settings with some members
  2. Go to Members

Expected Result:

A line separating members

Actual Result:

There is no line to separate members

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.57-4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

image (2)

image (3)

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692932540845369

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Aug 25, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 25, 2023

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kavimuru kavimuru changed the title Workspace - here is no separating line for members Workspace - There is no separating line for members Aug 25, 2023
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 25, 2023
@mountiny mountiny assigned cristipaval and unassigned srikarparsi Aug 25, 2023
@mountiny
Copy link
Contributor

This is a new design, not a blocker, @cristipaval can confirm if its 100% intentional cc @thiagobrez

@thiagobrez
Copy link
Contributor

thiagobrez commented Aug 25, 2023

Yeah its intentional, I'm on mobile so can't find the thread right now, but @shawnborton can confirm

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@cristipaval
Copy link
Contributor

Couldn't find in the issue nor in the PR any confirmation from @shawnborton that we should have or not have the line separator. cc @Expensify/design as we now have more than 1 designer ❤️

@melvin-bot melvin-bot bot removed the Overdue label Aug 28, 2023
@thiagobrez
Copy link
Contributor

Hey @cristipaval, Shawn mentioned here and here

@shawnborton
Copy link
Contributor

Yup, that's right - let's get rid of the horizontal separator lines. I think it looks much cleaner without them, matches other list selections across the app, and lets the list be a bit more compact.

@cristipaval
Copy link
Contributor

ah, it was in the main tracker issue. Great! I'll close this issue then. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants