Fix report action is still detected as attachment even after we delete it #24539

bernhardoj · 2023-08-14T14:58:42Z

Details

When we delete an attachment message of a thread, we still treated it as an attachment even though the attachment is gone and replaced by [Deleted message].

Fixed Issues

$ #24216
PROPOSAL: #24216 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open any chat
Send an attachment.
Press "Reply in thread" on the attachment message
Delete the attachment message
Verify the space between [Deleted message] and your user display name is small (consistent with how a non-attachment deleted message looks)

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-14.at.21.18.46.mov

Mobile Web - Chrome

Screen.Recording.2023-08-14.at.21.40.53.mov

Mobile Web - Safari

Screen.Recording.2023-08-14.at.21.29.54.mov

Desktop

Screen.Recording.2023-08-14.at.21.25.12.mov

iOS

Screen.Recording.2023-08-14.at.21.27.23.mov

Android

New.Expensify.Dev.1.mp4

…-delete

melvin-bot · 2023-08-14T14:58:47Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-08-14T15:10:20Z

Set isAttachment to false when we delete a message.

I didn't do this because isAttachment is used in some places and I'm afraid that it will break the behavior while offline.

We currently have 2 issues with thread that can be noticed from the recording:

Console warning when opening a thread is here [Hold on 306294] Console error while opening child reports #24349
Message disappear for a second is here [HOLD for payment 2023-09-20] [$1000] Temporary thread message disappearance when deleting a thread message #23139

cubuspl42

Overall looks good, I'll start doing the checklist

cubuspl42 · 2023-08-15T11:37:08Z

src/pages/home/report/ReportActionItemMessage.js

    return (
-        <View style={[styles.chatItemMessage, ...props.style]}>
+        <View style={[styles.chatItemMessage, !props.displayAsGroup && isAttachment ? styles.mt2 : {}, ...props.style]}>


It's a minor thing probably, but why was undefined changed to {}? Was there any observable difference in behavior, or is it a stylistic thing?

Just a stylistic thing 😄

cubuspl42 · 2023-08-15T11:44:55Z

Verify the space between [Deleted message] and your user display name is small.

Verify the space between [Deleted message] and your user display name is small (consistent with how a non-attachment deleted message looks).

bernhardoj · 2023-08-15T11:49:07Z

Verify the space between [Deleted message] and your user display name is small.

Verify the space between [Deleted message] and your user display name is small (consistent with how a non-attachment deleted message looks).

Updated

cubuspl42 · 2023-08-15T20:26:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

fix-big-gap-web-1.mp4

Mobile Web - Chrome

fix-big-gap-web-android-1-compressed.mp4

Mobile Web - Safari

fix-big-gap-web-ios-1.mp4

Desktop

N/A

iOS

fix-big-gap-ios-1.mp4

Android

fix-big-gap-android-1-compressed.mp4

cubuspl42

LGTM

cubuspl42 · 2023-08-15T20:31:22Z

Set isAttachment to false when we delete a message.

I didn't do this because isAttachment is used in some places and I'm afraid that it will break the behavior while offline.

We currently have 2 issues with thread that can be noticed from the recording:
* Console warning when opening a thread is here [Console error while opening child reports #24349](https://github.com/Expensify/App/issues/24349)

* Message disappear for a second is here [[$1000] Temporary thread message disappearance when deleting a thread message #23139](https://github.com/Expensify/App/issues/23139)

I understand... The harsh truth is that we don't strictly need that change here (as we're removing the dependency on isAttachment property) and there's always a non-zero chance of causing a regression. You might be right, let's consider it unrelated then.

cubuspl42 · 2023-08-16T17:09:37Z

@Li357 All yours

Li357 · 2023-08-16T17:28:30Z

Reviewing now!

OSBotify · 2023-08-16T17:37:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-17T02:20:31Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-21T22:27:04Z

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:10:05Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

situchan · 2023-11-27T14:30:21Z

As everyone knows already, this PR caused regression - Web - Chat - The display name goes down when deleting an attachment in main thread

bernhardoj added 2 commits August 14, 2023 22:12

fix action is still detected as attachment even after deleted

f9e616c

Merge branch 'main' into fix/24216-still-detected-as-attachment-after…

33f1f60

…-delete

bernhardoj requested a review from a team as a code owner August 14, 2023 14:58

melvin-bot bot requested review from cubuspl42 and removed request for a team August 14, 2023 14:58

cubuspl42 reviewed Aug 15, 2023

View reviewed changes

cubuspl42 approved these changes Aug 15, 2023

View reviewed changes

melvin-bot bot requested a review from Li357 August 15, 2023 21:06

Li357 approved these changes Aug 16, 2023

View reviewed changes

Li357 merged commit bfe5c21 into Expensify:main Aug 16, 2023

OSBotify mentioned this pull request Aug 17, 2023

Deploy Checklist: New Expensify 2023-08-17 #25160

Closed

75 tasks

Pujan92 mentioned this pull request Aug 17, 2023

[HOLD for payment 2023-11-27] [$1000] Web - Chat - The display name goes down when deleting an attachment in main thread #25415

Closed

6 tasks

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

melvin-bot bot mentioned this pull request Aug 21, 2023

[HOLD for payment 2023-08-28] [$1000] When deleting a file, there is a space between the username and the '[Deleted message]' #24216

Closed

6 tasks

cubuspl42 mentioned this pull request Oct 11, 2023

Refactor comment message rendering #25524

Merged

55 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix report action is still detected as attachment even after we delete it #24539

Fix report action is still detected as attachment even after we delete it #24539

bernhardoj commented Aug 14, 2023 •

edited

Loading

melvin-bot bot commented Aug 14, 2023

bernhardoj commented Aug 14, 2023 •

edited

Loading

cubuspl42 left a comment

cubuspl42 Aug 15, 2023

bernhardoj Aug 15, 2023

cubuspl42 commented Aug 15, 2023

bernhardoj commented Aug 15, 2023

cubuspl42 commented Aug 15, 2023

cubuspl42 left a comment

cubuspl42 commented Aug 15, 2023

cubuspl42 commented Aug 16, 2023

Li357 commented Aug 16, 2023

OSBotify commented Aug 16, 2023

OSBotify commented Aug 17, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

situchan commented Nov 27, 2023

Fix report action is still detected as attachment even after we delete it #24539

Fix report action is still detected as attachment even after we delete it #24539

Conversation

bernhardoj commented Aug 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 14, 2023

bernhardoj commented Aug 14, 2023 • edited Loading

cubuspl42 left a comment

Choose a reason for hiding this comment

cubuspl42 Aug 15, 2023

Choose a reason for hiding this comment

bernhardoj Aug 15, 2023

Choose a reason for hiding this comment

cubuspl42 commented Aug 15, 2023

bernhardoj commented Aug 15, 2023

cubuspl42 commented Aug 15, 2023

Reviewer Checklist

Screenshots/Videos

cubuspl42 left a comment

Choose a reason for hiding this comment

cubuspl42 commented Aug 15, 2023

cubuspl42 commented Aug 16, 2023

Li357 commented Aug 16, 2023

OSBotify commented Aug 16, 2023

OSBotify commented Aug 17, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

situchan commented Nov 27, 2023

bernhardoj commented Aug 14, 2023 •

edited

Loading

bernhardoj commented Aug 14, 2023 •

edited

Loading