[HOLD E/E #311912] [$500] Assignee does not show on Confirm task page #25680

kavimuru · 2023-08-22T13:57:54Z

HELD for https://github.com/Expensify/Expensify/issues/311912

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

click on FAB icon and select new chat
enter email and create a new chat
click on FAB icon and select assign a task
Enter title and click on Next button
click on assignee and search for user with whom you created new chat
6.select that user

Expected Result:

Assignee does not show on Confirm task page

Actual Result:

Assignee should show on Confirm task page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.56-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-21.at.10.50.26.AM.mov

Recording.1491.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692595469205799

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0182f226dc34b9a020
Upwork Job ID: 1694007582851416064
Last Price Increase: 2023-08-22
Automatic offers:

gadhiyamanan | Reporter | 26281429

melvin-bot · 2023-08-22T13:57:59Z

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-08-22T13:58:01Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-08-22T13:59:40Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-08-22T13:59:44Z

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

aimane-chnaif · 2023-08-22T14:29:40Z

This is not a blocker. Also happens on production.

Repro step:

click on FAB icon and select new chat
enter email and create a new chat
Logout and re-login same account
click on FAB icon and select assign a task
Enter title and click on Next button
click on assignee and search for user with whom you created new chat
select that user

Screen.Recording.2023-08-22.at.3.22.22.PM.mov

melvin-bot · 2023-08-22T15:24:17Z

Job added to Upwork: https://www.upwork.com/jobs/~0182f226dc34b9a020

melvin-bot · 2023-08-22T15:24:20Z

Current assignee @CortneyOfstad is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-08-22T15:24:26Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

melvin-bot · 2023-08-22T15:24:55Z

Upwork job price has been updated to $500

b4s36t4 · 2023-08-22T15:31:27Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assignee does not show on Confirm task page

What is the root cause of that problem?

This happened after #23773 in which we've updated the way we fetch the user details to display.

Here

App/src/libs/actions/Task.js

Lines 719 to 721 in d38c06c

    
           function getAssignee(assigneeAccountID, personalDetails) { 
        
               const details = personalDetails[assigneeAccountID]; 
        
               if (!details) {

we're checking in the personalDetails.

Although we've initiated a chat with the User A, but User B haven't responded which is resulting personalDetails for the User B as undefined.

And here

App/src/libs/actions/Task.js

Line 721 in d38c06c

if (!details) {

we're returning an empty details which is causing the issue not to display anything in the Confirm task page.

What changes do you think we should make in order to solve the problem?

Since we can't do anything about the user details not available we can return with the details we have.

We can do default details instead of returning empty details which is causing the issues.

if (!details) {
    return {
        icons: [{name: assignee, type: CONST.ICON_TYPE_AVATAR, source: UserUtils.getAvatar('', assigneeAccountID)}],
        displayName: assignee,
        subtitle: assignee,
    };
}

assignee is passed form NewTaskPage which is props.task.assignee

The PR which caused the issue (maybe not) is have an issue with showing title for user icons, so we can follow the same approach we're following here to get the icon.

App/src/libs/OptionsListUtils.js

Lines 836 to 845 in c5fc369

    
               // If user doesn't exist, use a default avatar 
        
               userToInvite.icons = [ 
        
                   { 
        
                       source: UserUtils.getAvatar('', optimisticAccountID), 
        
                       name: searchValue, 
        
                       type: CONST.ICON_TYPE_AVATAR, 
        
                   }, 
        
               ]; 
        
           }

What alternative solutions did you explore? (Optional)

NA

Result

Kapture.2023-08-22.at.20.43.19.mp4

DylanDylann · 2023-08-22T15:53:28Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assignee does not show on Confirm task page

What is the root cause of that problem?

When assignong a task to an assignee, we will check if chatReport with this assignee is existed or not

App/src/libs/actions/Task.js

Lines 654 to 673 in 999ed93

    
           if (!chatReport) { 
        
               chatReport = ReportUtils.buildOptimisticChatReport([assigneeAccountID]); 
        
               chatReport.isOptimisticReport = true; 
        
               // When assigning a task to a new user, by default we share the task in their DM 
        
               // However, the DM doesn't exist yet - and will be created optimistically once the task is created 
        
               // We don't want to show the new DM yet, because if you select an assignee and then change the assignee, the previous DM will still be shown 
        
               // So here, we create it optimistically to share it with the assignee, but we have to hide it until the task is created 
        
               chatReport.isHidden = true; 
        
               Onyx.set(`${ONYXKEYS.COLLECTION.REPORT}${chatReport.reportID}`, chatReport); 
        
               // If this is an optimistic report, we likely don't have their personal details yet so we set it here optimistically as well 
        
               const optimisticPersonalDetailsListAction = { 
        
                   accountID: assigneeAccountID, 
        
                   avatar: lodashGet(allPersonalDetails, [assigneeAccountID, 'avatar'], UserUtils.getDefaultAvatarURL(assigneeAccountID)), 
        
                   displayName: lodashGet(allPersonalDetails, [assigneeAccountID, 'displayName'], assigneeEmail), 
        
                   login: assigneeEmail, 
        
               }; 
        
               Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, {[assigneeAccountID]: optimisticPersonalDetailsListAction}); 
        
           }

If it does not exist, we will create an optimistic chat report and add this assignee to PERSONAL_DETAILS_LIST (on ONYX)

Then when displaying the assignee field we will get information from PERSONAL_DETAILS_LIST based on assigneeAccountID

But in this case, because we init the chat with this user before. So the condition check !chatReport is false

App/src/libs/actions/Task.js

Line 654 in 999ed93

if (!chatReport) {

and this user will be not added to PERSONAL_DETAILS_LIST. So It displayed empty when displaying the assignee field

What changes do you think we should make in order to solve the problem?

when assigning new assignee we also should check if chat report exist and this assignee is not in PERSONAL_DETAILS_LIST, we will add this user to PERSONAL_DETAILS_LIST like here

App/src/libs/actions/Task.js

Lines 666 to 672 in 999ed93

    
           const optimisticPersonalDetailsListAction = { 
        
               accountID: assigneeAccountID, 
        
               avatar: lodashGet(allPersonalDetails, [assigneeAccountID, 'avatar'], UserUtils.getDefaultAvatarURL(assigneeAccountID)), 
        
               displayName: lodashGet(allPersonalDetails, [assigneeAccountID, 'displayName'], assigneeEmail), 
        
               login: assigneeEmail, 
        
           }; 
        
           Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, {[assigneeAccountID]: optimisticPersonalDetailsListAction});

What alternative solutions did you explore? (Optional)

When create new chat with new user, we also add this user to PERSONAL_DETAILS_LIST like here

App/src/libs/actions/Task.js

Lines 666 to 672 in 999ed93

    
           const optimisticPersonalDetailsListAction = { 
        
               accountID: assigneeAccountID, 
        
               avatar: lodashGet(allPersonalDetails, [assigneeAccountID, 'avatar'], UserUtils.getDefaultAvatarURL(assigneeAccountID)), 
        
               displayName: lodashGet(allPersonalDetails, [assigneeAccountID, 'displayName'], assigneeEmail), 
        
               login: assigneeEmail, 
        
           }; 
        
           Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, {[assigneeAccountID]: optimisticPersonalDetailsListAction});

parteekcoder · 2023-08-22T19:49:10Z

Proposal

Please re-state the problem that we are trying to solve in this issue

After selecting an assignee, it still shows Assignee on Confirm task page

What is the root cause of that problem?

Here in this Menu option, there is no check that if an assignee is already chosen then don't show the Assignee option

https://github.com/Expensify/App/blob/main/src/pages/tasks/NewTaskPage.js#L168-#L175

         <MenuItem
                            label={assignee.displayName ? props.translate('task.assignee') : ''}
                            title={assignee.displayName || ''}
                            description={assignee.displayName ? LocalePhoneNumber.formatPhoneNumber(assignee.subtitle) : props.translate('task.assignee')}
                            icon={assignee.icons}
                            onPress={() => Navigation.navigate(ROUTES.NEW_TASK_ASSIGNEE)}
                            shouldShowRightIcon
                        />

What changes do you think we should make in order to solve the problem?

We can add a simple condition here that if we have already chosen assignee then don't show this assignee option. props.task stores the information about the task i.e title, desc, asignee. So we can use this object to check whether we have chosen any assignee to not

      !props.task.assignee &&   <MenuItem
                            label={assignee.displayName ? props.translate('task.assignee') : ''}
                            title={assignee.displayName || ''}
                            description={assignee.displayName ? LocalePhoneNumber.formatPhoneNumber(assignee.subtitle) : props.translate('task.assignee')}
                            icon={assignee.icons}
                            onPress={() => Navigation.navigate(ROUTES.NEW_TASK_ASSIGNEE)}
                            shouldShowRightIcon
                        />

What alternative solutions did you explore? (Optional)

Supporting videos

Before changes:

Screencast.from.23-08-23.01.17.32.AM.IST.mp4

After changes:

Screencast.from.23-08-23.01.16.24.AM.IST.mp4

rushatgabhane · 2023-08-23T04:55:30Z

@ all Please help me understand this issue.

Problem: Assignee isn't shown on confirm task page.
Root cause: The chat report exists, but the assignee doesn't exist in personalDetails.

Why is the assignee not being added to personalDetails when creating the chat report? Could you please link some code if possible, thanks!

CortneyOfstad · 2023-10-12T13:49:26Z

Not overdue 👍

CortneyOfstad · 2023-10-18T19:53:20Z

Heading OoO until Oct. 25, so reassigning BZ to keep an eye on this while I'm gone 👍

melvin-bot · 2023-10-18T19:53:45Z

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

conorpendergrast · 2023-10-25T10:48:57Z

@CortneyOfstad Welcome back! Assigning back to you; no change

CortneyOfstad · 2023-10-25T17:03:06Z

Perfect — thanks @conorpendergrast!

CortneyOfstad · 2023-11-06T15:36:13Z

@mountiny Any updates — TIA!

mountiny · 2023-11-07T15:18:07Z

No not really this is very low priority cc @thienlnam would you actually be interested in taking this one over as you got more context in the Tasks area so the fix might be quicker for you

thienlnam · 2023-11-08T04:48:43Z

Didn't read the entire thread but do you have a summary of the problem? Something with the personal details not showing up for a new user?

mountiny · 2023-11-08T16:08:23Z

It seems to be basically unable ot select the assignee in the new task flow when you just created a new chat with someone. I am double checking if we are even fixing these now

thienlnam · 2023-11-09T09:50:18Z

Ah yeah, I've seen this problem before - I believe it lies in that when you create optimistic personal details for someone you don't actually store the email as part of it until they respond to you

So when you select this user in the new task flow, it generates a new optimistic personal details for this person since it doesn't link to the existing contact but then when the task is created it pulls the existing user.

Anyways, it's not that simple to fix and I'd say not worth our time right now so we should just close this - thoughts?

aimane-chnaif · 2023-11-09T10:00:24Z

yes, correct.
Here's clear repro step: #25680 (comment)
So after logout and login, optimistic data is cleared and real data has only accountID and displayName, no login.

mountiny · 2023-11-09T11:22:52Z

I have discussed this with Jason and I am going to create a project to collect these and close it, we are not going to focus on the task fixes right now

mountiny · 2023-11-09T11:24:44Z

Added it to the project and we will come back to this once we are ready to refocus on this feature

DylanDylann · 2023-11-09T12:09:14Z

@mountiny @CortneyOfstad Are we eligible for compensation for our effort? Contributors are already assigned and started on the PR. It's just due to the decision changes and the solution becomes outdated.

Some other similar cases where compensation is made 100% thought PR is closed
#27108 (comment)
#26470 (comment)

mountiny · 2023-11-09T16:14:47Z

I am sorry but in this case given the circumstances I would err on a side of no payout but rather just first dibs for you once we get back to this. We are going to fix this eventually but closing only to keep plate clener, otherwise we could put this on hold. Its added to a project in Todo category. This would require backend changes and external only work was not sufficient so I think full compensation at this point would not be appropriate either

kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 22, 2023

melvin-bot bot assigned CortneyOfstad Aug 22, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 22, 2023

OSBotify mentioned this issue Aug 22, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

melvin-bot bot assigned mountiny Aug 22, 2023

mountiny added External Added to denote the issue can be worked on by a contributor Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 22, 2023

melvin-bot bot changed the title ~~Assignee does not show on Confirm task page~~ [$1000] Assignee does not show on Confirm task page Aug 22, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 22, 2023

melvin-bot bot assigned rushatgabhane Aug 22, 2023

mountiny changed the title ~~[$1000] Assignee does not show on Confirm task page~~ [$500] Assignee does not show on Confirm task page Aug 22, 2023

melvin-bot bot removed the Overdue label Oct 12, 2023

CortneyOfstad removed their assignment Oct 18, 2023

CortneyOfstad added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 18, 2023

melvin-bot bot assigned conorpendergrast Oct 18, 2023

melvin-bot bot added the Daily KSv2 label Oct 18, 2023

This comment was marked as duplicate.

Sign in to view

melvin-bot bot removed the Weekly KSv2 label Oct 18, 2023

CortneyOfstad self-assigned this Oct 18, 2023

mountiny added Weekly KSv2 and removed Daily KSv2 labels Oct 18, 2023

conorpendergrast removed their assignment Oct 25, 2023

melvin-bot bot added the Overdue label Nov 3, 2023

melvin-bot bot removed the Overdue label Nov 6, 2023

mountiny closed this as completed Nov 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD E/E #311912] [$500] Assignee does not show on Confirm task page #25680

[HOLD E/E #311912] [$500] Assignee does not show on Confirm task page #25680

kavimuru commented Aug 22, 2023 •

edited by conorpendergrast

Loading

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

OSBotify commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

aimane-chnaif commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

b4s36t4 commented Aug 22, 2023

DylanDylann commented Aug 22, 2023

parteekcoder commented Aug 22, 2023 •

edited

Loading

rushatgabhane commented Aug 23, 2023 •

edited

Loading

CortneyOfstad commented Oct 12, 2023

CortneyOfstad commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

This comment was marked as duplicate.

conorpendergrast commented Oct 25, 2023

CortneyOfstad commented Oct 25, 2023

CortneyOfstad commented Nov 6, 2023

mountiny commented Nov 7, 2023

thienlnam commented Nov 8, 2023

mountiny commented Nov 8, 2023

thienlnam commented Nov 9, 2023

aimane-chnaif commented Nov 9, 2023

mountiny commented Nov 9, 2023

mountiny commented Nov 9, 2023

DylanDylann commented Nov 9, 2023

mountiny commented Nov 9, 2023

[HOLD E/E #311912] [$500] Assignee does not show on Confirm task page #25680

[HOLD E/E #311912] [$500] Assignee does not show on Confirm task page #25680

Comments

kavimuru commented Aug 22, 2023 • edited by conorpendergrast Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

aimane-chnaif commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

melvin-bot bot commented Aug 22, 2023

b4s36t4 commented Aug 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

DylanDylann commented Aug 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

parteekcoder commented Aug 22, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Supporting videos

rushatgabhane commented Aug 23, 2023 • edited Loading

CortneyOfstad commented Oct 12, 2023

CortneyOfstad commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

This comment was marked as duplicate.

conorpendergrast commented Oct 25, 2023

CortneyOfstad commented Oct 25, 2023

CortneyOfstad commented Nov 6, 2023

mountiny commented Nov 7, 2023

thienlnam commented Nov 8, 2023

mountiny commented Nov 8, 2023

thienlnam commented Nov 9, 2023

aimane-chnaif commented Nov 9, 2023

mountiny commented Nov 9, 2023

mountiny commented Nov 9, 2023

DylanDylann commented Nov 9, 2023

mountiny commented Nov 9, 2023

kavimuru commented Aug 22, 2023 •

edited by conorpendergrast

Loading

parteekcoder commented Aug 22, 2023 •

edited

Loading

rushatgabhane commented Aug 23, 2023 •

edited

Loading