[$1000] IOU - IOU is displayed as Merchant in IOU details page when IOU is created without a Merchant

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify,com
2. Create money request without selecting a merchant
3. Open the money request report
4. Click on the IOU preview

Expected Result:

Merchant is not stated because money request is created without selecting a merchant

Actual Result:

IOU (or sometimes, Request) is shown for Merchant when money request is created without selecting a merchant

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome
• MacOS / Desktop

**Version Number:**1.3.56-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173403_20230822_131014.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019d6df5b1911e3c11
• Upwork Job ID: 1694136380885807104
• Last Price Increase: 2023-08-22

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[shubham1206agra]

@deetergp Looks like its coming from here

App/src/libs/TransactionUtils.js

Line 46 in 999ed93

merchant = CONST.REPORT.TYPE.IOU,

[shubham1206agra]

Is it necessary to have merchant or we can leave it blank?

[shubham1206agra]

Now its showing Request as merchant
Looks like its getting overridden from BE

[shubham1206agra]

Confirmed it
IOU is coming due to optimistic transaction data
And now for blank merchant BE will pass Request as merchant

[shubham1206agra]

Proposal

Please re-state the problem that we are trying to solve in this issue

IOU - IOU is displayed as Merchant in IOU details page when IOU is created without a Merchant

What is the root cause of that problem?

This is due to during requestMoney call we are using buildOptimisticTransaction to create optimistic report data
And we use CONST.REPORT.TYPE.IOU as the default value for merchant in the places

App/src/libs/TransactionUtils.js

Line 46 in 999ed93

merchant = CONST.REPORT.TYPE.IOU,

and

App/src/libs/TransactionUtils.js

Line 69 in 999ed93

merchant: merchant || CONST.REPORT.TYPE.IOU,

And for merchant becoming Request. This is coming from BE only.

What changes do you think we should make in order to solve the problem?

Replace CONST.REPORT.TYPE.IOU with empty strings in buildOptimisticTransaction.
For Request, this needs to be checked from the backend.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019d6df5b1911e3c11

[melvin-bot]

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[deetergp]

I don't think this issue is big enough to consider it a blocker—it is pretty minor.

[shubham1206agra]

@rushatgabhane Can you review my proposal?

[rushatgabhane]

@mountiny is this an issue? If yes, is it being internally tracked?

I think the deafult merchant should be Request, and that the backend is correct.

[rushatgabhane]

@mountiny should we fix this in your follow-up PRs because this is really minor and it happened because API wasn't ready when we merged merchant PR.

[tewodrosGirmaA]

Hey guys! I reported this bug in Slack before this issue was created. Could you please change the reporter's name? Thanks! Here's the link to the bug report: Bug Report Slack Link (https://expensify.slack.com/archives/C049HHMV9SM/p1692687129320969)

[luacmartins]

This is not an issue, all requests should have a default merchant name. We're updating it to the correct merchant name in this PR

[luacmartins]

Gonna close this one.