delete nested tag inside pre tag #24549

akamefi202 · 2023-08-14T18:45:34Z

Added a new rule to htmlToMarkdownRules of expensify-common repo to remove unnecessary nested tags inside <pre> tag.
And updated expensify-common commit hash in package.json.

Details

expensify-common PR
Updated expensify-common dependency to latest commit hash.

Fixed Issues

$ #23659
PROPOSAL: #23659 (comment)

Tests

Web/Desktop

Open any report
Paste below markdown and send it.(It has a heading, then a code snippet and a quote.)

###test heading
```
Code snippet
```
[link](https://www.example.com/)

Now use the copy to clipboard option, and copy the sent message.
Paste the message in the composer and send it again.(Notice that there are no difference in both messages.)
Now select the sent message text by cursor and press CMD + C.
Paste the text in the composer and send the message again.
Notice that the markdown message has no difference too.

mWeb Chrome/Safari

Open the App and go to any chat.
Copy the test text snippet from the issue [HOLD for payment 2023-08-30] [$1000] Web - Markdown pasted from selection-copy is different from clipboard-copy #23659 using the cursor selection.

###test heading
```
Code snippet
```
[link](https://www.example.com/)

Paste it to the composer's input.
Verify there's no new line under the Code snippet text.

iOS/Android

Open the previous chat which is used to test Web/Desktop/mWeb.
Copy the text from the app using context menu.
Paste the text to the composer's input.
Verify pasted text is the same as copied text.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

We can't reproduce this issue in mobile platforms because it includes copying by keyboard shortcut.

Web

258146529-abf29a55-f9a4-4627-b1e0-3e0696ff8239.mp4

Mobile Web - Chrome

device-2023-08-17-154724.mp4

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-17.at.15.00.36.mp4

Desktop

Screen.Recording.2023-08-17.at.5.32.23.AM.mp4

iOS

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-17.at.14.41.03.mp4

Android

az_recorder_20230817_162739.mp4

melvin-bot · 2023-08-14T18:45:39Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-08-14T18:45:47Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

akamefi202 · 2023-08-14T18:46:25Z

I have read the CLA Document and I hereby sign the CLA

mollfpr · 2023-08-16T04:46:14Z

@akamefi202 Could you complete the records on all platforms?

mollfpr · 2023-08-16T04:52:15Z

Also, the test should copy-paste the text, not the markdown snippet, right?

akamefi202 · 2023-08-16T05:43:48Z

@mollfpr

Could you complete the records on all platforms?

We can't reproduce this issue in mobile platforms because it includes keyboard shortcut for copying.

Also, the test should copy-paste the text, not the markdown snippet, right?

At first, we need to copy-paste markdown text to send a message. After that, we copy-paste that message by clipboard button & keyboard shortcut for checking difference.

mollfpr · 2023-08-16T05:47:05Z

Okay, let's clarify the test for native is copy from the context menu. While the others is from the selection copy.

akamefi202 · 2023-08-16T06:50:09Z

@mollfpr Okay. I updated the first comment.

mollfpr · 2023-08-16T17:13:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

New.Recording.-.8_17_2023.11_33_17.PM.webm

Mobile Web - Chrome

Screen_Recording_20230817_234037_Chrome.mp4

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-17.at.23.35.24.mp4

Desktop

Screen.Recording.2023-08-17.at.23.36.10.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-08-17.at.23.34.33.mp4

Android

Screen_Recording_20230817_233913_New.Expensify.Dev.mp4

mollfpr · 2023-08-16T17:19:48Z

I need to complete the records.

@akamefi202 The test is still doable for the mWeb with the selection copy from the GH issue. So, please complete the records test on all platforms. For the native platforms, please copy the text from the context menu and verify it's pasting correctly.

akamefi202 · 2023-08-17T08:33:01Z

@mollfpr I uploaded recording videos for all platforms.
#24549 (comment)

mollfpr

LGTM and tests well 👍

@akamefi202 Could you update the test case to clarify the test on mweb and the native platforms?

Web/Desktop

Open the App and go to any chat
Copy the test text snippet from the issue [HOLD for payment 2023-08-30] [$1000] Web - Markdown pasted from selection-copy is different from clipboard-copy #23659 using the cursor selection

test heading

Code snippet

link

Paste the text to the composer's input
Verify there's no new line under the Code snippet text
Send the pasted text from the previous step
Copy the text sent with the cursor selection
Paste the text to the composer
Verify there's no new line under the Code snippet text

mWeb Chrome/Safari

Open the App and go to any chat
Copy the test text snippet from the issue [HOLD for payment 2023-08-30] [$1000] Web - Markdown pasted from selection-copy is different from clipboard-copy #23659 using the cursor selection

test heading

Code snippet

link

Paste the text to the composer's input
Verify there's no new line under the Code snippet text

iOS/Android

Open the previous chat use to test Web/Desktop/mWeb
Copy the text from the app context menu
Paste the text to the composer's input
Verify pasted text is the same as copied text

OSBotify · 2023-08-17T18:51:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

akamefi202 · 2023-08-17T19:55:23Z

Updated #24549 (comment)

OSBotify · 2023-08-21T22:25:37Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:08:38Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

delete nested tag inside pre tag

ac92717

akamefi202 requested a review from a team as a code owner August 14, 2023 18:45

melvin-bot bot requested review from mollfpr and removed request for a team August 14, 2023 18:45

akamefi202 mentioned this pull request Aug 14, 2023

Delete nested tag inside codeFence Expensify/expensify-common#564

Merged

mollfpr approved these changes Aug 17, 2023

View reviewed changes

melvin-bot bot requested a review from puneetlath August 17, 2023 16:53

puneetlath approved these changes Aug 17, 2023

View reviewed changes

puneetlath merged commit ae96194 into Expensify:main Aug 17, 2023

akamefi202 deleted the selection-copy-markdown branch August 17, 2023 19:38

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

delete nested tag inside pre tag #24549

delete nested tag inside pre tag #24549

akamefi202 commented Aug 14, 2023 •

edited

Loading

melvin-bot bot commented Aug 14, 2023

github-actions bot commented Aug 14, 2023 •

edited

Loading

akamefi202 commented Aug 14, 2023

mollfpr commented Aug 16, 2023

mollfpr commented Aug 16, 2023

akamefi202 commented Aug 16, 2023

mollfpr commented Aug 16, 2023

akamefi202 commented Aug 16, 2023 •

edited

Loading

mollfpr commented Aug 16, 2023 •

edited

Loading

mollfpr commented Aug 16, 2023

akamefi202 commented Aug 17, 2023

mollfpr left a comment

OSBotify commented Aug 17, 2023

akamefi202 commented Aug 17, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

delete nested tag inside pre tag #24549

delete nested tag inside pre tag #24549

Conversation

akamefi202 commented Aug 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Web/Desktop

mWeb Chrome/Safari

iOS/Android

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 14, 2023

github-actions bot commented Aug 14, 2023 • edited Loading

akamefi202 commented Aug 14, 2023

mollfpr commented Aug 16, 2023

mollfpr commented Aug 16, 2023

akamefi202 commented Aug 16, 2023

mollfpr commented Aug 16, 2023

akamefi202 commented Aug 16, 2023 • edited Loading

mollfpr commented Aug 16, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr commented Aug 16, 2023

akamefi202 commented Aug 17, 2023

mollfpr left a comment

Choose a reason for hiding this comment

test heading

test heading

OSBotify commented Aug 17, 2023

akamefi202 commented Aug 17, 2023

OSBotify commented Aug 21, 2023

OSBotify commented Aug 24, 2023

akamefi202 commented Aug 14, 2023 •

edited

Loading

github-actions bot commented Aug 14, 2023 •

edited

Loading

akamefi202 commented Aug 16, 2023 •

edited

Loading

mollfpr commented Aug 16, 2023 •

edited

Loading