[HOLD for payment 2023-08-01] [$1000] mWeb - Next button is hidden behind the keyboard

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click + icon and select assign task option
2. Click on title or description to open keyboard

Expected Result:

Next button should float to the top above the keyboard and not be hidden behind the keyboard

Actual Result:

Next button is hidden and user have to close keyboard to click on Next button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1689051007.MP4

RPReplay_Final1689096868.MP4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689051900984439

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0156fee52bf18361b2
• Upwork Job ID: 1679934442140999680
• Last Price Increase: 2023-07-14

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

For mWeb task details page Next button isn't shown when keyboard opened

What is the root cause of that problem?

We are not passing the shouldEnableMaxHeight to the ScreenWrapper here which won't adjust the maxHeight on updated windowHeight.

App/src/pages/tasks/NewTaskDetailsPage.js

Lines 75 to 78 in 702d8e2

	<ScreenWrapper
	onEntryTransitionEnd={() => inputRef.current && inputRef.current.focus()}
	includeSafeAreaPaddingBottom={false}
	>

What changes do you think we should make in order to solve the problem?

Pass shouldEnableMaxHeight prop to the ScreenWrapper for NewTaskPage which will update the maxHeight based on the windowHeight which makes sure to show the button if the space is available for it.

App/src/pages/tasks/NewTaskDetailsPage.js

Lines 75 to 78 in 702d8e2

	<ScreenWrapper
	onEntryTransitionEnd={() => inputRef.current && inputRef.current.focus()}
	includeSafeAreaPaddingBottom={false}
	>

We can pass the shouldEnableMaxHeight prop to other pages as well.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0156fee52bf18361b2

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[mallenexpensify]

Was able to reproduce, updated OP for the expected result to

Next button should float to the top above the keyboard and not be hidden behind the keyboard

Example here

[s77rt]

@Pujan92 Thanks for the proposal. Your RCA is correct and the solution looks good to me.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

@Beamanator can you review @Pujan92 's proposal above plz?

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[melvin-bot]

📣 @Pujan92 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[Beamanator]

@s77rt - the proposal looks great, and I think we should also check if there's other places we need to be adding that prop but aren't 👍

[Pujan92]

@s77rt @Beamanator PR is ready for review!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.44-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: for mWeb(ios safari) float button up for the screen when keyboard opens for the form input #23185

If no regressions arise, payment will be issued on 2023-08-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment
• @s77rt requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Viewport jumping up #16443 and Tasks Detailed View #17940
• The offending PR has been commented on: Viewport jumping up #16443 (comment) and Tasks Detailed View #17940 (comment)
• A discussion in #expensify-bugs has been started: https://expensify.slack.com/archives/C049HHMV9SM/p1690322590131429
• Determine if we should create a regression test for this bug: No

[mallenexpensify]

Issue reporter: @gadhiyamanan paid $250 via Upwork
Contributor: @Pujan92 paid $1500 via Upwork, including the urgency bonus
Contributor+: @s77rt paid $1500 via Upwork, including the urgency bonus.