[HOLD for payment 2023-08-01] [$1000] Web - The created task message is grey when offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create new task and share in chat A
2. Go to chat A
3. Go offline

Expected Result:

The created task message isn't grey

Actual Result:

The created task message is grey

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-14.at.10.10.36.mov

Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689304357404199

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014a95fa4f470fd93f
• Upwork Job ID: 1680964258185183232
• Last Price Increase: 2023-07-17

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kbecciv]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The created task message is grey when offline

What is the root cause of that problem?

When creating a new task

App/src/libs/actions/Task.js

Lines 100 to 103 in 754b6ed

	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`,
	value: {[optimisticAddCommentReport.reportAction.reportActionID]: optimisticAddCommentReport.reportAction},
	},

We set pending action for report action in the parent report. But when we don’t remove pending action when success

What changes do you think we should make in order to solve the problem?

We should remove pending action when creating a new task successfully by adding this code to successData

App/src/libs/actions/Task.js

Line 111 in 754b6ed

const successData = [

{
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${parentReportID}`,
            value: {
                [optimisticAddCommentReport.reportAction.reportActionID]: {
                    pendingAction: null,
                },
            },
        },

We also should do the same thing here

App/src/libs/actions/Task.js

Line 142 in 754b6ed

if (optimisticAssigneeAddComment) {

successData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${assigneeChatReportID}`,
            value: {[optimisticAssigneeAddComment.reportAction.reportActionID]: {pendingAction: null}},
        });

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014a95fa4f470fd93f

[melvin-bot]

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[lschurr]

Not overdue. Just added External.

[misgana96]

Contributor details
Your Expensify account email: misganayoseph@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~018a20230bafe0113c

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[misgana96]

I will use CSS tricks to solve the issue

[melvin-bot]

📣 @siliconravi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[siliconravi]

Contributor details
Your Expensify account email: ashish@siliconithub.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01ce21269a39056e85

[siliconravi]

• Issue: Currently, when creating tasks in offline mode, the message appears as grey.
• Reason: When the application goes offline, an opacity of 0.5 is applied, resulting in the grey color.
• Solution:
  • Remove the opacity entirely.
  • Keep the opacity at a value of 1.

Screencast.from.18-07-23.03_29_46.PM.IST.webm

[s77rt]

@dukenv0307 Thanks for the proposal. Your RCA is correct and the solution makes sense.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[s77rt]

@dukenv0307 Please leave a comment here

[s77rt]

@misgana96 Please checkout the contributing guide.

[dukenv0307]

@s77rt Thank you.

[s77rt]

@siliconravi Thanks for the proposal. The RCA does not seem correct. Also for future proposal please follow the proposal template. Contributing guide: https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[dukenv0307]

@s77rt PR is ready to review #23150

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.44-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: the created task message is grey when offline #23150

If no regressions arise, payment will be issued on 2023-08-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment
• @dukenv0307 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Create Task FrontEnd Changes #17992
• The offending PR has been commented on: Create Task FrontEnd Changes #17992 (comment)
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: We have this test https://expensify.testrail.io/index.php?/cases/view/2649462 that we can modify but I don't think this one needs a test

[lschurr]

Thanks for getting the checklist done so quickly @s77rt!

[lschurr]

Payout summary:

• Bug reporter + Contributor: @dukenv0307 $1750
• C+: @s77rt $1500

Both will be paid in Upwork tomorrow.

[lschurr]

All paid! Closing this one out.