Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Message received after attachment isn't displayed in LHN until reply is sent and deleted #22937

Closed
3 of 6 tasks
lanitochka17 opened this issue Jul 15, 2023 · 30 comments
Closed
3 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 15, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com or open Expensify App on two devices as user A and user B
  2. User A open chat with user B
  3. User A send attachment (image or PDF) to user B
  4. User B send text message to user A
  5. === (see expected / actual result) ===
  6. User A sends a reply to this message and then deletes this reply
  7. Message from step 4 is displayed in LHN

Expected Result:

  1. User A receives a message and this message is displayed in LHN

Actual Result:

  1. User A receives a message but this message is NOT displayed in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.41.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6128733_No-last-message-in-LHN.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 15, 2023

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 15, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@eh2077
Copy link
Contributor

eh2077 commented Jul 15, 2023

This looks like a regression of #21780

@stephanieelliott
Copy link
Contributor

Thanks @eh2077, made a note on the corresponding issue as well.

@melvin-bot melvin-bot bot removed the Overdue label Jul 18, 2023
@stephanieelliott
Copy link
Contributor

Hey @eh2077 Is there a PR for this yet?

@eh2077
Copy link
Contributor

eh2077 commented Jul 19, 2023

@stephanieelliott I think the contributor or the C+ will submit a PR to fix this. They'll update in the linked original issue.

@melvin-bot
Copy link

melvin-bot bot commented Jul 24, 2023

@stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

@stephanieelliott
Copy link
Contributor

Oops, thanks @eh2077 -- meant to tag the 🙃 the original C+.

@melvin-bot melvin-bot bot removed the Overdue label Jul 24, 2023
@stephanieelliott
Copy link
Contributor

Working on a fix in #19449 via #21780

@melvin-bot
Copy link

melvin-bot bot commented Jul 28, 2023

@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

@stephanieelliott
Copy link
Contributor

Some back end changes needed on this PR, see #19449 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Jul 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 29, 2023

@stephanieelliott this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Jul 31, 2023
@stephanieelliott
Copy link
Contributor

PR still under review, internal changes requested.

@melvin-bot melvin-bot bot removed the Overdue label Aug 1, 2023
@stephanieelliott
Copy link
Contributor

PR still under review, internal changes requested.

@stephanieelliott
Copy link
Contributor

There is no payment due for this since it was reported by Applause, so I am going to close this -- see the original issue for updates: #19449 (comment)

@thienlnam
Copy link
Contributor

This bug is still happening - going to reopen this so it can be addressed independently

#19449

@thienlnam thienlnam reopened this Aug 24, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 24, 2023
@stephanieelliott
Copy link
Contributor

Hey @thienlnam this was reported as a regression -- are you saying we should treat this as an independent bug and invite contributors to post proposals? Or are you suggesting that we have @tienifr (who created the original PR) continue in this issue to work on solving the regression?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 25, 2023
@thienlnam
Copy link
Contributor

I'm suggesting we have the original reviewer and author to continue in this issue @tienifr / @eVoloshchak

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2023

@stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

@stephanieelliott
Copy link
Contributor

Hey @eVoloshchak @tienifr bump on this, has there been a PR started?

@melvin-bot melvin-bot bot removed the Overdue label Aug 31, 2023
@tienifr
Copy link
Contributor

tienifr commented Aug 31, 2023

@stephanieelliott I'm working on it, will raise the PR soon

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

@eVoloshchak, @stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@stephanieelliott
Copy link
Contributor

Hey @tienifr, any update on the PR?

@melvin-bot melvin-bot bot removed the Overdue label Sep 6, 2023
@tienifr
Copy link
Contributor

tienifr commented Sep 7, 2023

As mentioned previously, backend updates are needed but it's not a good choice. I'm working on other approaches, thus it took longer than expected. I'm really close. Expect to raise PR ASAP today.

@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

@eVoloshchak, @stephanieelliott, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 11, 2023
@stephanieelliott
Copy link
Contributor

Just checking in @tienifr, do we have a PR for this yet?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2023

@eVoloshchak, @stephanieelliott, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

@tienifr
Copy link
Contributor

tienifr commented Sep 15, 2023

@stephanieelliott I can no longer reproduce the issue on the latest main.

lhn-compressed.mov

@melvin-bot melvin-bot bot removed the Overdue label Sep 15, 2023
@stephanieelliott
Copy link
Contributor

Cool, thanks @tienifr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

6 participants