Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank account - Images are absent on Onfido setup #22938

Closed
2 of 6 tasks
lanitochka17 opened this issue Jul 15, 2023 · 8 comments
Closed
2 of 6 tasks

Bank account - Images are absent on Onfido setup #22938

lanitochka17 opened this issue Jul 15, 2023 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 15, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #22628

Action Performed:

  1. Launch New Expensify app.
  2. Go to Settings > Workspace > any workspace > Bank account > Step 3: Personal information.

Expected Result:

Images are present on Onfido setup

Actual Result:

Images are absent on Onfido setup

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.41.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6128857_bandicam_2023-07-15_03-07-24-392.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 15, 2023

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 15, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@allroundexperts
Copy link
Contributor

This needs to be fixed from the backend. Here's the error if that helps:

Refused to load the image 'data:image/svg+xml,%3Csvg width%3D%228%22 height%3D%2212%22 xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%3E  %3Cpath d%3D%22M.332 1.811 5.262 6l-4.93 4.189a1.014 1.014 0 0 0 0 1.5 1.192 1.192 0 0 0 1.604 0l5.736-4.873A1.01 1.01 0 0 0 7.997 6a1.01 1.01 0 0 0-.325-.816L1.936.31a1.192 1.192 0 0 0-1.604 0 1.014 1.014 0 0 0 0 1.5z%22 fill%3D%22%232C3E4F%22%2F%3E%3C%2Fsvg%3E' because it violates the following Content Security Policy directive: "img-src * blob:". Note that '*' matches only URLs with network schemes ('http', 'https', 'ws', 'wss'), or URLs whose scheme matches `self`'s scheme. The scheme 'data:' must be added explicitly.

@bfitzexpensify
Copy link
Contributor

bfitzexpensify commented Jul 18, 2023

Thanks @allroundexperts. Adding engineering tag for internal review. -#22938 (comment) for context

@melvin-bot
Copy link

melvin-bot bot commented Jul 18, 2023

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@bfitzexpensify
Copy link
Contributor

Not overdue, Melv

@flodnv
Copy link
Contributor

flodnv commented Jul 19, 2023

@nkuoch I think you recently updated / worked on Onfido? If not, do you know who did?

@nkuoch nkuoch self-assigned this Jul 19, 2023
@nkuoch
Copy link
Contributor

nkuoch commented Jul 19, 2023

I believe will be fixed by https://github.com/Expensify/Cloudflare-Workers/pull/66 cc @francoisl

@nkuoch nkuoch closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants