[$1000] Web - Group Chat - Email address not displayed when hover over the user who has long Display name #23082

lanitochka17 · 2023-07-18T12:55:35Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Navigate to staging.new.expensify.com
Create a group with the user with very long Display name & other users
Go to the group chat
Go to details
Hover over the user who has long Display name

Expected Result:

When hover over the user who has long name also email address should be showing

Actual Result:

Email address not displayed when hover over the user who has very long Display name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.42.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6132093_Recording__407.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013107871e59432037
Upwork Job ID: 1681956359393382401
Last Price Increase: 2023-07-20

melvin-bot · 2023-07-18T12:55:40Z

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-18T12:55:42Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

dukenv0307 · 2023-07-18T13:30:24Z

I think it's a BE bug that we lack of login field when we return personal detail of the user in the group. The reason isn't long name display, it happens with all users that doesn't have login field in personalDetail.

Screencast.from.18-07-2023.20.28.01.webm

melvin-bot · 2023-07-20T09:17:02Z

Job added to Upwork: https://www.upwork.com/jobs/~013107871e59432037

melvin-bot · 2023-07-20T09:17:06Z

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-07-20T09:17:12Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

dukenv0307 · 2023-07-20T10:58:52Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Group Chat - Email address not displayed when hover over the user who doesn't chat with the current user before.

What is the root cause of that problem?

It's expected not to send login from backend as this is just new chat and user hasn't sent any message yet. That makes email is hidden when hovering the avatar of this user

App/src/components/UserDetailsTooltip/index.web.js

Line 38 in e87f2eb

    
           const subtitle = (userLogin || '').trim() && !_.isEqual(LocalePhoneNumber.formatPhoneNumber(userLogin || ''), userDisplayName) ? Str.removeSMSDomain(userLogin) : '';

What changes do you think we should make in order to solve the problem?

We can set subtitle as translate('common.hidden'') if login field isn't already in personal detail of this user. That is similar subtitle when we click on avatar to see participants of the group chat

const subtitle = (userLogin || '').trim() && !_.isEqual(LocalePhoneNumber.formatPhoneNumber(userLogin || ''), userDisplayName) ? Str.removeSMSDomain(userLogin) : 'translate('common.hidden'')';

App/src/components/UserDetailsTooltip/index.web.js

Line 38 in e87f2eb

    
           const subtitle = (userLogin || '').trim() && !_.isEqual(LocalePhoneNumber.formatPhoneNumber(userLogin || ''), userDisplayName) ? Str.removeSMSDomain(userLogin) : '';

And we also should update other places that set subtile as Hidden to translation of this text

What alternative solutions did you explore? (Optional)

NA

Result

melvin-bot · 2023-07-20T12:51:24Z

📣 @Free-devloper! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

melvin-bot · 2023-07-20T12:53:55Z

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

melvin-bot · 2023-07-20T12:54:28Z

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

melvin-bot · 2023-07-20T12:55:40Z

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

dylanexpensify · 2023-07-20T12:56:51Z

@ArekChr mind reviewing this proposal today? 🙇‍♂️

Talha345 · 2023-07-20T13:02:52Z

This is a BE issue since the login is not passed from the backend for a user whom the current user has not chatted before.

Try these steps:

1.Create a new user with a very long name.
2.Go to some other user and create a group with the long name user and some other users using their emails.
3.We will get the problem as mentioned in this issue.
4.Go to new chat and create a new chat with the long name user using his email.
5.Chat opens and still the same error.

If the current user is creating a group or a simple chat with a user using his email, the email should be shown because the current user already knows his email.

Screen.Recording.2023-07-20.at.15.02.02.mov

ArekChr · 2023-07-20T13:16:40Z

@ArekChr mind reviewing this proposal today? 🙇‍♂️

Hey @dylanexpensify, I'm not able today, tomorrow I'm OOO, I will be back on Monday

dylanexpensify · 2023-07-24T08:25:22Z

@ArekChr sounds good! Looking forward to the recap today!

ArekChr · 2023-07-24T09:34:39Z

@dylanexpensify When trying to reproduce this error, I see no issue on staging. All users with long display names have displayed email as well.

Nagranie.z.ekranu.2023-07-24.o.11.33.13.mov

dukenv0307 · 2023-07-24T09:55:52Z

@ArekChr I'm still able to reproduce in staging. Pre-condition: the user that you hovered hasn't sent any message before and isn't a member of any workspace that you are a member.

Screencast.from.24-07-2023.16.53.36.webm

ArekChr · 2023-07-24T09:57:10Z

@ArekChr I'm still able to reproduce in staging. Pre-condition: the user that you hovered hasn't sent any message before and isn't a member of any workspace that you are a member.

Screencast.from.24-07-2023.16.53.36.webm

@dukenv0307 Could you test the profiles with long display names?

dukenv0307 · 2023-07-24T10:02:04Z

@ArekChr Yes I'm still able to reproduce this. And the cause of email address is not displayed isn't long display name.

Screencast.from.24-07-2023.17.00.33.webm

ArekChr · 2023-07-24T10:14:51Z

I have created some fresh accounts with no messages sent, still can't reproduce that error.

Are there any specific reproduction steps different from the issue description?

Nagranie.z.ekranu.2023-07-24.o.12.13.31.mov

dukenv0307 · 2023-07-24T10:25:54Z

@ArekChr Can you try without callstack email account.

ArekChr · 2023-07-24T10:51:27Z

I see now for the same organization, the address email is always displayed. Tested with another email, and the bug is reproducible.

ArekChr · 2023-07-24T10:53:41Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Group Chat - Email address not displayed when hover over the user who doesn't chat with the current user before.

What is the root cause of that problem?

It's expected not to send login from backend as this is just new chat and user hasn't sent any message yet. That makes email is hidden when hovering the avatar of this user

App/src/components/UserDetailsTooltip/index.web.js

Line 38 in e87f2eb

const subtitle = (userLogin || '').trim() && !_.isEqual(LocalePhoneNumber.formatPhoneNumber(userLogin || ''), userDisplayName) ? Str.removeSMSDomain(userLogin) : '';

What changes do you think we should make in order to solve the problem?

We can set subtitle as Hidden if login field isn't already in personal detail of this user. That is similar subtitle when we click on avatar to see participants of the group chat
const subtitle = (userLogin || '').trim() && !_.isEqual(LocalePhoneNumber.formatPhoneNumber(userLogin || ''), userDisplayName) ? Str.removeSMSDomain(userLogin) : 'Hidden';
App/src/components/UserDetailsTooltip/index.web.js

Line 38 in e87f2eb

const subtitle = (userLogin || '').trim() && !_.isEqual(LocalePhoneNumber.formatPhoneNumber(userLogin || ''), userDisplayName) ? Str.removeSMSDomain(userLogin) : '';

What alternative solutions did you explore? (Optional)

NA

Result

@dukenv0307 Different label is needed based on localization

dukenv0307 · 2023-07-24T11:11:39Z

Different label is needed based on localization

@ArekChr Sorry, I don't understand

ArekChr · 2023-07-24T11:21:10Z

Different label is needed based on localization

@ArekChr Sorry, I don't understand

I mean this sentence:

We can set subtitle as Hidden if login field isn't already in personal detail of this user. That is similar subtitle when we click > on avatar to see participants of the group chat

The label can not be set to hidden because when the app language is Espanol needs to be different. Localize is needed, please update proposal

dukenv0307 · 2023-07-24T12:15:42Z

The label can not be set to hidden because when the app language is Espanol needs to be different. Localize is needed, please update proposal

@ArekChr When we change the language and open participant page, subtitle is still Hidden. So I think we shouldn't translate this label to consistent with other page.

ArekChr · 2023-07-24T12:19:51Z

@ArekChr When we change the language and open participant page, subtitle is still Hidden. So I think we shouldn't translate this label to consistent with other page.

@dukenv0307 I think this is another bug then. @dylanexpensify could you confirm?

dukenv0307 · 2023-07-26T12:01:40Z

@ArekChr When we change the language and open participant page, subtitle is still Hidden. So I think we shouldn't translate this label to consistent with other page.

@dylanexpensify Could you confirm it?

dylanexpensify · 2023-07-26T12:32:01Z

reviewing shortly!

dylanexpensify · 2023-07-26T13:34:55Z

agree - that is another bug!

dukenv0307 · 2023-07-26T13:40:30Z

@ArekChr Updated proposal

ArekChr · 2023-07-27T11:57:28Z

@dukenv0307 Looks good to me 👌
🎀 👀 🎀 C+ reviewed

melvin-bot · 2023-07-27T11:57:34Z

Triggered auto assignment to @amyevans, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

amyevans · 2023-07-27T14:54:21Z

I confirmed with @puneetlath but the lack of subtitle text in this case is by design, so going to close this out.

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 18, 2023

melvin-bot bot assigned dylanexpensify Jul 18, 2023

mvtglobally mentioned this issue Jul 18, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

dylanexpensify added the External Added to denote the issue can be worked on by a contributor label Jul 20, 2023

melvin-bot bot changed the title ~~Web - Group Chat - Email address not displayed when hover over the user who has long Display name~~ [$1000] Web - Group Chat - Email address not displayed when hover over the user who has long Display name Jul 20, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 20, 2023

melvin-bot bot assigned ArekChr Jul 20, 2023

melvin-bot bot added the Overdue label Jul 20, 2023

melvin-bot bot removed the Overdue label Jul 20, 2023

melvin-bot bot added the Overdue label Jul 24, 2023

melvin-bot bot removed the Overdue label Jul 24, 2023

melvin-bot bot assigned amyevans Jul 27, 2023

amyevans closed this as completed Jul 27, 2023

[$1000] Web - Group Chat - Email address not displayed when hover over the user who has long Display name #23082

[$1000] Web - Group Chat - Email address not displayed when hover over the user who has long Display name #23082

Comments

lanitochka17 commented Jul 18, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jul 18, 2023

melvin-bot bot commented Jul 18, 2023 • edited by dylanexpensify Loading

Bug0 Triage Checklist (Main S/O)

dukenv0307 commented Jul 18, 2023 • edited Loading

melvin-bot bot commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

dukenv0307 commented Jul 20, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

melvin-bot bot commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

melvin-bot bot commented Jul 20, 2023

dylanexpensify commented Jul 20, 2023

Talha345 commented Jul 20, 2023

ArekChr commented Jul 20, 2023

dylanexpensify commented Jul 24, 2023

ArekChr commented Jul 24, 2023

dukenv0307 commented Jul 24, 2023

ArekChr commented Jul 24, 2023

dukenv0307 commented Jul 24, 2023

ArekChr commented Jul 24, 2023

dukenv0307 commented Jul 24, 2023

ArekChr commented Jul 24, 2023 • edited Loading

ArekChr commented Jul 24, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

dukenv0307 commented Jul 24, 2023 • edited Loading

ArekChr commented Jul 24, 2023 • edited Loading

dukenv0307 commented Jul 24, 2023

ArekChr commented Jul 24, 2023

dukenv0307 commented Jul 26, 2023

dylanexpensify commented Jul 26, 2023

dylanexpensify commented Jul 26, 2023

dukenv0307 commented Jul 26, 2023

ArekChr commented Jul 27, 2023

melvin-bot bot commented Jul 27, 2023

amyevans commented Jul 27, 2023

lanitochka17 commented Jul 18, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 18, 2023 •

edited by dylanexpensify

Loading

dukenv0307 commented Jul 18, 2023 •

edited

Loading

dukenv0307 commented Jul 20, 2023 •

edited

Loading

ArekChr commented Jul 24, 2023 •

edited

Loading

dukenv0307 commented Jul 24, 2023 •

edited

Loading

ArekChr commented Jul 24, 2023 •

edited

Loading