[HOLD for payment 2023-08-07] [$1000] Web - Hover effect is lost when hovering on a task checkbox

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat
2. Assign task
3. Move the hover on the checkbox

Expected Result:

The item should remain hovered

Actual Result:

The hover effect will be lost

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-12
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-18.at.5.39.04.PM.mov

Recording.3749.mp4

Expensify/Expensify Issue URL:
Issue reported by: @getusha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689691271038109

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016d688951b4b39f55
• Upwork Job ID: 1682036256059990016
2023-07-20
• Automatic offers:
• | | 0
• getusha | Reporter | 25724516

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hover effect lost when mouse is moved over the task checkbox.

What is the root cause of that problem?

On react-native-web, its not possible to nest Pressables. This is a known issue that @roryabraham has also posted about here.

To overcome this, we wrap all of our ReportActionItems content inside Hoverable component as seen here. This component is specifically created to overcome the issue mentioned above. With tasks however, we're not wrapping the content inside Hoverable as can be clearly seen here.

What changes do you think we should make in order to solve the problem?

We need to wrap the content of PressableWithoutFeedback inside Hoverable component (other way around works as well) in the TaskView component and use the hover value from the Hoverable to derive the component styles instead of relying on PressableWithoutFeedback for hover variable.

We can also find and fix the other instances of the same behaviour elsewhere in our App.

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016d688951b4b39f55

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[luckyman0305]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On the task title, hover effect lost when mouse is on the checkbox

What is the root cause of that problem?

Checkbox has no hover effect normally.

What changes do you think we should make in order to solve the problem?

We can simply add mouse hover event listener on checkbox parent react component.

What alternative solutions did you explore? (Optional)

Result

hoverEfeectofCheckbox.mov

[alanleungcn]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hover effect is lost when hovering on the checkbox in task title.

What is the root cause of that problem?

The parent component of checkbox does not know its hover state.

What changes do you think we should make in order to solve the problem?

We should introduce the props onHoverIn and onHoverOut in the Checkbox component, applying to PressableWithFeedback here, which already handles the hover logic.

Therefore, we could introduce a state in the parent component TaskView to determine if the checkbox is being hovered, something on the lines of const [isCheckboxHovered, setIsCheckboxHovered] = useState(isCompleted);. Then, we could use the said state to determine the style of the title here.

I believe it is a more general way to fix any similar issues because we could have have information on the hover state of the checkbox.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

📣 @alanleungcn! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[rk111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hover effect is lost when hovering on a task checkbox

What is the root cause of that problem?

It is likely due to a CSS specificity issue or a conflicting CSS rule.

What changes do you think we should make in order to solve the problem?

Wrap the checkbox and its label (task title) in a container element: This will make it easier to target the label when the checkbox is being hovered over.
Apply the hover effect on the label when the checkbox is being hovered over: Use CSS to target the label element when the checkbox is in a hovered state and apply the desired styles to create the hover effect.

[ArekChr]

The proposal from @allroundexperts looks good to me
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Li357, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Li357]

LGTM @allroundexperts!

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Contributor role ($1000)

[melvin-bot]

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[allroundexperts]

PR created #23545

[ArekChr]

PR reviewed 🙌

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: wrap TaskView inside Hoverable #23545

If no regressions arise, payment will be issued on 2023-08-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ArekChr does not require payment (Contractor)
• @allroundexperts does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ArekChr / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@ArekChr / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ArekChr / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ArekChr / @allroundexperts] Determine if we should create a regression test for this bug.
• [@ArekChr / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Assigned July 24, merged July 26 - eligible for #urgency bonus.

Payments:

Reporter: @getusha - $250 paid out on Upwork ✅
Contributor: @allroundexperts - $1500 (Contributor work + #urgency bonus) to be paid via manual request
C+: @ArekChr - does not require payment (Contractor)

[bfitzexpensify]

Please complete the BZ checklist when you get a moment @ArekChr - thank you!

[ArekChr]

• The PR that introduced the bug has been identified. Link to the PR: No PR found.
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: no comment.
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• Determine if we should create a regression test for this bug: We can create a simple regression test.

1. Open any chat
2. Assign task
3. Move the hover on the checkbox

Do we agree 👍 or 👎

[bfitzexpensify]

Agreed @ArekChr — I just added a 4th point to instruct the behaviour we're looking for:

1. Open any chat
2. Assign task
3. Move the hover on the checkbox
4. Confirm the task is still highlighted

Opened https://github.com/Expensify/Expensify/issues/307528.

We're all done here, closing this one out - thanks everyone!

[JmillsExpensify]

Reviewed the details for @allroundexperts. Approved for payment based on the BZ summary above.