[HOLD for payment 2023-08-08] Bank account - Personal information is cleared after returning to it from 'Connect BA' page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Expensify App or go to staging.new.expensify.com
2. Open existing or create new workspace
3. Go to Connect Bank Account
4. Start 'Connect online with Plaid'
5. Select Chase Bank
6. Fill out forms on all pages including Personal Information (but don't click the confirmation button)
7. Click/tap 'Back' until you get to 'Connect BA' page
8. Go back to 'Personal Information' page by clicking/tapping 'Continue' button

Expected Result:

All fields on ' Personal Information' page have been saved

Actual Result:

All fields on ' Personal Information' page have been cleared

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6137848_BA-Personal-Info-cleared-after-Back-from-connectBA.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011bb3d019d1ea96da
• Upwork Job ID: 1683458639028424704
• Last Price Increase: 2023-07-24

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The personal information is cleared when returning to it from the Connect bank account page

What is the root cause of that problem?

The personal information is stored in Onyx under key reimbursementAccountDraft, when clicking Continue on the Connect bank account page the backend resets this Onyx data, believing the bank account has changed:

What changes do you think we should make in order to solve the problem?

The backend should not reset the Onyx data as the bank account has not changed.

What alternative solutions did you explore? (Optional)

N/A

[trjExpensify]

I can reproduce this one. Adding Engineering and Internal for a second opinion on this being a backend issue.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011bb3d019d1ea96da

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @situchan (Internal)

[Li357]

Is this a bug if you did not hit "Save and Continue" to save the personal details? Do we always save optimistically?

[trjExpensify]

Yeah, we optimistically save in the connect bank account flow. Here's the company details page for ref:

f0IL0OBl2q.mp4

[Li357]

Hmm, I think the company information is saved because the user presses the "Save and Continue" button to move to the next step, Personal Details. But if you don't press "Save and Continue" on Personal Details, then it doesn't save, so I don't think this is a bug. Unless we want to change the behavior here.

Under the hood I think this is happening because we actually do save a local copy of partial inputs (without hitting "Save and Continue") but then when you back out to the first Bank Account page, we sent an update to Onyx which sees that its remote copy does not include partial inputs, and so it resets the Personal Details to be the remote copy.

[trjExpensify]

Oh, but in this video I didn't click "save & continue" on the company info step. Why do we treat that differently?

1. I filled in the details on the company info step, didn't click save & continue
2. clicked the back button to return to connect bank account
3. clicked continue to return to connect bank account
4. partial data on company info was present

[Li357]

Hmm, I'm not really sure why it worked for company details... but this is a bug because we tried to access a property in the wrong way, so the bankAccountID, which was saved, was not actually sent back to the server. Working on a fix.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix bankAccountID not being passed on manual BA connect #23677

If no regressions arise, payment will be issued on 2023-08-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @situchan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

@situchan can you get a head start on the checklist, please? Thanks!

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: Refactor: Migrate BankAccountManualStep.js to function component  #22245
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Refactor: Migrate BankAccountManualStep.js to function component  #22245 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This bug was caught by Applause team so I believe this test case is already in VBA flow in testrail and no more test case is needed. @trjExpensify can you please confirm?

[trjExpensify]

This bug was caught by Applause team so I believe this test case is already in VBA flow in testrail and no more test case is needed. @trjExpensify can you please confirm?

Yup, it is! :)

Only payment due here is $1,000 for the C+ review of the internal PR by @situchan. I've sent you an offer on this job here.

[trjExpensify]

Settled up!