Deploy Checklist: New Expensify 2023-07-27

[OSBotify]

Release Version: 1.3.47-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add DeleteMoneyRequest #19095
• Handle isWaitingOnBankAccount for IOU requests #20821
• Convert Date Picker to Functional Component #20864
• 17548 Personal details push to page #21049
• fix: refocus the input field on the login screen after returning to the tab #21656
• Polish admins-only policy room feature #21950
• refactor: WalletStatementPage to function component #22152
• migrate InitialSettingsPage to function component #16281 #22153
• #10148 — The message got sent but it also stayed in the compose box #22227
• Cleanup nested lodashGets from previous PR #22439
• refactor: workspace-invite-page to function component #22646
• [navigation-refactor] Fix animation glitch when navigating in the browser history with swiping iOS Safari #22678
• Fix some RHP pages doing a NAVIGATE action instead of go back #22789
• Fix Emoji picker's position changes on decreasing the screen size #22792
• Use a single moderationDecision instead of the moderationDecisions array #22852
• Component refactor: migrate PopoverWithMeasuredContent to function component #22868
• Fix: Private personal details are not fetched when navigating by direct link #22906
• Disable hover on device without hover support #22925
• fix: clicking spacebar leaves highlight focus on emoji in emoji picker #22995
• Implement animated WorkspacesListPage and LoungeAccessPage #23061
• Migrate AttachmentCarousel/index.js to function component #23072
• Fix: Cannot remove RBR when invite an invalid member to workspace #23157
• Fix - prevent server errors from being cleared on form input field blur #23306
• Fix: Welcome message flickers on LHN after message deletion #23341
• Fix: The title field is cleared when the Confirm task button is pressed #23342
• Migrate RoomNameInput to function component #23354
• Fix: Don't truncate long room names in room details page #23357
• Migrate PayPal page to Form #23360
• fixed: dev: '0:undefined:' displayed in reaction emoji tooltip #23371
• Fix ThumbnailImage on mWeb #23392
• fix MultipleAvatars.js remainding users tooltip text #23396
• Fix: PDFPasswordForm loads the PDF even when password validation fails #23463
• [22658] Highlight specified cancel buttons #23464
• fix translate hidden #23482
• Fix for: Web - Incorrect Redirection to Chat Page when Accessing /workspace/new-room URL #23486
• [CP staging] Fix email delivery failed login view  #23512
• Revert "fix <21137>: fixed cursor reset to beginning" #23518
• add lastActorAccountID in optimisticReport in deleteReportComment #23524
• [CP Staging] hotfix: avoid early prevent default to copy in normal inputs #23525
• Fix text next to multiline link shows at the first line of the link instead of the last #23526
• Ishpaul777/rhn no dropzone #23528
• Remove multiline from task title  #23529
• [CP Staging] fix the typo in the property name #23532
• fix display tooltip on long title in LHN #23533
• [22560] Inconsistency of padding above no results found. #23538
• Fix copy icon alignment #23541
• feat: wrap TaskView inside Hoverable #23545
• Bump Reanimated to 3.4.0 #23550
• [CP Staging] Revert "fix remove only first request" #23551
• remove first request #23562
• numberOfLines to 2 #23571
• [CP Staging] Fix magic link sign in #23574
• Fix MulitpleAvatars alignment #23580
• Revert "Convert Date Picker to Functional Component" #23588
• Fix "Link has been re-sent" text in verify secondary login is not cleared even reload the page #23601
• fix still able to access the deleted link preview #23616
• Use new network hook #23620
• fix: expensify-common version for window-style newline #23628
• fix timezone on profile with new account #23631
• Send the clientPolicyIDToLastModified in addition to the policyIDList #23653
• [No QA] Improve instructions for migrating away from underscore #23668
• Add workflow_dispatch for testing OS Botify App #23682
• Use correct component Text component and fix style #23708
• [CP Staging] Fix/regression unread messages #23729
• [NO QA] Add dev build flavour provisioning cert #23732
• Revert "Bump Reanimated to 3.4.0" #23759

Internal QA:

• Fix: Report Action revert on flag approved decision #23313 -

Deploy Blockers:

• [HOLD for payment 2023-08-08] [HOLD for payment 2023-08-07] Web - 'You'll lose any offline changes if you sign-out.' message appears even if you are online #23742
• Web - User is taken to concierge instead of chat screen when IOU is deleted #23785
• Wrong amount is being shown on IOU preview after removing request #23794
• [HOLD for payment 2023-08-08] Split bill - App crashed when delete split bill #23824
• IOU - Deleted money request is shown when returning online #23827
• [HOLD for payment 2023-08-21] [$1000] Web -Pointer cursor is displayed on send button even when compose box is empty #23848
• [HOLD for payment 2023-08-21] Web - Inconsistency: Delete confirmation is not shown when deleting Money Request #23858
• Web - Can send messages by clicking around the send button, outside the composer, and when the cursor is an arrow #23863
• [HOLD for payment 2023-08-08] [$1000] Dev: Web - Can't click plus button after leaving a room #23881

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.47-2 🚀

[mvtglobally]

#19095 failing #23785
#22227 failing #10148 really old KI is back
#23157 failing #22359
#23533 failing #22609

[mvtglobally]

Regression is completed
#23562 old KI is repro #11778 pls double check if not regression

[Beamanator]

Checking off #23858 since it's a new feature, not a bug

[Beamanator]

Checking off #23863 since it's a super tiny bug, shouldn't block deploy

[Beamanator]

Checking off #23881 because QA & I couldn't reproduce in staging or prod

• Shit, this is marked as dev only
• Ok marking it off again b/c fix PR has been merged into main

[Beamanator]

Checking off #23848 b/c it's only a tiny style bug so not a blocker

[Beamanator]

Tested these manually, so far so good:

• remove first request #23562 (didn't repro [$1000] Settings -Changes "Notifications"/ Priority mode offline aren't saved #11778)
• #10148 — The message got sent but it also stayed in the compose box #22227 (couldn't produce any issues of the message staying in the composer after sending)

These two were reproducible (a.k.a. didn't pass staging QA):

• Fix: Cannot remove RBR when invite an invalid member to workspace #23157
• fix display tooltip on long title in LHN #23533
  • Checking this off since the bug is still present and doesn't cause other bugs

[Beamanator]

Checking off #19095 and #23824 (blocker) since fix PR got merged & CP'd to staging: #23916

[Beamanator]

Also updated latest version to 1.3.47-6

Just a few more points to go!!

[Beamanator]

Confirmed w/ @dangrous that #23313 passed Internal QA 🎉 :D

[Beamanator]

Agreed w/ @NikkiWines we don't need to block on #23157 (discussed here) so checking that last item off!

[Beamanator]

There seem to be a few firebase crashes but they only occur for 1 user and didn't happen often, so will keep an eye on them over the next few days: #23942

[Beamanator]