Fix: The title field is cleared when the Confirm task button is pressed #23342

dukenv0307 · 2023-07-21T10:00:57Z

Details

IOS - The title field is cleared when the Confirm task button is pressed

Fixed Issues

$ #22078 #23210
PROPOSAL: #22078 (comment)

Tests

Login to New Expensify on an iOS handset
Click on + icon
Click on assign task
Enter title and click on next
Enter an assignee
Click on Confirm task
Verify that Title field is not cleared when navigating
Try to update title, description and assignee
Verify that everything works as expected

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login to New Expensify on an iOS handset
Click on + icon
Click on assign task
Enter title and click on next
Enter an assignee
Click on Confirm task
Verify that Title field is not cleared when navigating
Try to update title, description and assignee
Verify that everything works as expected

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.1.mp4

Mobile Web - Chrome

chrome.mp4

Mobile Web - Safari

safari.mp4

Desktop

desktop.2._rmk.mp4

iOS

ios.2.mp4

Android

android.mp4

melvin-bot · 2023-07-21T10:16:39Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2023-07-24T20:38:53Z

This already happens on staging but should we fix TaskAssigneeSelectorModal as well?

Screen.Recording.2023-07-25.at.2.36.50.AM.mov

situchan · 2023-07-25T04:45:56Z

@robertjchen can you please confirm #23342 (comment)?

situchan · 2023-07-25T05:24:48Z

I think assignee page can be fixed separately as it already happens on all envs and a little complex than title, description pages (new/edit assignee pages are in one component)
For tracking, I reported that bug on slack.

robertjchen · 2023-07-25T05:25:51Z

Good question, I think we should address that separately with another PR 🤔

situchan · 2023-07-25T06:06:30Z

While testing, found a few bugs which happen on staging. Report them on slack:

situchan · 2023-07-25T06:07:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan

dukenv0307 · 2023-07-25T07:06:30Z

Bump @robertjchen. Could you help to review this PR

robertjchen · 2023-07-25T07:29:05Z

Sure! Though, to reduce confusion and delays, let's make sure the list of requested Reviewers is clear so that no one is left waiting or gets passed over for review 👍

OSBotify · 2023-07-25T07:33:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-26T16:10:55Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 1.3.46-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-27T22:09:07Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 1.3.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-27T22:39:41Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.46-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-31T18:37:36Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.47-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

robertKozik · 2023-09-25T11:28:16Z

src/pages/tasks/NewTaskPage.js

+    useEffect(
+        () => () => {
+            if (!shouldClearOutTaskInfoOnUnmount.current) {
+                return;
+            }
+            Task.clearOutTaskInfo();
+        },
+        [],
+    );


On lower end devices this caused race condition with the loading of next screen

dukenv0307 added 2 commits July 21, 2023 14:32

using report field instead of task.report field

95ced48

fix: lint issue

dea5c96

dukenv0307 marked this pull request as ready for review July 21, 2023 10:16

dukenv0307 requested a review from a team as a code owner July 21, 2023 10:16

melvin-bot bot requested review from 0xmiros and removed request for a team July 21, 2023 10:16

dukenv0307 changed the title ~~using report field instead of task.report field~~ Fix: The title field is cleared when the Confirm task button is pressed Jul 21, 2023

dukenv0307 mentioned this pull request Jul 24, 2023

[HOLD for payment 2023-08-03] [$1000] IOS - The title field is cleared when the Confirm task button is pressed #22078

Closed

6 tasks

situchan mentioned this pull request Jul 24, 2023

[HOLD for payment 2023-08-15] App crashes when edited description of task #23210

Closed

6 tasks

situchan approved these changes Jul 25, 2023

View reviewed changes

melvin-bot bot requested a review from robertjchen July 25, 2023 06:08

robertjchen approved these changes Jul 25, 2023

View reviewed changes

robertjchen merged commit ecf0ec2 into Expensify:main Jul 25, 2023

dukenv0307 mentioned this pull request Jul 25, 2023

[HOLD for payment 2023-08-17] [$1000] Cannot change assignee after task created #23556

Closed

6 tasks

BhuvaneshPatil mentioned this pull request Jul 26, 2023

[$1000] Web -Task - Empty description is displayed even when description is set in task #23294

Closed

6 tasks

OSBotify mentioned this pull request Jul 26, 2023

Deploy Checklist: New Expensify 2023-07-26 #23657

Closed

43 tasks

kbecciv mentioned this pull request Jul 26, 2023

[$1000] Assign Task - Attendee name disappears when editing the title of the task for the first time #23684

Closed

6 tasks

OSBotify mentioned this pull request Jul 27, 2023

Deploy Checklist: New Expensify 2023-07-27 #23765

Closed

79 tasks

robertKozik mentioned this pull request Aug 29, 2023

[HOLD for payment 2023-09-21] [$1000] Assign task-Tapping on any contact, user unable to select assignee #25689

Closed

6 tasks

robertKozik reviewed Sep 25, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: The title field is cleared when the Confirm task button is pressed #23342

Fix: The title field is cleared when the Confirm task button is pressed #23342

dukenv0307 commented Jul 21, 2023 •

edited

Loading

melvin-bot bot commented Jul 21, 2023

situchan commented Jul 24, 2023

situchan commented Jul 25, 2023

situchan commented Jul 25, 2023

robertjchen commented Jul 25, 2023

situchan commented Jul 25, 2023

situchan commented Jul 25, 2023

situchan left a comment

dukenv0307 commented Jul 25, 2023

robertjchen commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 31, 2023

robertKozik Sep 25, 2023

Fix: The title field is cleared when the Confirm task button is pressed #23342

Fix: The title field is cleared when the Confirm task button is pressed #23342

Conversation

dukenv0307 commented Jul 21, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 21, 2023

situchan commented Jul 24, 2023

situchan commented Jul 25, 2023

situchan commented Jul 25, 2023

robertjchen commented Jul 25, 2023

situchan commented Jul 25, 2023

situchan commented Jul 25, 2023

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

dukenv0307 commented Jul 25, 2023

robertjchen commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 31, 2023

robertKozik Sep 25, 2023

Choose a reason for hiding this comment

dukenv0307 commented Jul 21, 2023 •

edited

Loading