[$1000] Web -Task - Empty description is displayed even when description is set in task

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Click plus and click on assign task
3. Write any title and description and click next
4. Select any assignee and any user to share somewhere and click confirm task
5. In task report, click on plus and click assign task
6. Write any title, keep description empty and click next
7. Close the right hand menu and now click on current report description and observe that even though task has description, it is displayed as empty

Expected Result:

App should display currently set description when we click on description in any task report

Actual Result:

App displays empty description when we click on plus and assign task from task report, set title, keep description empty, click on next, close the right hand menu and click on description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

empty.description.even.when.description.is.set.mp4

Recording.3783.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689841710414669

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010cf7591e3ba247f3
• Upwork Job ID: 1683549848105144320
• Last Price Increase: 2023-07-24

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Empty description is displayed even when description is set in task

What is the root cause of that problem?

In TaskDescriptionPage component, we are getting task from Onyx.

App/src/pages/tasks/NewTaskDescriptionPage.js

Lines 94 to 104 in e87f2eb

	export default compose(
	withOnyx({
	betas: {
	key: ONYXKEYS.BETAS,
	},
	task: {
	key: ONYXKEYS.TASK,
	},
	}),
	withLocalize,
	)(NewTaskDescriptionPage);

And when we create new task (partially) as shown in video, the task value is changed and thus when we try to get that value from onyx, we get empty value -

What changes do you think we should make in order to solve the problem?

Above logic of getting task from onyx works well when we are creating a new task, but for that we use NewTaskDescriptionPage.
In this case instead of getting the task from onyx, we will get report. As we have reportID from route, we can use it to fetch the report on TaskDescriptionPage and use the value of description from the report.

we can get report fro onyx following way -

report: {
    key: ({route}) => `${ONYXKEYS.COLLECTION.REPORT}${route.params.reportID}`,
},

and for TextInput we can set the defaultValue

defaultValue={(props.report && props.report.description) || ''}

We have to change the submit method in component in order to accompany the changes.
from props.task.report -> props.report

Similar to this we have done in - TaskTitlePage

What alternative solutions did you explore? (Optional)

[dhairyasenjaliya]

this should be fixed #23210

[dhanashree-sawant]

Hi @dhairyasenjaliya, I think they have cross checked that first, kindly check the slack conversation once.

[dukenv0307]

Maybe this issue will be fixed by #22078

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web -Task - Empty description is displayed even when description is set in task

What is the root cause of that problem?

This issue only happens on the description page (doesn't happen on the title page). This is because on the TaskTitlePage we use the report field from ONYX directly and on the TaskDescriptionPage we use task.report field from ONYX. So we need setTaskReport before going to TaskDescriptionPage

What changes do you think we should make in order to solve the problem?

On TaskDescriptionPage, we should use the report field from ONYX directly like on the TaskTitlePage and we don't need to call setTaskReport on TaskDescriptionPage

[0xmiros]

Though root cause is different, this will be part of solution in #22078 to avoid #23210.

[BhuvaneshPatil]

@0xmiroslav
This issue solves the problem occurring in #22078 , and the selected proposal for that came after this bug and it's same as proposed solution, so this bug should fix the #22078

[isabelastisser]

Not overdue!

[isabelastisser]

Asking for guidance in Slack:

https://expensify.slack.com/archives/C049HHMV9SM/p1690223105956899?thread_ts=1689841710.414669&cid=C049HHMV9SM

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010cf7591e3ba247f3

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[sobitneupane]

@isabelastisser I was unable to reproduce the issue. Is this still reproducible on your end?

[BhuvaneshPatil]

Though root cause is different, this will be part of solution in #22078 to avoid #23210.

@sobitneupane I think it was solved here. This is the PR - #23342
I have left a comment here about the proposals.

[isabelastisser]

Thanks @sobitneupane!

• I will issue the payment in Upwork now and close this issue.

Payment: @dhanashree-sawant $250 - issue reporter.

[dhanashree-sawant]

Thanks @isabelastisser, I have accepted the offer.