[HOLD for payment 2023-08-24] [$1000] Task Report doesn't grey out when create task offline

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go offline
2. Create Task

Expected Result:

Task Report should grey out when create task offline

Actual Result:

Task Report doesn't grey out when create task offline

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-29.at.17.19.42.mov

Expensify/Expensify Issue URL:
Issue reported by: @ChengDzun
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690626730679279

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01afec56cf0d694a04
• Upwork Job ID: 1685971979400462336
• Last Price Increase: 2023-07-31
• Automatic offers:
• ChengDzun | Contributor | 25928421
• ChengDzun | Reporter | 25928425

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal from contributor

Please re-state the problem that we are trying to solve in this issue.

When making any actions offline the result of this action will be greyed out. But when creating a new task, the task report isn't greyed out

What is the root cause of that problem?

In ReportActionItem Component

App/src/pages/home/report/ReportActionItem.js

Lines 459 to 465 in eb02006

	if (ReportUtils.isTaskReport(props.report)) {
	return (
	<TaskView
	report={props.report}
	shouldShowHorizontalRule={!props.isOnlyReportAction}
	/>
	);

We don't wrap TaskReport by OfflineWithFeedback Component, so the offline pattern isn't applied

What changes do you think we should make in order to solve the problem?

We should wrap TaskReport by OfflineWithFeedback Component as we did here

App/src/pages/home/report/ReportActionItem.js

Line 531 in eb02006

<OfflineWithFeedback

We also consider doing the same thing with MoneyReportView Component

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01afec56cf0d694a04

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[mananjadhav]

Thanks for the proposal @ChengDzun. Could you elaborate on what props will be passed to the OfflineWithFeedback here?

[ghost]

@mananjadhav Because I can't update proposal. So I write this comment to resolve your question.

I think we only need to pass pendingAction field like this

<OfflineWithFeedback pendingAction={props.report.pendingFields}>  // We can also use props.action. pendingAction for this props. Both ways give the same result 
          <TaskView
               report={props.report}
               shouldShowHorizontalRule={!props.isOnlyReportAction}
           />
</OfflineWithFeedback>

This is result
Web:

Mobile:

[mananjadhav]

@ChengDzun's proposal looks good to me.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @ChengDzun 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @ChengDzun 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[ghost]

@mananjadhav I just accepted offer and also created PR for this issue

[stitesExpensify]

Agreed, it looks like the C+ reviewed the PR August 4, and I did not ask for any changes, so this was technically completed in 1 day. The bonus should apply @bfitzexpensify

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• add-offline-pattern-to-task-view #24056

If no regressions arise, payment will be issued on 2023-08-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligable for Manual Requests)
• @ChengDzun requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[bfitzexpensify]

Payment is due tomorrow, but I'll be ooo for the next week — @johncschuster, appreciate you helping out with this one! Worth noting that we agreed here - #23893 (comment) - that this should be eligible for the #urgency bonus.

[mananjadhav]

@bfitzexpensify @johncschuster Can one of you please post the payment summary here?

[JmillsExpensify]

Yes, I need a payment summary to get this payment approved in NewDot.

[ghost]

This is a payment summary

External issue reporter @ChengDzun $250
Contributor that fixed the issue @ChengDzun $1500 (basic + urgency)
Contributor+ that helped on the issue and PR @mananjadhav $1500 (basic + urgency)

@JmillsExpensify @mananjadhav @bfitzexpensify Anyone help to confirm ?

[JmillsExpensify]

Only @bfitzexpensify can confirm for payments to be issued.

[johncschuster]

Looks like I'm taking over for @bfitzexpensify. Let me confirm the payments now.

[johncschuster]

Ah yep, it looks like @stitesExpensify believes the PR is eligible for the bonus (comment). @JmillsExpensify, I'll take care of the payments on Upwork and leave a summary for you below.

[johncschuster]

Payment Summary:

External issue reporter @ChengDzun $250
Contributor that fixed the issue @ChengDzun $1500 (basic + urgency)
Contributor+ that helped on the issue and PR @mananjadhav $1500 (basic + urgency)

[JmillsExpensify]

Reviewed the details for @mananjadhav. $1,500 approved for payment in NewDot based on BZ summary above.

[ghost]

@johncschuster @JmillsExpensify Could you help to approve my new request (for bonus) on Upwork?

[johncschuster]

@ChengDzun thanks for your patience! I've issued the bonus payment 👍