Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Home address - Page constantly crashes if insert values and quit the app #24006

Closed
2 of 6 tasks
lanitochka17 opened this issue Aug 1, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Monthly KSv2 Not a priority Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 1, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #22788

Action Performed:

  1. Open iOS app
  2. Open "Settings"
  3. Tap on "Profile"
  4. Tap on "Personal details"
  5. Tap on "Home address"
  6. Input values in fields (address line 2 is not necessary)
  7. Close the app completely
  8. Proceed to "Personal details" tab
  9. Tap on "Home address"

Expected Result:

User lands in "Home address" tab

Actual Result:

App crashes constantly when user taps on "Home address" , user needs to log out and log back in to access home address tab

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.48.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6149362_Crash.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Aug 1, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Aug 1, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@rushatgabhane
Copy link
Member

rushatgabhane commented Aug 1, 2023

Not reproducible on latest main for iOS and Android.

But on web, I can't open the Home address page.

@hannojg
Copy link
Contributor

hannojg commented Aug 1, 2023

Error log

Simulator Screen Shot - iPhone 14 - 2023-08-01 at 17 26 33

@hannojg
Copy link
Contributor

hannojg commented Aug 1, 2023

This is a regression of:

which was reverted here:

@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label Aug 1, 2023
@Beamanator
Copy link
Contributor

Should be fixed now, as of #24003

@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Aug 1, 2023
@melvin-bot melvin-bot bot changed the title Home address - Page constantly crashes if insert values and quit the app [HOLD for payment 2023-08-08] Home address - Page constantly crashes if insert values and quit the app Aug 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added the Weekly KSv2 label Aug 3, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-08-08] Home address - Page constantly crashes if insert values and quit the app [HOLD for payment 2023-08-10] [HOLD for payment 2023-08-08] Home address - Page constantly crashes if insert values and quit the app Aug 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-08-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Daily KSv2 and removed Weekly KSv2 labels Aug 7, 2023
@situchan situchan mentioned this issue Aug 18, 2023
59 tasks
@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

@johnmlee101 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2023

@johnmlee101 10 days overdue. Is anyone even seeing these? Hello?

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

This issue has not been updated in over 14 days. @johnmlee101 eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

This issue has not been updated in over 15 days. @johnmlee101 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 22, 2023
@melvin-bot melvin-bot bot closed this as completed Nov 20, 2023
Copy link

melvin-bot bot commented Nov 20, 2023

@johnmlee101, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Monthly KSv2 Not a priority Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants