[HOLD for payment 2023-08-24] [$1000] Task - Second avatar of group avatar is highlighted when long pressing on Share somewhere #24008

lanitochka17 · 2023-08-01T15:12:26Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify.com
Go to any group chat
Click + > Assign task
Enter title and click Next
Long press on Share somewhere field

Expected Result:

Since Share somewhere field is not selectable in group chat task assignment, it should not have any feedback when pressing on it

Actual Result:

The second avatar of group avatar is highlighted when long pressing on Share somewhere

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.48.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6149411_Screen_Recording_20230801_200354_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause -Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a8af40e296417c50
Upwork Job ID: 1686485461826138112
Last Price Increase: 2023-08-01
Automatic offers:

reinaldosg | Contributor | 25951887

melvin-bot · 2023-08-01T15:12:32Z

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-08-01T15:12:33Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

reinaldosg · 2023-08-01T16:14:15Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Second avatar of group avatar is highlighted on long press

What is the root cause of that problem?

MultipleAvatars style ignore props.interactive so the element always have action

App/src/components/MenuItem.js

Lines 155 to 156 in 9dc5f19

    
           pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.buttonPressedBG) : undefined, 
        
           isHovered && !pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.border) : undefined,

What changes do you think we should make in order to solve the problem?

Check props.interactive to determine the style

pressed && props.interactive ? StyleUtils.getBackgroundAndBorderStyle(themeColors.buttonPressedBG) : undefined,
isHovered && !pressed && props.interactive ? StyleUtils.getBackgroundAndBorderStyle(themeColors.border) : undefined,

What alternative solutions did you explore? (Optional)

melvin-bot · 2023-08-01T21:14:04Z

Job added to Upwork: https://www.upwork.com/jobs/~01a8af40e296417c50

melvin-bot · 2023-08-01T21:14:07Z

Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-08-01T21:14:14Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

hanzalahsamana · 2023-08-01T21:28:37Z

I can do this

melvin-bot · 2023-08-01T21:28:41Z

📣 @hanzalahsamana! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

icarus-0520 · 2023-08-01T21:44:38Z

In components, MenuItem.js, lines 148-158:
<MultipleAvatars isHovered={isHovered} isPressed={pressed} icons={props.icon} size={props.avatarSize} secondAvatarStyle={[ StyleUtils.getBackgroundAndBorderStyle(themeColors.sidebar), pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.buttonPressedBG) : undefined, isHovered && !pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.border) : undefined, ]} />

The pressable this is a child to does check for props.disabled and !props.interactive, but isHovered is passed from further up the hierarchy, so it appears that these checks are not actually diverting inherited values. The first thing I'd do is add in conditionals to isHovered and isPressed that switch to a hardcoded value pending a check to either props.disabled or !props.interactive. there are a couple of different configurations possible there, so I'd try out all of them and log values to see if this theory is correct.

melvin-bot · 2023-08-01T21:44:41Z

📣 @icarus-0520! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

icarus-0520 · 2023-08-01T21:45:16Z

Contributor details
Expensify account email: aidan@disillusion.io
Upwork profile link: https://www.upwork.com/freelancers/~01ee97b9ff5ee5d693

Muhammad-Saqib-980 · 2023-08-01T22:03:20Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Second avatar of group avatar is highlighted when long pressing on Share somewhere

What is the root cause of that problem?

MultipleAvatars style ignore props.interactive so the element always highlights the second avatar on press

What changes do you think we should make in order to solve the problem?

props.interactive should be used to determine if the second avatar should be highlighted on press or not.

hungvu193 · 2023-08-02T02:45:06Z

@lanitochka17 Can you please update me as the reporter, I already reported it here:
https://expensify.slack.com/archives/C049HHMV9SM/p1689689817652489

s-alves10 · 2023-08-02T06:48:38Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Secondary avatar of group avatar is highlighted when hovering or long pressing on share somewhere

What is the root cause of that problem?

When we assign a task in a group chat, props.task.parentReportID is the reportID of the group chat and props.interactive is false in order to prevent interaction

App/src/pages/tasks/NewTaskPage.js

Line 181 in 6a38341

interactive={!props.task.parentReportID}

But Multiple avatar ignores this props

App/src/components/MenuItem.js

Lines 153 to 157 in 6a38341

    
           secondAvatarStyle={[ 
        
               StyleUtils.getBackgroundAndBorderStyle(themeColors.sidebar), 
        
               pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.buttonPressedBG) : undefined, 
        
               isHovered && !pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.border) : undefined, 
        
           ]}

This is the root cause

What changes do you think we should make in order to solve the problem?

This issue may happens for all child components related to isHovered and pressed

We need to replace all occurrence of isHovered and pressed with isHovered && props.interactive and pressed && props.interactive in the MenuItem component

What alternative solutions did you explore? (Optional)

CuongXuanLe · 2023-08-02T08:45:49Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Second avatar of group avatar is highlighted on long press

What is the root cause of that problem?

When we assign a task in a group chat, the props.task.parentReportID is id of this room. So the !props.task.parentReportID of interactive below is false.

App/src/pages/tasks/NewTaskPage.js

Line 186 in 9dc5f19

interactive={!props.task.parentReportID}

So MultipleAvatars ignore props.interactive and second avatar of group avatar is highlighted when long pressing.

App/src/components/MenuItem.js

Lines 155 to 156 in 9dc5f19

    
           pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.buttonPressedBG) : undefined, 
        
           isHovered && !pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.border) : undefined,

What changes do you think we should make in order to solve the problem?

Add props.interactive condition to define style

secondAvatarStyle={[
   StyleUtils.getBackgroundAndBorderStyle(themeColors.sidebar),
   pressed && props.interactive ? StyleUtils.getBackgroundAndBorderStyle(themeColors.buttonPressedBG) : undefined,   isHovered && !pressed && props.interactive ? StyleUtils.getBackgroundAndBorderStyle(themeColors.border) : undefined,
]}

What alternative solutions did you explore? (Optional)

melvin-bot · 2023-08-02T08:45:52Z

📣 @CuongXuanLe! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

melvin-bot · 2023-08-02T08:58:13Z

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

melvin-bot · 2023-08-02T09:02:00Z

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

melvin-bot · 2023-08-02T09:03:53Z

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

CuongXuanLe · 2023-08-02T09:20:48Z

Contributor details
Your Expensify account email: thuy.lethithu@antbuddy.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01fcd9ed589276332f

melvin-bot · 2023-08-02T09:20:50Z

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

ares-dev05 · 2023-08-02T09:49:39Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Second avatar of group avatar is highlighted on long press on Share somewhere field

What is the root cause of that problem?

When the "Share everywhere" menu is pressed, the interactive props are set to false to prevent the avatars in this menu from responding to press events. However, the MultipleAvatars component did not handle this interactive props variable.

What changes do you think we should make in order to solve the problem?

In the MenuItem.js file, on the 148th line, you can update the use case for the MultipleAvatars component as the following.

<MultipleAvatars
    isHovered={isHovered}
    isPressed={pressed}
    icons={props.icon}
    size={props.avatarSize}
    secondAvatarStyle={[
        StyleUtils.getBackgroundAndBorderStyle(themeColors.sidebar),
        pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.buttonPressedBG) : undefined,
        isHovered && !pressed ? StyleUtils.getBackgroundAndBorderStyle(themeColors.border) : undefined,
    ]}
/>

What alternative solutions did you explore? (Optional)

N/A

melvin-bot · 2023-08-17T01:42:04Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-08-17T01:42:07Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix second avatar style highlighted #24172

If no regressions arise, payment will be issued on 2023-08-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@reinaldosg requires payment offer (Contributor)
@sobitneupane does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-08-17T01:42:09Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

lschurr · 2023-08-22T04:33:46Z

Hi @sobitneupane - could you work on the checklist? Do we need a regression test for this?

lschurr · 2023-08-22T04:36:07Z

Payment summary:

Bug report: @hungvu193 $250
Contributor: @reinaldosg $1500 (to be paid in Upwork)
Contributor+: @sobitneupane $1500 (to be paid in Newdot)

hungvu193 · 2023-08-22T04:37:14Z

@lanitochka17 Can you please update me as the reporter, I already reported it here: https://expensify.slack.com/archives/C049HHMV9SM/p1689689817652489

@lschurr Can you update the reporter? I actually reported this before.

lschurr · 2023-08-24T19:44:58Z

@sobitneupane could you work through the checklist for this one?

lschurr · 2023-08-24T19:46:02Z

Could you apply to the job @hungvu193? https://www.upwork.com/jobs/~01a8af40e296417c50

hungvu193 · 2023-08-24T22:33:55Z

Could you apply to the job @hungvu193? https://www.upwork.com/jobs/~01a8af40e296417c50

Applied, Thank you

melvin-bot · 2023-08-28T09:59:20Z

@danieldoglas, @reinaldosg, @sobitneupane, @lschurr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

sobitneupane · 2023-08-28T10:32:36Z

Sorry for the delay. I will try to get to it by EOD.

lschurr · 2023-08-29T19:30:03Z

Bump on this one @sobitneupane :)

lschurr · 2023-08-30T14:18:10Z

Hi @sobitneupane - would really like to get this one closed out. Could you confirm whether we need a regression test or not?

sobitneupane · 2023-08-31T14:59:54Z

Regression Test Proposal

Open a group chat
Assign task
Enter title and click Next
Hover on Share somewhere field -> Verify that avatars are not highlighted
Press on Share somewhere field -> Verify that avatars are not highlighted
Long Press on Share somewhere field -> Verify that avatars are not highlighted

Do we agree 👍 or 👎

sobitneupane · 2023-08-31T17:05:09Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#20145

[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/20145/files#r1311937536

[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

[@sobitneupane] Determine if we should create a regression test for this bug.

Yes

[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#24008 (comment)

melvin-bot · 2023-09-04T10:30:51Z

@danieldoglas, @reinaldosg, @sobitneupane, @lschurr Whoops! This issue is 2 days overdue. Let's get this updated quick!

danieldoglas · 2023-09-04T13:40:39Z

@lschurr I think this one is ready to pay/close!

lschurr · 2023-09-04T23:48:25Z

Yep, thanks! I'm going to create a QA GH and will close.

lschurr · 2023-09-05T00:03:43Z

All done!

sobitneupane · 2023-09-05T17:58:18Z

Requested payment on newDot.

#24008 (comment)

JmillsExpensify · 2023-09-10T10:34:09Z

$1,500 approved for payment via NewDot based on BZ summary.

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 1, 2023

melvin-bot bot assigned lschurr Aug 1, 2023

lschurr added the External Added to denote the issue can be worked on by a contributor label Aug 1, 2023

melvin-bot bot changed the title ~~Task - Second avatar of group avatar is highlighted when long pressing on Share somewhere~~ [$1000] Task - Second avatar of group avatar is highlighted when long pressing on Share somewhere Aug 1, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 1, 2023

melvin-bot bot assigned sobitneupane Aug 1, 2023

melvin-bot bot added the Overdue label Aug 3, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Aug 17, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 23, 2023

melvin-bot bot added the Overdue label Aug 28, 2023

melvin-bot bot removed the Overdue label Aug 28, 2023

sobitneupane mentioned this issue Aug 31, 2023

feat: use MenuItem instead of TaskSelectorLink on Task page #20145

Merged

56 tasks

melvin-bot bot added the Overdue label Sep 4, 2023

melvin-bot bot removed the Overdue label Sep 4, 2023

lschurr closed this as completed Sep 5, 2023

[HOLD for payment 2023-08-24] [$1000] Task - Second avatar of group avatar is highlighted when long pressing on Share somewhere #24008

[HOLD for payment 2023-08-24] [$1000] Task - Second avatar of group avatar is highlighted when long pressing on Share somewhere #24008

Comments

lanitochka17 commented Aug 1, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Aug 1, 2023

melvin-bot bot commented Aug 1, 2023

Bug0 Triage Checklist (Main S/O)

reinaldosg commented Aug 1, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Aug 1, 2023

melvin-bot bot commented Aug 1, 2023

melvin-bot bot commented Aug 1, 2023

hanzalahsamana commented Aug 1, 2023

melvin-bot bot commented Aug 1, 2023

icarus-0520 commented Aug 1, 2023

melvin-bot bot commented Aug 1, 2023

icarus-0520 commented Aug 1, 2023

Muhammad-Saqib-980 commented Aug 1, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

hungvu193 commented Aug 2, 2023

s-alves10 commented Aug 2, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

CuongXuanLe commented Aug 2, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

CuongXuanLe commented Aug 2, 2023

melvin-bot bot commented Aug 2, 2023

ares-dev05 commented Aug 2, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Aug 17, 2023

melvin-bot bot commented Aug 17, 2023

melvin-bot bot commented Aug 17, 2023

lschurr commented Aug 22, 2023

lschurr commented Aug 22, 2023 • edited Loading

hungvu193 commented Aug 22, 2023

lschurr commented Aug 24, 2023

lschurr commented Aug 24, 2023

hungvu193 commented Aug 24, 2023

melvin-bot bot commented Aug 28, 2023

sobitneupane commented Aug 28, 2023

lschurr commented Aug 29, 2023

lschurr commented Aug 30, 2023

sobitneupane commented Aug 31, 2023

sobitneupane commented Aug 31, 2023

melvin-bot bot commented Sep 4, 2023

danieldoglas commented Sep 4, 2023

lschurr commented Sep 4, 2023

lschurr commented Sep 5, 2023

sobitneupane commented Sep 5, 2023

JmillsExpensify commented Sep 10, 2023

lanitochka17 commented Aug 1, 2023 •

edited by melvin-bot bot

Loading

reinaldosg commented Aug 1, 2023 •

edited

Loading

s-alves10 commented Aug 2, 2023 •

edited

Loading

CuongXuanLe commented Aug 2, 2023 •

edited

Loading

lschurr commented Aug 22, 2023 •

edited

Loading