[$1000] [HOLD for payment 2023-08-14] Dev: Offline Indicator duplicate

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click FAB
2. Request money
3. Turn off network, Observe that offline Indicator appears 2 times

Expected Result:

offline Indicator only appears 1 times

Actual Result:

offline Indicator appears 2 times

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• [x ] Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

rpreplay_final1691025997.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691026269347159?thread_ts=1691026269.347159&cid=C049HHMV9SM

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011ea26026f1b18139
• Upwork Job ID: 1691534812625043456
• Last Price Increase: 2023-08-15

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal from @namhihi237

Please re-state the problem that we are trying to solve in this issue.

Offline Indicator only appears 1 time in request money tab

What is the root cause of that problem?

In the request money manual screen, we have 2 nested ScreenWrapper. That why it's show 2 times

App/src/pages/iou/MoneyRequestSelectorPage.js

Lines 79 to 83 in 2f750ad

	<ScreenWrapper includeSafeAreaPaddingBottom={false}>
	{({safeAreaPaddingBottomStyle}) => (
	<FullPageNotFoundView shouldShow={!IOUUtils.isValidMoneyRequestType(iouType)}>
	<DragAndDropProvider isDisabled={props.selectedTab === CONST.TAB.MANUAL}>
	<View style={[styles.flex1, safeAreaPaddingBottomStyle]}>

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 111 in 2f750ad

<MoneyRequestAmount route={props.route} />

App/src/pages/iou/steps/MoneyRequestAmount.js

Lines 424 to 429 in 2f750ad

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	onEntryTransitionEnd={focusTextInput}
	>
	{({safeAreaPaddingBottomStyle}) => (
	<View style={[styles.flex1, safeAreaPaddingBottomStyle]}>

What changes do you think we should make in order to solve the problem?

We should add shouldShowOfflineIndicator = {false} and remove safeAreaPaddingBottomStyle for ScreenWrapper in MoneyRequestAmount

            <ScreenWrapper
                includeSafeAreaPaddingBottom={false}
                onEntryTransitionEnd={focusTextInput}
                shouldShowOfflineIndicator = {false}
            >
             <View style={[styles.flex1]}>

What alternative solutions did you explore? (Optional)

N/A

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Beamanator]

Thanks for reporting and proposing a solution @namhihi237 ! Let's also try to find where this came from :D

[namhihi237]

@Beamanator I think it comes from this PR, we are refreshing the request money page here.

[Beamanator]

Yes true, it looks like @s77rt brought this up in the PR here: https://github.com/Expensify/App/pull/23046/files#r1278470491

[Beamanator]

Hmm and this PR supposedly will clean up the nested ScreenWrappers: #23979

[Beamanator]

Discussing in slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1691052873878459

[Beamanator]

Bug fixed in main - keeping open for now for payments

• @s77rt fixed the bug
• @abdulrahuman5196 was C+ testing the fix

[abdulrahuman5196]

@greg-schroeder I think there has been some issue with melvin. This issue was deployed to production on Aug 7 #24097 (comment). This issue should turn to hold for payment till Aug 14. Can we kindly update manually?

[greg-schroeder]

updated

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

It was already brought up in the PR - https://github.com/Expensify/App/pull/23046/files#r1278470491

Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

I think there should be some general Offline regression test on the App level which should be fine for this as well IMO.

If there is none on app level use the below,

1. Click FAB
2. Press Money Request
3. Go Offline
4. Verify there is only one Offline Indicator at the bottom

cc: @greg-schroeder

[greg-schroeder]

Processing this, sorry for the slight delay

[greg-schroeder]

Issue Participants:

Issue reported by: @namhihi237
Contributor: @s77rt
C+: @abdulrahuman5196

Was this issue merged in time to be eligible for the speed bonus? ✅
Were their any regressions? ❌

Payment summary:

Reporter: $250
Contributor: $1500
C+: $1500

[greg-schroeder]

Adding External to create an Upwork job

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011ea26026f1b18139

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignees @s77rt and @abdulrahuman5196 are eligible for the External assigner, not assigning anyone new.

[greg-schroeder]

Offers sent, regression test filed. Closing!

[namhihi237]

Thanks @greg-schroeder accepted.

[s77rt]

No payment is due for me here. I'm assigned for #23046. Payment will be handled there as this is a regression.

[greg-schroeder]

Ohh, right right okay thanks for clarifying

[namhihi237]

@greg-schroeder bump on this. Any update payment for this?

[abdulrahuman5196]

@greg-schroeder C+ review payment is due here.

[greg-schroeder]

Hmm. My Upwork UI shows these as paid on the admin side.

[greg-schroeder]

Weird. When I click into the contracts they don't show as Paid now. Sorry about that. I've paid them now.

[namhihi237]

Thanks for checking @greg-schroeder .