Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-16] [$1000] Payment issue for E/App PR#23046 #24081

Closed
melvin-bot bot opened this issue Aug 2, 2023 · 15 comments
Closed

[HOLD for payment 2023-08-16] [$1000] Payment issue for E/App PR#23046 #24081

melvin-bot bot opened this issue Aug 2, 2023 · 15 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 2, 2023

Issue created to compensate the Contributor+ member for their work on #23046
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/295238.
Contributor+ member who reviewed the PR - @s77rt.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e4f60ce699a7db68
  • Upwork Job ID: 1686869044904517632
  • Last Price Increase: 2023-08-14
@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Aug 2, 2023
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Aug 2, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 2, 2023

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 2, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 2, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01e4f60ce699a7db68

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Aug 2, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 2, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 2, 2023

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

@AndrewGable
Copy link
Contributor

Please send @s77rt a bonus as discussed 1:1, he helped a bunch here.

@s77rt
Copy link
Contributor

s77rt commented Aug 2, 2023

Thanks but I'm really happy with the flat $1k. I'm glad I was able to help!

@melvin-bot melvin-bot bot added the Overdue label Aug 7, 2023
@stephanieelliott
Copy link
Contributor

PR is still on staging. Will update with payment date once it is merged to prod #23046

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Overdue Daily KSv2 labels Aug 7, 2023
@stephanieelliott
Copy link
Contributor

Deployed to prod on Aug 9, updating labels to pay out once 7-day hold ends on Aug 16.

@melvin-bot melvin-bot bot removed the Overdue label Aug 14, 2023
@stephanieelliott stephanieelliott changed the title Payment issue for E/App PR#23046 [HOLD for payment 2023-08-16] [$1000] Payment issue for E/App PR#23046 Aug 14, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 14, 2023

Upwork job price has been updated to $1000

@stephanieelliott
Copy link
Contributor

stephanieelliott commented Aug 16, 2023

Summarizing payment on this issue:

  • Issue reporter: N/A
  • Contributor: N/A
  • Contributor+: $1,500 @s77rt, to pay via Upwork

Upwork job is here, payment includes $1k bonus on final payout as discussed 1:1 with @AndrewGable

@s77rt I extended the offer to you on Upwork, please accept when you get a chance!

@s77rt
Copy link
Contributor

s77rt commented Aug 16, 2023

@stephanieelliott We have a regression #24092. I have accepted the offer. I think the total price would be $500.

@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Aug 22, 2023

@s77rt, @stephanieelliott Eep! 4 days overdue now. Issues have feelings too...

@stephanieelliott
Copy link
Contributor

Hey @s77rt can you link to the second PR, the one that fixed the regression from #23046? I can't find it, and we'll want to base the payment date off that merge date

@melvin-bot melvin-bot bot removed the Overdue label Aug 22, 2023
@s77rt
Copy link
Contributor

s77rt commented Aug 22, 2023

@stephanieelliott #24097

@melvin-bot melvin-bot bot added the Overdue label Aug 25, 2023
@stephanieelliott
Copy link
Contributor

Thanks! OK seeing as that PR was merged 7+ days ago, I will pay out this issue now:

Summarizing payment on this issue:

  • Issue reporter: N/A
  • Contributor: N/A
  • Contributor+: $1,500 @s77rt, to pay via Upwork ($1000 issue price * 50% regression penalty + $1000 bonus)

Upwork job is here, payment includes $1k bonus on final payout as discussed 1:1 with @AndrewGable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

3 participants