Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Mark as unread not working when request money for workspace #24112

Closed
5 tasks
kavimuru opened this issue Aug 3, 2023 · 15 comments
Closed
5 tasks

Dev: Mark as unread not working when request money for workspace #24112

kavimuru opened this issue Aug 3, 2023 · 15 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed

Comments

@kavimuru
Copy link

kavimuru commented Aug 3, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click FAB => request money
  2. Input amount => next
  3. Select a workspace => request
  4. Hover on message request money click mark as unread, Observe that the message is not marked unread.

Expected Result:

Message is marked unread

Actual Result:

Message is not marked unread

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • [x ] MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: dev
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bug

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691027823277929?thread_ts=1691027823.277929&cid=C049HHMV9SM

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

OSBotify commented Aug 3, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@namhihi237
Copy link
Contributor

Videos reproduce

Screen.Recording.2023-08-03.at.08.57.13.1.mov

@Beamanator
Copy link
Contributor

@vitHoracek @Julesssss @luacmartins this is all still under beta, right? So probably NAB?

@Beamanator Beamanator added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 3, 2023
@Beamanator
Copy link
Contributor

Marking NAB for now due to ^

@dangrous
Copy link
Contributor

dangrous commented Aug 3, 2023

Seems like this can just be a regular external issue, I think?

@rushatgabhane
Copy link
Member

rushatgabhane commented Aug 5, 2023

even weirder, why is there an option to "Pay" when the workspace owes you money

@melvin-bot melvin-bot bot added the Overdue label Aug 6, 2023
@maddylewis maddylewis added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 6, 2023

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot

This comment was marked as duplicate.

@maddylewis
Copy link
Contributor

maddylewis commented Aug 6, 2023

@dangrous - since this is happening on Dev, we will need an engineer to reproduce this one! will you lmk if it's still reproducible whenever you have a sec?

if it is, we can add the External label and go from there 👍

@melvin-bot melvin-bot bot removed the Overdue label Aug 6, 2023
@maddylewis
Copy link
Contributor

heya @isabelastisser - i am OOO until ~Aug 20. I am waiting for a response to my question here - #24112 (comment)

depending on @dangrous's response, we can get the External label added and treat this like any standard bug issue 👍

@dangrous
Copy link
Contributor

dangrous commented Aug 7, 2023

im not able to reproduce on latest main - I asked in Slack if the reporter is still able to reproduce

@dangrous
Copy link
Contributor

dangrous commented Aug 7, 2023

@namhihi237 also cannot reproduce, so we're going to close

@dangrous dangrous closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

8 participants