[PAID] Attachments - Unable to upload pdf file due to "Something went wrong" error

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the testing app in iOS
2. Go to any chat
3. Tap on the + button and select Add attachment
4. Tap on Choose document and select any pdf file

Expected Result:

Preview of the file to be displayed

Actual Result:

Something went wrong screen blocker

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.51.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6157877_RPReplay_Final1691505969.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mkhutornyi]

regression from #20798

[dangrous]

@mkhutornyi is right I think - @Julesssss do you have time to look at this to see if you can figure anything out? I'll keep checking too but looks like you'll be more familiar

[bernhardoj]

Hi, I reported this the day before this issue gets created. Will I get the reporting bonus?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Broaden dependency to prevent PDF upload error #24283

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[Julesssss]

Sorry all I was out for the day at that point.

[Julesssss]

Hi, I reported this the day before this issue gets created. Will I get the reporting bonus?

I think so, it looks like you reported this 1 day earlier.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Broaden dependency to prevent PDF upload error #24283

If no regressions arise, payment will be issued on 2023-08-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter- @bernhardoj - $250 reporting bonus
• Contributor that fixed the issue - N/A
• Contributor+ that helped on the issue and/or PR - @Santhosh-Sellavel - $1000

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dangrous]

@Santhosh-Sellavel I handled the comment, below, since it was pretty internal anyway.

PR: #20798
Comment: https://github.com/Expensify/App/pull/20798/files#r1300649636

Do you want to start the discussion in Slack?

We don't need a regression test because this was already caught by our existing tests.

Then we should be good to pay @bernhardoj for reporting, and @Santhosh-Sellavel for C+ review.

Thanks!

[dangrous]

@Santhosh-Sellavel can you start the Slack discussion for this, and then we can pay and close out? Thanks!

[Santhosh-Sellavel]

Started a discussion here

Can I get a payment summary @mallenexpensify?

[Santhosh-Sellavel]

@dangrous Can you assign a new BZ seems @mallenexpensify is OOO

[mountiny]

@Santhosh-Sellavel could you please double check if this is not re-introduced on main?

[dangrous]

@mountiny do you have a hunch that it is?

[Santhosh-Sellavel]

@mountiny It's working fine on the main!

Screen.Recording.2023-08-30.at.2.35.29.AM.mov

[Santhosh-Sellavel]

@dangrous Can you assign a new BZ seems @mallenexpensify is OOO

bump!

[strepanier03]

I'm going to work on payment for this and will have an update in a little bit.

[strepanier03]

@bernhardoj - I have hired you to a reporting job via Upwork. I'll take another look tomorrow when I log back on.

@Santhosh-Sellavel - I was on sabbatical so missed the manual requests payment going live, I'm still figuring that out but I'll do my best to get it done asap.

[strepanier03]

@Santhosh-Sellavel - Did you already request payment via Newdot? If not, can you do that? That should make a GH for payment for you with manual requests.

[Santhosh-Sellavel]

@strepanier03 Can you add a payment summary comment. So I can request on ND

[bernhardoj]

@strepanier03 accepted, thanks!

[mountiny]

It was just failing on one adhoc build, all good, thanks!

[strepanier03]

@Santhosh-Sellavel - My apologies, I didn't realize that is what you were waiting for. In our SO instructions the request comes before the summary step so we were both waiting on the other.

---

Summarizing payouts for this issue:

Issue reporter: @bernhardoj - Paid $250 via Upwork - Contract ended and feedback left.

Contributor: N/A - internal PR

Contributor+: @Santhosh-Sellavel - $1000 to be paid via Manual Requests.

[strepanier03]

@Santhosh-Sellavel - Once you send the request I'll assign to Jason for payment.

[Santhosh-Sellavel]

Requested on ND

[JmillsExpensify]

Reviewed the details for @Santhosh-Sellavel. $1,000 payment approved via NewDot based on BZ summary.

[strepanier03]

Got, thanks @JmillsExpensify!

I will close this now, but if it needs to be reopened for any reason please comment and @ mention me so I can review.