Deploy Checklist: New Expensify 2023-08-07

[OSBotify]

Release Version: 1.3.51-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Update App to React Native 0.72 version #18507
• Add popovers without overlay #19011
• Remove shouldRetry and canCancel now that deprecatedAPI is gone #19675
• Fix: Find solution to low resolution large images on Android, and the Canvas crash #20798
• Ignore images from embedded html when pasting, paste plaintext instead. #21476
• Add ability to Take/Upload Receipts #23046
• fix: The green line appear immediately only after comments are added to a task #23154
• Fix: Cannot paste magic code on mWeb iOS #23254
• Migrate to functional component #23272
• Fix 22306 web appropriate message is not shown when drag drop a folder #23321
• Disabling spell check on multiple pages #23447
• Create a token manager library for MapBox #23511
• Implement the API changes for getting incremental reconnect updates #23516
• Workspace tooltip #23527
• Migrate TextInputLabel/index.js to a functional component #23547
• Update header subtitle styles for thread (child) reports #23621
• Fix currency changes after refresh although URL has currency params #23636
• Add merchant and date fields to manual requests #23648
• updated regex for legal name and cardholder name #23650
• feat: task view with offline with feedback #23705
• [NoQA] Fix: console warning by making innerRef optional to PressableWithDelayToggle  #23717
• Replace policyIDList with policyIDToLastModified map in Reconnect App call #23748
• Use installation token for OS Botify #23760
• Accept receipt in request money #23770
• Fix: regex execution Maximum regex stack depth reached error #23774
• update composer comment when language changed. #23779
• Web - Loader appears for a second while switch between chats #23781
• Disable go to profile page for optimistic user #23802
• Fix expense report total when deleting requests #23822
• Persist notification cache to internal storage #23825
• Only show settlement button if total is not 0 #23828
• Resolve User Country Identification and Address Form Display Issue #23841
• Convert Date Picker to Functional Component #23880
• migration from class to functional component #23911
• Fix/23818 - Polish admins-only policy room - Clear "Form's" states correctly #23919
• fix: 22507 Blank Page Displayed when Copying and Pasting URL next to Original URL and Reloading with Enter Key #23931
• Migrate BaseReportActionContextMenu.js to fc component. #23934
• Fix crash on opening money request page after sign ing #23937
• Fix Tasks assigned disappears from LHN when leaving the chat in focus mode #23938
• migrated TextInputLabel/index.native.js to functional component #23941
• fix: 22736 sign in here redirected to lhn after login successfully #23944
• Persist failed personal details when adding workspace member #23947
• Update frequently used emojis in state whenever its onyx key changes #23965
• Update Task Permissions #23971
• Prevent link opening on click outside Link #23972
• Fix cursor on pdf view web #23976
• Fix crash app when opening split bill detail page by deep link #23977
• Refactor/23149 money request page #23979
• New group can't search an email if it's a substring of a selected email #23982
• Fix incorrect user display name tooltip position in money request confirmation page #23990
• Fix: Composer top padding collapsed in room after scroll up #23992
• 23593 secondary contact method transition #24002
• Fix: Form validation runs on blur in New task details page #24011
• Fix popover menu position for three dots menu and settlement button #24013
• Task Share Destination Fixes #24019
• Fix: resetting the country/state picker when it is reopened #24023
• Fix - Login field is focused when sign out in small screen devices #24026
• Paste as plain text #24029
• Fix: update AttachmentModal translation #24035
• Fix wrong lottie animations names #24036
• [Improvement] Introduce label props to statePicker & stateSelectorModal #24037
• Fix link preview size #24052
• Fix: Web/Desktop - On back button press navigates to Confirm task screen instead of hide modal #24055
• Fix memoization of ReportActionItem #24057
• Revert "Use installation token for OS Botify" #24060
• [NoQA] Refactored ValidationUtils files with date-fns. #24061
• Update cursor for deleted members in offline mode #24065
• [NO-QA] Add core-js polyfill for pdfjs to support older Chrome & Safari versions #24068
• [No QA] Log when notifications are received and processed in the background #24072
• Migrated Textinput/index.js to functional component #24076
• [CP Staging] Fix user cannot open detail page of chat room #24091
• Fix - Tooltip show email instead of display name when hover in remaining users avatar in a group #24094
• [23355] Offline deleted workspace could be accessed from admins room. #24096
• MoneyRequest: use ScreenWrapper only if editing #24097
• Adjust statepicker margin on debit card page #24099
• [CP Staging] Make sure medium avatar size gets medium container size #24109
• Add checklist item for deeplinks #24115
• fix no scroll bar in several pages #24116
• Fix Podfile.lock Cocoapods version #24130
• fix: extend phone number validation to handle additional '+' characters #24133
• fix: Wrong position of emoji picker modal #24135
• fix button "Message with" style #24142
• [CP Staging] Use legacy web implementation of Gesture Handler #24152
• Clear account messages on contact verify page mount #24171
• Fix: No margin between composer box and whisper message #24179
• fix: broken attachments and avatar picker #24184
• [Cp Staging] Fix issues with send button on iOS #24203

Deploy Blockers:

• Chat - If editing a multiline message cursor appeared on the first line, not at the end #24234
• [HOLD for payment 2023-08-17] BUG: iOS simulator crashes on sign in #24239
• [HOLD for payment 2023-09-04] [$1000] Chat - Pressing CMD+K when Global create is open closes the menu and doesn’t open search #24256
• [HOLD for payment 2023-09-29] [$2000] Web - user not able to save last enable date of birth #24266
• [HOLD for payment 2023-08-17] [$1000] [HOLD for payment 2023-08-16] The total requested amount does not update until the IOU is clicked on or the page is refreshed #24267
• [PAID] Attachments - Unable to upload pdf file due to "Something went wrong" error #24275
• [$1000] Web-Workspace-App does nothing on clicking on 3 dots when modal is open (modal closes for phone) #24284
• Web - Workspace - "More" tooltip is displayed when hovering over the three dots after clicking on them #24300

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.51-0 🚀

[mvtglobally]

@Puneet-here Checking off the following PRs as they were deployed in the previous builds (for reference #24030)

#18507
#23046
#23272
#23321
#23447
#23527
#23621
#23636
#23648
#23650
#23705
#23748
#23760
#23774
#23779
#23781
#23802
#23828
#23880
#23911
#23919
#23931
#23934
#23937
#23938
#23947
#23965
#23971
#23972
#23976
#23977
#23990
#24023
#24035
#24036
#24037
#24052
#24060
#24091
#24097
#24109
#24152
#24203

[amyevans]

Checked off #24130

[puneetlath]

Checking off #24256 as it doesn't need to be treated as a deploy blocker as confirmed by @Beamanator here.

[puneetlath]

Checking off #24234 as it's not a blocker as confirmed by @bondydaa here.

[puneetlath]

Checking off #24266 as I don't think it's a blocker as explained here.

[puneetlath]

Checking off #24239 as confirmed by @neil-marcellini here.

[puneetlath]

Checking off #24284 as explained here.

[mvtglobally]

@puneetlath Regression sis at last 2%.

Current summary
#23516 (comment) checked off
#23822 is failing with #24241
#23825 pending validation on all platforms
#24029 is failing #23567, repro in prod
#24068 we are having issue testing older OS/versions. Can you check this internally?

[puneetlath]

Checking off #24275 as the fix was CP'd and confirmed to be working here.

[mvtglobally]

Have 1 more potential blocker coming up.. Will post in a few

[puneetlath]

Checking off #24267 as the fix was CP'd and confirmed to be working here.

[mvtglobally]

@puneetlath Regression is completed

Final update

• Fix expense report total when deleting requests #23822 is failing with Total request money wrong after delete a request #24241
• Persist notification cache to internal storage #23825 Team is stuck with the notifications a bit. If you can try this one on Android internally, would help a lot.
• Paste as plain text #24029 is failing [HOLD for payment 2023-08-16] [$1000] Desktop - Chat - “Paste as plain text” isn't present on command in the context menu #23567, repro in prod checking off
• [NO-QA] Add core-js polyfill for pdfjs to support older Chrome & Safari versions #24068 we are having issue testing older OS/versions. Can you check this internally?

[mvtglobally]

New potential blocker is #24300. check if its not a new functionality
cc: @aimane-chnaif since you pointed few similar non issues before as well

[mvtglobally]

checking off #23825

[puneetlath]

Checking off #23822. I just tested on staging and it seems to work for me.

[puneetlath]

Checking off #24029 as I just tested and I am seeing the paste as plain text option on staging desktop.

[puneetlath]

Checking off #24300 as I don't think it needs to block the deploy.

[aimane-chnaif]

New potential blocker is #24300. check if its not a new functionality cc: @aimane-chnaif since you pointed few similar non issues before as well

Sorry for late. yes, it's dupe of #24296

[mvtglobally]

@puneetlath another potential blocker. but I feel it is the same root cause #24296 https://expensify.slack.com/archives/C049HHMV9SM/p1691553360267479

[Julesssss]

Checking off #24068 as it should have been marked NO QA.

[Julesssss]

Thanks @mvtglobally, that issue is a follow-up issue from another PR so shouldn't be a blocker 👍

[Julesssss]

• Crashlytics:
  • New non-fatal pdf JS error, fixed here
  • Equivalent PDF issue on iOS, fixed here
  • Other issues are minor non-fatal (possible dev bugs), or existed in previous releases
• Github Status: All Systems Operational
• App timing: Nominal

[Julesssss]

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[Julesssss]

Forgot to checkoff the deployer verifications checkboxes

[Julesssss]