fix: broken attachments and avatar picker #24184

allroundexperts · 2023-08-06T01:40:07Z

Details

This PR fixes the attachment picker which was not opening on iOS. Apart from that, it also fixes the following two bug reports:
#24183
https://expensify.slack.com/archives/C049HHMV9SM/p1691182214043129

Fixed Issues

$ #15289
PROPOSAL: #15289 (comment)

Tests

Go to any chat and select an image as a attachment.
Verify that the image preview shows up after selection.
Go to any workspace -> Settings.
Verify that the avatar can be changed.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Go to any chat and select an image as a attachment.
Verify that the image preview shows up after selection.
Go to any workspace -> Settings.
Verify that the avatar can be changed.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-06.at.5.28.59.AM.mov

Screen.Recording.2023-08-06.at.6.27.15.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-06.at.5.33.29.AM.mov

Mobile Web - Safari

Screen.Recording.2023-08-06.at.5.32.36.AM.mov

Desktop

Screen.Recording.2023-08-06.at.5.30.55.AM.mov

iOS

Screen.Recording.2023-08-06.at.6.26.31.AM.mov

Android

Screen.Recording.2023-08-06.at.5.34.39.AM.mov

melvin-bot · 2023-08-06T01:40:12Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fix: more lint errors

aimane-chnaif · 2023-08-06T22:24:28Z

src/components/AvatarWithImagePicker.js

+                                accessibilityRole={CONST.ACCESSIBILITY_ROLE.IMAGEBUTTON}
+                                accessibilityLabel={this.props.translate('avatarWithImagePicker.editImage')}
+                                disabled={this.state.isAvatarCropModalOpen}
+                                ref={this.anchorRef}


why ref set here? And why this view hierarchy is changed?

Its because we need to close the popover once clicked on the anchor. Previously, the anchor was enclosing the popover menu itself as well which was causing the issue as mentioned in Slack. We need to separate the anchor and the popover menu.

src/pages/home/report/ReportActionCompose.js

Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>

aimane-chnaif · 2023-08-06T23:13:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

chrome

web-chrome.mov

safari

web-safari.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif

Looks good!
cc: @dangrous for expedited review

dangrous

Looks good! I am unable to repro the Workspace image bug, so I'm trusting you on that.

One very minor update, about a comment

dangrous · 2023-08-07T13:54:50Z

src/pages/home/report/ReportActionCompose.js

-                                                        // by the user.
-                                                        if (index === menuItems.length - 1) {
-                                                            // Set a flag to block suggestion calculation until we're finished using the file picker,
-                                                            // which will stop any flickering as the file picker opens on non-native devices.


One minor update - can we copy this comment over to new L1045 so we keep the note?

bump @allroundexperts

@aimane-chnaif @dangrous Handled.

OSBotify · 2023-08-07T16:34:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-07T18:54:16Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T08:43:24Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:12:20Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:51:03Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-10T20:09:29Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts · 2023-08-13T20:35:10Z

@dangrous Reporting bonus for https://expensify.slack.com/archives/C049HHMV9SM/p1691182214043129 is due to @Natnael-Guchima.

fix: broken attachments and avatar picker

0011414

allroundexperts requested a review from a team as a code owner August 6, 2023 01:40

melvin-bot bot requested review from aimane-chnaif and removed request for a team August 6, 2023 01:40

allroundexperts added 2 commits August 6, 2023 06:43

fix: lint errors

113b6fd

fix: more lint errors

134e7ca

fix: more lint errors

allroundexperts force-pushed the fix-24183 branch from 3ff7184 to 134e7ca Compare August 6, 2023 01:56

aimane-chnaif reviewed Aug 6, 2023

View reviewed changes

Update src/pages/home/report/ReportActionCompose.js

a791043

Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>

aimane-chnaif approved these changes Aug 6, 2023

View reviewed changes

melvin-bot bot requested a review from dangrous August 6, 2023 23:15

fix: increase precedence of keyboard listener

4a38b11

0xmiros mentioned this pull request Aug 7, 2023

Migrate ReportActionCompose to function #18648

Merged

56 tasks

ntdiary mentioned this pull request Aug 7, 2023

fix keyboard flashing while clicking "Add attachment" #23994

Merged

58 tasks

dangrous requested changes Aug 7, 2023

View reviewed changes

fix: move comment

42bf664

allroundexperts requested a review from dangrous August 7, 2023 16:11

dangrous approved these changes Aug 7, 2023

View reviewed changes

dangrous merged commit 7b13f11 into Expensify:main Aug 7, 2023

OSBotify mentioned this pull request Aug 7, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

OSBotify mentioned this pull request Aug 9, 2023

Deploy Checklist: New Expensify 2023-08-09 #24307

Closed

87 tasks

melvin-bot bot mentioned this pull request Aug 9, 2023

[$8000] Context menu does not close when secondary menu opens or secondary menu should not open #15289

Closed

1 task

dangrous mentioned this pull request Aug 14, 2023

Issue to Provide Reporting Bonus for Pull/24184 #24538

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: broken attachments and avatar picker #24184

fix: broken attachments and avatar picker #24184

allroundexperts commented Aug 6, 2023

melvin-bot bot commented Aug 6, 2023

aimane-chnaif Aug 6, 2023

allroundexperts Aug 6, 2023

aimane-chnaif commented Aug 6, 2023

aimane-chnaif left a comment

dangrous left a comment

dangrous Aug 7, 2023

aimane-chnaif Aug 7, 2023

allroundexperts Aug 7, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 9, 2023

OSBotify commented Aug 9, 2023

OSBotify commented Aug 9, 2023

OSBotify commented Aug 10, 2023

allroundexperts commented Aug 13, 2023

fix: broken attachments and avatar picker #24184

fix: broken attachments and avatar picker #24184

Conversation

allroundexperts commented Aug 6, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 6, 2023

aimane-chnaif Aug 6, 2023

Choose a reason for hiding this comment

allroundexperts Aug 6, 2023

Choose a reason for hiding this comment

aimane-chnaif commented Aug 6, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

dangrous left a comment

Choose a reason for hiding this comment

dangrous Aug 7, 2023

Choose a reason for hiding this comment

aimane-chnaif Aug 7, 2023

Choose a reason for hiding this comment

allroundexperts Aug 7, 2023

Choose a reason for hiding this comment

OSBotify commented Aug 7, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 9, 2023

OSBotify commented Aug 9, 2023

OSBotify commented Aug 9, 2023

OSBotify commented Aug 10, 2023

allroundexperts commented Aug 13, 2023