Deploy Checklist: New Expensify 2023-08-09

[OSBotify]

Release Version: 1.3.52-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add popovers without overlay #19011
• Remove shouldRetry and canCancel now that deprecatedAPI is gone #19675
• Fix: Find solution to low resolution large images on Android, and the Canvas crash #20798
• Ignore images from embedded html when pasting, paste plaintext instead. #21476
• Fix invited members does not reflect in offline mode #22410
• Fix freezes when previewing a large PDF file #22760
• Display both names for IOU Report Previews #23043
• Add an option for distance requests #23048
• fix: The green line appear immediately only after comments are added to a task #23154
• Fix: Cannot paste magic code on mWeb iOS #23254
• Onyx Migration for checkPreviousReportActionID #23457
• Create a token manager library for MapBox #23511
• Implement the API changes for getting incremental reconnect updates #23516
• Fix: cannot change assignee after task created #23530
• Migrate TextInputLabel/index.js to a functional component #23547
• Optimistic custom unit IDs #23600
• Show comment/requests in report preview #23651
• [NoQA] Fix: console warning by making innerRef optional to PressableWithDelayToggle  #23717
• Accept receipt in request money #23770
• Fix infinite loading in Flag page in offline #23775
• Fix expense report total when deleting requests #23822
• Persist notification cache to internal storage #23825
• Resolve User Country Identification and Address Form Display Issue #23841
• fix: 23369 back button navigation fixed for ondify steps #23864
• migrated TextInputLabel/index.native.js to functional component #23941
• fix: 22736 sign in here redirected to lhn after login successfully #23944
• Refactor/23149 money request page #23979
• New group can't search an email if it's a substring of a selected email #23982
• Fix: Composer top padding collapsed in room after scroll up #23992
• 23593 secondary contact method transition #24002
• Fix: Form validation runs on blur in New task details page #24011
• Fix popover menu position for three dots menu and settlement button #24013
• Remove dead code #24014
• Task Share Destination Fixes #24019
• Fix: Popover reaction list does not update dynamically #24024
• Fix - Login field is focused when sign out in small screen devices #24026
• Paste as plain text #24029
• Fix: Web/Desktop - On back button press navigates to Confirm task screen instead of hide modal #24055
• Fix memoization of ReportActionItem #24057
• [NoQA] Refactored ValidationUtils files with date-fns. #24061
• Update cursor for deleted members in offline mode #24065
• [NO-QA] Add core-js polyfill for pdfjs to support older Chrome & Safari versions #24068
• [No QA] Log when notifications are received and processed in the background #24072
• Migrated Textinput/index.js to functional component #24076
• Refactor/16140 migrate deeplinkwrapper to function #24090
• [CP Staging] Fix user cannot open detail page of chat room #24091
• Fix - Tooltip show email instead of display name when hover in remaining users avatar in a group #24094
• [23355] Offline deleted workspace could be accessed from admins room. #24096
• Adjust statepicker margin on debit card page #24099
• Fix: iOS/iPad - Chat - Message “User is typing” is not showing #24108
• fix: update parent action for assignee report as well #24110
• Add checklist item for deeplinks #24115
• fix no scroll bar in several pages #24116
• [Snyk] Security upgrade electron from 25.2.0 to 25.4.0 #24119
• Fix Podfile.lock Cocoapods version #24130
• fix: extend phone number validation to handle additional '+' characters #24133
• fix: Wrong position of emoji picker modal #24135
• Updated country and state searches to fix extra spaces + support searching with/without non alphabet chars in country name #24140
• fix button "Message with" style #24142
• fix: state field not clear after selecting another country #24148
• fix: don't mark completed task as archive report  #24150
• [CP Staging] Use legacy web implementation of Gesture Handler #24152
• Clear account messages on contact verify page mount #24171
• Fix: No margin between composer box and whisper message #24179
• fix: broken attachments and avatar picker #24184
• fix: console errors due to faulty prop type #24185
• [NO QA] snyk commit for 22462 #24186
• [Cp Staging] Fix issues with send button on iOS #24203
• Fix red dot is not cleared after close add message error and revert last message when the add message fails #24213
• hide mark ask unread with read message #24221
• fix: format phone number #24227
• fix task message on LHN if task is created after sending an attachment #24233
• Revert "Remove shouldRetry and canCancel now that deprecatedAPI is gone" #24240
• Fix spanish copy in a few places #24268
• fix total requested money amount does not update when delete money request #24279
• Broaden dependency to prevent PDF upload error #24283

Deploy Blockers:

• [hold for payment 2023-08-17] PDF blinks while open the PDF #24311
• Chat - No tooltip when hovering over requester's name in IOU report preview #24323
• Attachments - User can not scroll the PDF by using the down/up arrow in Keyboard #24326
• [$1000] Attachments- App crashes when user navigate attachments #24337
• Request money - When switching between manual input and distance, the scan option flashes #24338
• Assign Task- When user tap share somewhere, all activities with last message are shown #24340
• [HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] BA - iOS App crashes if user tap ‘Back’ on the Onfido start screen Offline #24343
• IOU - Comment in IOU report preview does not update after deleting money request #24365

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.52-1 🚀

[puneetlath]

Checking off #24311. The fix was CP'd to staging and tests well.

[hayata-suenaga]

checking off #24323 per this comment

[mvtglobally]

@puneetlath Checking off the following PRs as they were deployed in the previous builds (for reference #24030)

#19011
#19675
#20798
#21476
#23154
#23254
#23511
#23516
#23547
#23770
#23822
#23825
#23841
#23941
#23944
#23979
#23982
#23992
#24002
#24011
#24013
#24019
#24026
#24029
#24055
#24057
#24065
#24076
#24091
#24094
#24096
#24099
#24115
#24116
#24130
#24133
#24135
#24142
#24152
#24171
#24179
#24184
#24203
#24279
#24283

[mvtglobally]

@puneetlath https://expensify.slack.com/archives/C049HHMV9SM/p1691596627549079 just a reference on potential deploy blocker

[puneetlath]

Checking off #24340 as explained here.

[mvtglobally]

Checking off #23457 (comment)

[mvtglobally]

@puneetlath We have 30% to go.

Current summary

#23530 Pending validation on all platforms
#24150 Pending validation on all platforms
#24213 Pending validation on all platforms
#24221 was rolled back, ok to check off?
#24227 Pending validation on all platforms
#24233 Pending validation on all platforms
#24268 Pending validation on all platforms

[mvtglobally]

@puneetlath We have 2% to go.

PR summary
#24221 was rolled back, ok to check off?

[puneetlath]

#24221 was rolled back, ok to check off?

Yes, sounds good.

[puneetlath]

Checking off #24338 because it's not a bug as described here.

[puneetlath]

Checking off #24365 because it's not a bug as described here.

[mvtglobally]

@puneetlath Regression is Completed

[Li357]

Checking off #24337 since multiple people cannot reproduce

[puneetlath]

Checking off #24343 because the fix has been CP'd and @tgolen confirmed it is working.

[puneetlath]

Checking off #24326 because the fix has been CP'd and I confirmed it's working on staging.

[mvtglobally]

@puneetlath just got a new blocker request. give me few min to check https://expensify.slack.com/archives/C049HHMV9SM/p1691692716326279

[puneetlath]

We decided that wasn't a blocker in the thread, so I'm going to go ahead and kick off the deploy.

[puneetlath]