Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - No tooltip when hovering over requester's name in IOU report preview #24323

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 9, 2023 · 10 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #23043

Action Performed:

  1. Launch New Expensify desktop app
  2. Perform a money request in the workspace chat
  3. Hover over workspace name and requester's name

Expected Result:

The tooltip will be displayed for workspace name and requester's name when hovering over either of them

Actual Result:

The tooltip only appears for workspace name, and it appears over the requester's name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.52.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6159045_20230809_222954.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Aug 9, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Aug 9, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@hayata-suenaga
Copy link
Contributor

@lanitochka17 thank you for reporting the bug

In the video, I don't see where you're hovering over the workspace name

Is the workspace name "Better have my money"? If so, I see the tooltip appears on hover on that name.

Maybe, can you also attach a video showing expected behavior on production?

@aimane-chnaif
Copy link
Contributor

This is not a blocker. Context - #23043 (comment)

@hayata-suenaga hayata-suenaga added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 9, 2023
@hayata-suenaga hayata-suenaga removed their assignment Aug 9, 2023
@hayata-suenaga hayata-suenaga added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@hayata-suenaga
Copy link
Contributor

thank you for confirming that. removing blocker label and unassigning myself

@MitchExpensify

There is a suggestion that we should review the usage of tooltip in App here in this PR that caused this blocker PR to be created. (same link as aimane-chnaif linked here).

I don't have much context on the use of tooltips on our product, but raised a question on how strictly we want to be in triaging tooltip issues for now if we're planning to review the usage of tooltips down the line.

@lanitochka17
Copy link
Author

The tooltip is not displayed for the name of the requester.

Recording.2887.mp4

@hayata-suenaga
Copy link
Contributor

ah I see thank you for clarification 🙇

@MitchExpensify I asked if we want to triage these kinds of tooltip issues now that we're thinking removing most of the tooltips (internal link)

@hayata-suenaga
Copy link
Contributor

per this comment (internal), closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants