IOU - Comment in IOU report preview does not update after deleting money request

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #23043

Action Performed:

1. Go to staging.new.expensify.com
2. Request money two times from a user with no conversation history
3. Click on the IOU report preview
4. Delete one of the requests
5. Return to IOU report preview

Expected Result:

The comment in IOU report preview will update

Actual Result:

The comment in IOU report preview updates and reverts to '2 requests'

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.52.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @tewodrosGirmaA

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691168685718989

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d88723e84c14ed1f
• Upwork Job ID: 1689633879427391488
• Last Price Increase: 2023-08-10

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d88723e84c14ed1f

[Julesssss]

Not a blocker, this is just a follow-up issue to Manual Requests that we need to implement.

[joekaufmanexpensify]

@Julesssss If this is a follow up to manual requests, should it have new feature label, rather than bug?

[Nathan-Mulugeta]

Hey guys, I reported this issue over on slack here.

[Julesssss]

I updated the reporter section

[Nathan-Mulugeta]

Thanks Jules.

[mvtglobally]

Potentially related to #24241

[joekaufmanexpensify]

Interesting. @Julesssss / @narefyev91 curious if you think the above bug is related to this one?

[Julesssss]

@joekaufmanexpensify this is weeks or months away. As I have so many bugs and more important tasks assigned.

[melvin-bot]

@Julesssss @narefyev91 @joekaufmanexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[joekaufmanexpensify]

Moving back to weekly, as doesn't sound like @Julesssss can prioritize this atm.

[joekaufmanexpensify]

Same

[joekaufmanexpensify]

Same

[joekaufmanexpensify]

Same.

[joekaufmanexpensify]

Pending internal prioritization

[joekaufmanexpensify]

Same

[joekaufmanexpensify]

Same.

[joekaufmanexpensify]

Same

[joekaufmanexpensify]

Same

[joekaufmanexpensify]

@Julesssss do you think you'll be able to raise the fix for this one anytime soon?

[Julesssss]

Sorry but no. All engineers are super busy with wave issues so I doubt this will be prioritized this year. Maybe we could get it looked at as a first pick, but we'd have to be pretty lucky.

[joekaufmanexpensify]

Okay, all good. I will make it a monthly for now then!

[Julesssss]

Hey @joekaufmanexpensify, I just retested this bug and I don't think it is occurring anymore 🎉

I see an updated preview. Would you mind verifying?

[joekaufmanexpensify]

Sure, I'll take a look now!

[joekaufmanexpensify]

Yep, this is fixed for me as well. Closing as no action needed in this issue!

[tewodrosGirmaA]

Hello @Julesssss and @joekaufmanexpensify, may I inquire about my eligibility for payment? The reported bug has been confirmed as valid and subsequently fixed by our engineer. Initially, it was a deploy blocker in the first stage.

[joekaufmanexpensify]

@tewodrosGirmaA My initial thought is I don't think any payment is due here. We did not fix anything in this issue. Generally the way we approach situations like this is you'd need to find the PR that fixed this to show that your report came first in order for this to qualify for payment.

If this was reported before whatever caused us to change this product behavior, LMK and I'll take another look!