Persist failed personal details when adding workspace member #23947

NikkiWines · 2023-07-31T18:53:35Z

cc: @Beamanator since we discussed this in slack

Details

Dedupes some logic due to two groups working in the same code at the same time. Persists personalDetails in onyxData in the event that the API call fails.

Two PRs (#23157 and #22904) were modifying the same code at roughly the same time. #22904 was merged first and #23157 was then merged without pulling main - so the code was duplicated and the intended behavior was slightly conflicting.

Additionally, #22904 introduced logic that removed the optimistically added personal details if the API call failed, which is the opposite of what we wanted in #23157 as those personal details are manually removed when the user addresses the error from the RBR 😅

We are still using part of the logic from #23157

Fixed Issues

$ #22359
PROPOSAL: N/A internal

Tests

Login with any account
Go to Settings >> Workspaces >> Members >> Invite
Invite an invalid or not existing account (+916541237890 for example)
Verify that the workspace members page shows a RBR under the invited account
Verify that the RBR is dismissible

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Login with any account
Go to Settings >> Workspaces >> Members >> Invite
Invite an invalid or not existing account (+916541237890 for example)
Verify that the workspace members page shows a RBR under the invited account
Verify that the RBR is dismissible

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-31.at.11.58.26.mov

Mobile Web - Chrome

Simulator.Screen.Recording.-.iPhone.14.-.2023-07-31.at.12.09.19.mp4

Mobile Web - Safari

Screen.Recording.2023-07-31.at.12.11.55.mov

Desktop

Screen.Recording.2023-07-31.at.12.02.13.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.-.2023-07-31.at.12.06.56.mp4

Android

Screen.Recording.2023-07-31.at.12.43.40.mov

melvin-bot · 2023-07-31T18:53:40Z

@eVoloshchak @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…iled-personalDetails

Beamanator · 2023-07-31T18:55:32Z

src/libs/PersonalDetailsUtils.js

@@ -123,7 +123,6 @@ function getNewPersonalDetailsOnyxData(logins, accountIDs) {
             * This is done to prevent duplicate entries (upon success) since the BE will return other personal details with the correct account IDs.
             */
            successData[accountID] = null;
-            failureData[accountID] = null;


I wonder why we did this here... even the comment say we want to prevent dupes on success

Yeah, it's a bit odd

NikkiWines · 2023-08-01T17:45:15Z

@eVoloshchak friendly bump here 🙇

eVoloshchak · 2023-08-02T11:15:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-02.at.14.31.43.mov

Mobile Web - Chrome

screen-20230802-143324.mp4

Mobile Web - Safari

Screen.Recording.2023-08-02.at.14.39.04.mov

Desktop

Screen.Recording.2023-08-02.at.14.39.48.mov

iOS

Screen.Recording.2023-08-02.at.14.38.10.mov

Android

screen-20230802-145456.mp4

eVoloshchak

Tests well
@NikkiWines, thank you for untangling this!
I'll make sure to double-check if PR's are working after being merged, I should have caught this

melvin-bot · 2023-08-02T12:02:32Z

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2023-08-02T12:13:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-03T17:42:16Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:30:36Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:57:49Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T08:46:57Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

NikkiWines added 2 commits July 31, 2023 11:46

dedupe optimistic data for newly added workspace members

7f8f344

persist optimsitic data if call fails

6fcf5ce

NikkiWines requested a review from Beamanator July 31, 2023 18:53

NikkiWines requested a review from a team as a code owner July 31, 2023 18:53

NikkiWines self-assigned this Jul 31, 2023

melvin-bot bot requested review from eVoloshchak and removed request for a team July 31, 2023 18:53

Merge branch 'main' of github.com:Expensify/App into nikki-persist-fa…

3051424

…iled-personalDetails

Beamanator reviewed Jul 31, 2023

View reviewed changes

remove unused imports

ffab916

eVoloshchak approved these changes Aug 2, 2023

View reviewed changes

melvin-bot bot requested a review from dangrous August 2, 2023 12:02

Beamanator approved these changes Aug 2, 2023

View reviewed changes

Beamanator merged commit de691a9 into main Aug 2, 2023

Beamanator deleted the nikki-persist-failed-personalDetails branch August 2, 2023 12:09

OSBotify mentioned this pull request Aug 3, 2023

Deploy Checklist: New Expensify 2023-08-03 #24121

Closed

86 tasks

melvin-bot bot mentioned this pull request Aug 7, 2023

[HOLD for payment 2023-08-14] [HOLD for payment 2023-08-07] [$1000] Invite Member - No way to remove RBR from avatar after inviting an invalid number into a workspace #22359

Closed

6 tasks

OSBotify mentioned this pull request Aug 7, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

mollfpr mentioned this pull request Aug 30, 2023

[HOLD for payment 2023-09-27] [$1000] After deleting a mobile contact from a WorkSpace, it starts showing up in contacts as @expensify.sms #26121

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Persist failed personal details when adding workspace member #23947

Persist failed personal details when adding workspace member #23947

NikkiWines commented Jul 31, 2023 •

edited

Loading

melvin-bot bot commented Jul 31, 2023

Beamanator Jul 31, 2023

NikkiWines Jul 31, 2023

NikkiWines commented Aug 1, 2023

eVoloshchak commented Aug 2, 2023 •

edited

Loading

eVoloshchak left a comment

melvin-bot bot commented Aug 2, 2023

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 9, 2023

Persist failed personal details when adding workspace member #23947

Persist failed personal details when adding workspace member #23947

Conversation

NikkiWines commented Jul 31, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 31, 2023

Beamanator Jul 31, 2023

Choose a reason for hiding this comment

NikkiWines Jul 31, 2023

Choose a reason for hiding this comment

NikkiWines commented Aug 1, 2023

eVoloshchak commented Aug 2, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 2, 2023

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 7, 2023

OSBotify commented Aug 9, 2023

NikkiWines commented Jul 31, 2023 •

edited

Loading

eVoloshchak commented Aug 2, 2023 •

edited

Loading