[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$1000] Web - Request money - Request confirmation link automatically changes request money currency to USD

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Precondition: Your default currency should not be USD when you click on request money

1. Open the app
2. Click on plus and click on request money
3. Enter any amount and continue, select any user and continue
4. Copy the URL, link should look like: https://staging.new.expensify.com/request/new/confirmation/
5. Logout and paste the URL
6. Login and observe that now currency is changed to USD even though your default currency is different and was not changed during last request

Expected Result:

App should display default currency of user in request money when we open confirmation link on login

Actual Result:

App displays USD as currency in request money when we open confirmation link on login

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.53-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

currency.changes.to.USD.in.confirmation.link.mp4

Recording.1164.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691057407426539

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aad4c8cddaf2f5c5
• Upwork Job ID: 1691154081471135744
• Last Price Increase: 2023-08-21
• Automatic offers:
• tienifr | Contributor | 26271380

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ygshbht]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Upon refreshing the Request Money confirmation link, the displayed currency defaults to USD regardless of the user's set default currency.

What is the root cause of that problem?

The default currency for IOUs is USD. When the user initiates the Request Money flow, the currency is updated based on the currentUserPersonalDetails when the resetMoneyRequestInfo function is invoked. However, when the user refreshes the page, the personal details have not yet been set and the function responsible for updating this, which is triggered by FAB -> Request Money, isn't called. As a result, the app falls back to the default IOU currency, USD.

What changes do you think we should make in order to solve the problem?

Update

1. We need to ensure that IOU.currency is in sync with currentUserPersonalDetails.currency. We can listen to changes in currentUserPersonalDetails.currency and update IOU.currency accordingly if user has logged in the session. So instead of directly getting iou

   App/src/pages/iou/steps/NewRequestAmountPage.js

   Line 200 in fb57c17

   iou: {key: ONYXKEYS.IOU},

   
   we can create a hook withIOU where we listen for such changes and update the iou accordingly

2. UseEffect Approach: In the NewRequestAmountPage, use a useEffect hook to call resetMoneyRequestInfo or only update currency when the component mounts/ currentUserPersonalDetails.currency updates if navigateToNextPage hasn't been called yet and user has signed in in the session. This ensures that even if the page is refreshed, the correct default currency is always displayed.

What alternative solutions did you explore? (Optional)

3. Global Approach: A more global solution would be to invoke the resetMoneyRequestInfo/ currency change function at a higher-level component that mounts when the user logs in and once the currentUserPersonalDetails have been received. This ensures that the default currency is always in sync whenever the user logs in.
4. URL Storage: Store the currency in the URL itself. This means that regardless of any refreshing or subsequent navigation, the currency remains persistent as it's directly encoded in the URL.
   Example URL: https://staging.new.expensify.com/request/new/confirmation/?currency=INR
5. Modify Reset Conditions: Update the shouldReset condition in the NewRequestAmountPage to account for situations where the page might be refreshed, ensuring the correct currency is displayed.
   

   App/src/pages/iou/steps/NewRequestAmountPage.js

   Lines 121 to 123 in fb57c17

   	if (shouldReset) {
   	IOU.resetMoneyRequestInfo(moneyRequestID);
   	}

I'd choose URL storage for IOU urls as the preferred solution as it seems to present no drawbacks while others could due to the way the app is configured

_{Other areas facing this issue, could also use a similar approach}

[sonialiap]

I think we can simplify the reproduction steps a bit:

1. Log into an account and set the currency to something not USD (ex: EUR)
2. Click on the FAB > Request Money
3. Confirm the OUI screen shows the default currency (ex: EUR). Exit IOU set up without saving
4. Click on https://staging.new.expensify.com/request/new/confirmation/
5. Confirm that the OUI screen shows USD instead of your default currency

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aad4c8cddaf2f5c5

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[allroundexperts]

@thesahindia is OOO and will be back on 19th. I can jump in here if needed.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Request money - Request confirmation link automatically changes request money currency to USD

What is the root cause of that problem?

When users click on Request Money or Send Money or Split Bill, we call IOU.startMoneyRequest, in this function we request money request info to local currency. And we don't want to update this value when users refresh page

Unfortunately, in this case after users login successfully, we don't have the login to set currency, so the default currency(USD) is returned

What changes do you think we should make in order to solve the problem?

We should't listen the currentUserPersonalDetails change in NewRequestAmountPage, if we do that we have to do the same thing in other places (MoneyRequestDescriptionPage,...). And the pages have to re-render whenever currentUserPersonalDetails get changed.

That why I suggest we should fix this problem in IOU.js

In this file we already listen currentUserPersonalDetails change, so we just need to init iou currency after users login successfully. We can detect users login by using SessionUtils.didUserLogInDuringSession()

let shouldResetIOUAfterLogin = true; // add this variable

let currentUserPersonalDetails = {};
Onyx.connect({
    key: ONYXKEYS.PERSONAL_DETAILS_LIST,
    callback: (val) => {
        currentUserPersonalDetails = lodashGet(val, userAccountID, {});
        if(val && SessionUtils.didUserLogInDuringSession() && shouldResetIOUAfterLogin){
            resetMoneyRequestInfo();
            shouldResetAfterLogin = false
        }
    },
});

Note: This approach may need some times to load the personalDetails so the $ symbol will be shown for a moment before showing the local currency. We can hide the currency (or showing the skeleton) before loading the local currency. In order to archive that we can set didInitCurrency: true in ONYX.IOU when execute above logic ^

Result

Screen.Recording.2023-08-15.at.12.23.21.mov

[ygshbht]

@tienifr nicely elaborates the third point I mentioned
Global Approach: A more global solution would be to invoke the resetMoneyRequestInfo/ currency change function at a higher-level component that mounts when the user logs in and once the currentUserPersonalDetails have been received. This ensures that the default currency is always in sync whenever the user logs in.

However, the issue with this approach is that we still see the $ for some time after page refresh. We need to combine this approach with the URL approach to provide a more robust solution

2023-08-15.13-00-05.mp4

ygshbht@a653b5f

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[thesahindia]

@allroundexperts, feel free to review the proposals. I am not at my 100%

[allroundexperts]

Thanks for your proposal @ygshbht.
I think your main solution would require us to use the logic in every component as highlighted by @tienifr. The alternate solution you mentioned here I think is too generic and is completely missing the implementation detail.

I don't think your 4th solution would work because a user might not add the currency as a query parameter to the url. In that case, we should default to the users default currency which again would be undefined for some time.

@tienifr Your proposal has all the necessary implementation details. I think we should show a loader until the currency loads.

@tienifr's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[allroundexperts]

@sonialiap Can you please assign this to me as @thesahindia un-assigned themselves?

[ygshbht]

Thanks for your proposal @ygshbht. I think your main solution would require us to use the logic in every component as highlighted by @tienifr. The alternate solution you mentioned here I think is too generic and is completely missing the implementation detail.

I don't think your 4th solution would work because a user might not add the currency as a query parameter to the url. In that case, we should default to the users default currency which again would be undefined for some time.

@tienifr Your proposal has all the necessary implementation details. I think we should show a loader until the currency loads.

@tienifr's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

That's a very wise decision indeed.

I'd like to add some clarifications.

I don't think your 4th solution would work because a user might not add the currency as a query parameter to the url. In that case, we should default to the users default currency which again would be undefined for some time.

User manually editing the URL is not specific to this issue. They can do that for any URL at their own risk. However, if they navigate using the URL provided by the app, they won't face the isssue. We can only fix what's in our control.

I think your main solution would require us to use the logic in every component as highlighted by @tienifr. The alternate solution you mentioned #24393 (comment) I think is too generic and is completely missing the implementation detail.

Yes, it is missing the implementation details. I said we need to "invoke the resetMoneyRequestInfo/ currency change function at a higher-level component that mounts when the user logs in and once the currentUserPersonalDetails have been received" and @tienifr provided the code for it. If @tienifr 's proposal is selected because he focused on one solution and provided the code for it and my other solution of URL editing, even though better for end user, increases code complexity by making changes to several files, the decision won't be wrong indeed.

[allroundexperts]

@ygshbht You don't need to include every tiny detail but at the same time, you shouldn't propose an alternate solution this abstract.

I'd leave the final call to @cristipaval!

[sonialiap]

Thanks!

[sonialiap]

@allroundexperts review, no bonus because of regression = $500 - please request in NewDot
@tienifr fix, no bonus because of regression = $1000 - paid ✔️ should be $500, refund requested
@dhanashree-sawant report = $250 - paid ✔️

[sonialiap]

@allroundexperts please complete the checklist :)

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[sonialiap]

I'm OOO Oct 16-23. Adding leave buddy

Status: waiting for Sibtain to complete the checklist

[allroundexperts]

@sonialiap I think it should be $500 for me and @tienifr. We pay no bonus + 50% penalty for regressions.

[allroundexperts]

Checklist

1. I couldn't find any particular PR which caused this issue. This seemed to have never been thought off when implementing the request money page.
2. N/A
3. https://expensify.slack.com/archives/C049HHMV9SM/p1697574239538219
4. Regression test would be helpful.

Regression test steps

1. Login and make sure that the default currency of the user is other than the USD.
2. Click on plus icon in the LHN and click on request money.
3. Enter any amount and continue, select any user and continue.
4. Copy the URL of the confirmation screen and Logout.
5. Open the copied url and login and verify that the currency that shows up remains the same as the default currency of the user.

Do we 👍 or 👎 ?

[sonialiap]

Back from OOO

Thanks for completing the checklist!

Ah, you're right. I tried looking up regression policy in the SO but either I was looking at an old post or missed this bit. I'll check with the team on what to do in this case since I've already made the payments in Upwork (idk the status of the ND payment).

[sonialiap]

I've submitted a refund request to @tienifr and updated the amounts in comment #24393 (comment)

[sonialiap]

@allroundexperts please make a request in ND for $500

[allroundexperts]

All done @sonialiap!

[JmillsExpensify]

$500 payment approved for @allroundexperts based on comment above.

[melvin-bot]

@anmurali, @sonialiap, @cristipaval, @allroundexperts, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[cristipaval]

Are we good to close this one, @sonialiap?

[sonialiap]

The last remaining step is following up on the refund. But I can sort that out with the issue being closed. Closing

[tienifr]

I've submitted a refund request to @tienifr and updated the amounts in comment #24393 (comment)

@sonialiap I've refunded, thanks!

[sonialiap]

Thanks, @tienifr 🙇