[Awaiting Payment][$1000] DEV: ShareCodeUrl for room doesn't work on Android

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any account, create a new room (make sure you have your local web running.)
2. Go to that room detail => Share code => Click Copy url to clipboard, paste it to your browser and press Enter.
3. Notice that the browser can't load your url.

Expected Result:

Share code url should work with local environment on Android

Actual Result:

Share Code Url doesn't work on Android.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Dev
Reproducible in production?: Dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-08-03.at.15.20.23.mov

Screen.Recording.2023-08-03.at.15.15.30.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691050736969549

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0174a2b1b05a63292e
• Upwork Job ID: 1691467184925638656
• Last Price Increase: 2023-08-15
• Automatic offers:
• hungvu193 | Contributor | 26160152
• hungvu193 | Reporter | 26160155

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal by @hungvu193

Please re-state the problem that we are trying to solve in this issue.

DEV: ShareCodeUrl for room doesn't work on Android.

What is the root cause of that problem?

As we can see the share code url in this issue still had the old port: 8080.
We decided to change the port to 8082 few weeks ago to make Flipper work on mobile, but we forgot also update the default value for port in here and here which caused the issue on mobile.

What changes do you think we should make in order to solve the problem?

We should update the default value of the port to 8082 in here and here

DEV_PORT: process.env.PORT || 8082

// and

const port = process.env.PORT || 8082

We can also add the PORT=8082 to our .env files and use the value from Config.PORT as a default value.

What alternative solutions did you explore? (Optional)

N/A

[garrettmknight]

Asking an engineer to reproduce on dev: https://expensify.slack.com/archives/C03TQ48KC/p1692025561675429

[cristipaval]

yes the old port is still hardcoded in those 2 places and the issue is reproducible
cc'ing @amyevans as I think she worked on changing the port for dev environment.

[garrettmknight]

Thanks for the help @cristipaval

[amyevans]

Agreed with Cristi. It's a straightforward fix, we can open it up to external to knock it out, or I can take it as a Weekly to handle in some downtime, either way!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0174a2b1b05a63292e

[melvin-bot]

Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[garrettmknight]

@burczu if you think @hungvu193's RCA and fix makes sense I think we can go with them for this one.

[burczu]

@garrettmknight yes, I agree - we can go with @hungvu193 fix here.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hungvu193]

@garrettmknight yes, I agree - we can go with @kavimuru fix here.

🎀 👀 🎀 C+ reviewed

Thank you, that's actually proposal from me 😄

[burczu]

@hungvu193 Ahhh, right! I've just noticed it - sorry for my mistake - updated the comment 😉

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[thienlnam]

@burczu Could you please remember to link to the proposal in future approved comments? Thank you!

[burczu]

@thienlnam sure thing!

[melvin-bot]

🎯 ⚡️ Woah @burczu / @hungvu193, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @hungvu193 got assigned: 2023-08-16 17:25:14 Z
• when the PR got merged: 2023-08-17 15:37:35 UTC

On to the next one 🚀

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[garrettmknight]

Looks like this one didn't get triggered for payment - confirmed that the bug is fixed, I'll process payment now.

[garrettmknight]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR:
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[garrettmknight]

Summary of payments for this issue:

• #urgency bonus? Yes
• Reporter: @hungvu193 - $250 paid via Upwork
• Contirbutor: @hungvu193 - $1500 paid via Upwork

Upwork job: https://www.upwork.com/jobs/~0174a2b1b05a63292e

[garrettmknight]

@burczu can you go through the checklist when you get a chance?

[burczu]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@burczu] The PR that introduced the bug has been identified. Link to the PR: Remove port to fix Flipper #21243
• [@burczu] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Remove port to fix Flipper #21243 (comment)
• [@burczu] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not found
• [@burczu] Determine if we should create a regression test for this bug.
• [@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[burczu]

@garrettmknight Regarding this comment: #24505 (comment) - I won't be paid because I'm from Callstack, an experts contributor group.

[garrettmknight]

Oops, good catch! Closing this one out!