[HOLD for payment 2023-08-28] [$1000] Requests are editable after being paid or deleted

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open a chat.

2. Navigate to the "Request Money" section.

3. Input a specific amount and send the request.

4. Open the IOU (I Owe You) details.

5. Send a message

6. Now delete the IOU

7. After deleting click on "Amount" filed

8. Log in to "UserA's" account.

9. Open the chat with "UserB."

10. Navigate to the "Request Money" section.

11. Enter a specific amount and send the request.

12. Click on the IOU to open its detail.

13. Click on the amount field.

14. Open another browser and log in to "UserB's" account.

15. Open the chat with "UserA" and click "Pay elsewhere."

16. Return to "UserA's" account and edit the IOU amount.

Expected Result:

When request is deleted the transaction header should disappear.

When request is paid the transaction header fields should be disabled

Actual Result:

App crashes when clicking on Amount filed after deleting IOU or user can click on edit field on paid requests.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

7095068594568908720screen-recording-2023-08-14-at-112613-pm_seikoqvj.MP4

Recording.1211.mp4

Expensify/Expensify Issue URL:

Issue reported by: @ayazhussain79

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692037499896279

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0152f0c75c34484d87
• Upwork Job ID: 1691453667712995328
• Last Price Increase: 2023-08-15
• Automatic offers:
• Ollyws | Reviewer | 26133365
• dukenv0307 | Contributor | 26133367

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mountiny]

This is a deploy blocker, but I am surprised that the transaction details are there when the request is deleted, we should make the buttons disabled in such case.

[Julesssss]

Personally I don't think this should block the deploy as delete is a new-ish feature and trying to edit the amount of a deleted IOU is not a common flow. But we need to fix it for sure.

[mountiny]

Yeah I would also err on a side of not blocking but fixing with urgency

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deleted request money info still visible in IOU transaction report with comments

What is the root cause of that problem?

The information on the money request still keeps when we delete the money request and we don't check parentReportAction is deleted or not to display the styles accordingly and disable to go to edit page

App/src/components/ReportActionItem/MoneyRequestView.js

Line 43 in dd0d98f

const {amount: transactionAmount, currency: transactionCurrency, comment: transactionDescription} = ReportUtils.getMoneyRequestAction(parentReportAction);

What changes do you think we should make in order to solve the problem?

We should check the parentReportAction is deleted or not to display the styles accordingly

const isDeleted = ReportActionsUtils.isDeletedAction(parentReportAction);

Some suggestions expected for this issue:

1. We can apply a strike-through style for information on money requests and disable if it is deleted

titleStyle={[..., isDeleted && styles.offlineFeedback.deleted]}
disabled={isSettled || isDeleted}

2. We can change all titles with an explanation that is deleted and also disable it

title={formattedTransactionAmount + (isDeleted ? ` ${translate(common.deleted)}`)}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0152f0c75c34484d87

[melvin-bot]

Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

[mountiny]

I can take this one over as I have worked on the feature.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Ollyws]

Will review tomorrow morning (GMT)

[melvin-bot]

🎯 ⚡️ Woah @Ollyws / @dukenv0307, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @dukenv0307 got assigned: 2023-08-15 14:18:44 Z
• when the PR got merged: 2023-08-16 14:52:41 UTC

On to the next one 🚀

[mountiny]

Merged 🎉

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.55-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hide transaction detail and dismiss the edit modal when the request is deleted #24590

If no regressions arise, payment will be issued on 2023-08-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment offer (Reviewer)
• @dukenv0307 requires payment offer (Contributor)
• @ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[maddylewis]

Payments

• Reporting bonus: @ayazhussain79 ($250 - Upwork)
• Contributor: @dukenv0307 ($1500 - Upwork)
• C+: @Ollyws ($1500 - Upwork)

---

eligible for urgency bonus - #24578 (comment)

[maddylewis]

offers sent to @ayazhussain79 / @Ollyws

[ayazhussain79]

@maddylewis offer accepted, Thank you

[maddylewis]

everyone is paid! @Ollyws - will you confirm what needs to be actioned in this checklist? thank ya! #24578 (comment)

[Ollyws]

As this was a temporary fix for a new feature added shortly before in #23703 I don't think the checklist is helpful here. Let me know if you think otherwise.

[melvin-bot]

@Ollyws, @mountiny, @maddylewis, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mountiny]

Everyone paid, closing thanks