[HOLD for payment 2023-10-09] [$500] Update Task Report System Messages and LHN Display for Consistency

[dangrous]

From https://expensify.slack.com/archives/C01GTK53T8Q/p1691602405412179

Currently in group chats the LHN preview when a task is created looks like:

which is confusing with the double colon. We should remove the one before the task title.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01240ad1a87681ff41
• Upwork Job ID: 1692247492479631360
• Last Price Increase: 2023-09-19
• Automatic offers:
• rayane-djouah | Contributor | 26769074

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dangrous]

@kevinksullivan I'm gonna handle this internally, it's very quick (and also requires some backend stuff)

[dangrous]

Confirming expected behavior for the additional task messages (cancelled, completed, reopened). Will go from there.

(also note to self, changes have to be made in the App as well as in Auth)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01240ad1a87681ff41

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[dangrous]

Holding since discussion continues in Slack on where we should fix/adjust things

[dangrous]

Discussion continues, I'll bump

[melvin-bot]

@dangrous, @eVoloshchak, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[dangrous]

Discussion continues in Slack

[dangrous]

Bumping the discussion

[melvin-bot]

@dangrous @eVoloshchak @kevinksullivan this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[dangrous]

Still figuring out a direction in Slack.

[dangrous]

Backend PR is up for review!

One question, I think for @JmillsExpensify - We previously had a (I guess not surfaced in the front end) system message for deleting a task, of "deleted task: " + taskTitle;. I updated that to just deleted, to match marked as complete and marked as incomplete. Does that feel right to you?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update Task Report System Messages and LHN Display for Consistency #27827

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @rayane-djouah requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: this isn't a regression per se, just an update to system messages for tasks
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. N/A

[JmillsExpensify]

Backend PR is up for review!

One question, I think for @JmillsExpensify - We previously had a (I guess not surfaced in the front end) system message for deleting a task, of "deleted task: " + taskTitle;. I updated that to just deleted, to match marked as complete and marked as incomplete. Does that feel right to you?

Missed this, but yeah that feels right.

[JmillsExpensify]

Will get NewDot payments processed as soon as I have a payment summary.

[kevinksullivan]

Payment summary

Contributor: @rayane-djouah $500
C+: @eVoloshchak $500 (in NewDot)

[JmillsExpensify]

$500 payment approved for @eVoloshchak based on BZ symmary.

[rayane-djouah]

Upwork offer already accepted
@kevinksullivan

[rayane-djouah]

Bump @kevinksullivan for processing payment

[kevinksullivan]

all set

[thienlnam]

Since we're updating these system messages we'll need to update the existing regression tests so QA doesn't create issues from these changes - could we make sure that happens before closing this out please? cc @kevinksullivan

[kevinksullivan]

yup, done