Update Task Report System Messages and LHN Display for Consistency #27827

rayane-djouah · 2023-09-20T06:45:45Z

Details

#24601 (comment)

Fixed Issues

$ #24601
PROPOSAL: #24601 (comment)

Tests

Login to any account
Click settings > preferences > force offline
Click floating action button FAB
Click assign task and assign a task to any user and share it in a group or room
In the parent report (group/room) in LHN. Verify that the second line is in the format: task for %taskTitle%
Open the task report
Verify that the task report button in English is: Mark as complete
Mark the task as complete
Verify that the system message is: marked as complete
Mark the task as incomplete
Verify that the system message is: marked as incomplete
Open the assignee DM
in LHN. Verify that the second line is in the format: assigned to %displayName%

Verify that no errors appear in the JS console

Offline tests

Same as above tests.

QA Steps

Same as above tests.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: https://expensify.slack.com/archives/C01GTK53T8Q/p1695389865195429?thread_ts=1691602405.412179&cid=C01GTK53T8Q
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

chrome.mp4

Mobile Web - Safari

safari.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

melvin-bot · 2023-09-22T13:31:58Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-djouah · 2023-09-23T14:14:39Z

@eVoloshchak PR ready for code review

eVoloshchak · 2023-09-24T11:01:00Z

@rayane-djouah, the Screenshots/Videos section isn't populated (only for Web) and the PR Author Checklist isn't fully finished

rayane-djouah · 2023-09-24T12:24:46Z

I will finish it today

eVoloshchak · 2023-09-25T18:24:37Z

@rayane-djouah, friendly bump on the above

…-and-LHN-Display-for-Consistency

rayane-djouah · 2023-09-26T11:39:28Z

@eVoloshchak PR ready for review

eVoloshchak · 2023-09-27T08:14:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-27.at.16.18.30.mov

Mobile Web - Chrome

screen-20230927-163736.mp4

Mobile Web - Safari

RPReplay_Final1695826881.MP4

Desktop

Screen.Recording.2023-09-27.at.16.29.50.mov

iOS

Screen.Recording.2023-09-27.at.16.58.24.mov

Android

screen-20230927-164515.mp4

eVoloshchak · 2023-09-27T08:54:15Z

In the parent report (group/room) in LHN. Verify that the second line is in the format: task for %taskTitle%

@rayane-djouah, I don't see this change when testing, for me it says "Created a task: taskname" in LHN

Notice it also says "Assigned a task to you" in LHN for a chat with the user you've assigned a task to
(both cases are in a video below)

Screen.Recording.2023-09-27.at.10.49.44.mov

src/libs/ReportUtils.js

Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

…isplay-for-Consistency

rayane-djouah · 2023-09-27T10:07:08Z

conflicts resolved

rayane-djouah · 2023-09-27T10:09:27Z

@eVoloshchak this is because backend changes are not done yet (response from backend override the messages), you need to enable force offline in order to test this frontend changes.

eVoloshchak

LGTM

I wonder why tests are failing, doesn't seem to be related to this PR

rayane-djouah · 2023-09-27T15:26:21Z

Tests are failing on main, this is not related to this PR

rayane-djouah · 2023-09-27T15:26:40Z

all yours @dangrous

dangrous · 2023-09-28T04:58:28Z

Merging main should fix those tests now! Will review shortly

…-and-LHN-Display-for-Consistency

rayane-djouah · 2023-09-28T05:29:22Z

all tests are passing now @dangrous

dangrous

Sweet, this looks great! Will merge this, and then I'll tackle the backend to match shortly.

OSBotify · 2023-09-28T19:16:21Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:20:17Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:48:52Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:49:49Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

rayane-djouah added 9 commits September 20, 2023 08:43

Update Task Report System Messages and LHN Display for Consistency

2ad5ec8

fix lint errors

c4b6378

update task messages

c3ba15f

update task messages

cc2e282

update task messages

30609b2

update task messages

c93a961

update task messages

a8eeafd

update task messages

9358bb5

update task messages

b63b77a

rayane-djouah marked this pull request as ready for review September 22, 2023 13:31

rayane-djouah requested a review from a team as a code owner September 22, 2023 13:31

melvin-bot bot requested review from eVoloshchak and removed request for a team September 22, 2023 13:31

Merge branch 'Expensify:main' into Update-Task-Report-System-Messages…

873192c

…-and-LHN-Display-for-Consistency

eVoloshchak suggested changes Sep 27, 2023

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

rayane-djouah and others added 2 commits September 27, 2023 11:04

Update assigned to message

3956c52

Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

Merge branch 'main' into Update-Task-Report-System-Messages-and-LHN-D…

e21370b

…isplay-for-Consistency

rayane-djouah requested a review from eVoloshchak September 27, 2023 10:15

eVoloshchak approved these changes Sep 27, 2023

View reviewed changes

melvin-bot bot requested a review from dangrous September 27, 2023 15:06

Merge branch 'Expensify:main' into Update-Task-Report-System-Messages…

a9f75bd

…-and-LHN-Display-for-Consistency

dangrous approved these changes Sep 28, 2023

View reviewed changes

dangrous merged commit 365cdbd into Expensify:main Sep 28, 2023
13 checks passed

namhihi237 mentioned this pull request Sep 28, 2023

fix last messaage LHN with task action #28112

Closed

59 tasks

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

melvin-bot bot mentioned this pull request Oct 2, 2023

[HOLD for payment 2023-10-09] [$500] Update Task Report System Messages and LHN Display for Consistency #24601

Closed

francoisl mentioned this pull request Oct 4, 2023

[$500] Task - [Deleted task] is not grayed out in task report when the task is deleted offline #28190

Closed

6 tasks

rayane-djouah deleted the Update-Task-Report-System-Messages-and-LHN-Display-for-Consistency branch November 29, 2023 16:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Task Report System Messages and LHN Display for Consistency #27827

Update Task Report System Messages and LHN Display for Consistency #27827

rayane-djouah commented Sep 20, 2023 •

edited

Loading

melvin-bot bot commented Sep 22, 2023

rayane-djouah commented Sep 23, 2023

eVoloshchak commented Sep 24, 2023

rayane-djouah commented Sep 24, 2023

eVoloshchak commented Sep 25, 2023

rayane-djouah commented Sep 26, 2023

eVoloshchak commented Sep 27, 2023 •

edited

Loading

eVoloshchak commented Sep 27, 2023

rayane-djouah commented Sep 27, 2023

rayane-djouah commented Sep 27, 2023

eVoloshchak left a comment

rayane-djouah commented Sep 27, 2023

rayane-djouah commented Sep 27, 2023

dangrous commented Sep 28, 2023

rayane-djouah commented Sep 28, 2023 •

edited

Loading

dangrous left a comment

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

Update Task Report System Messages and LHN Display for Consistency #27827

Update Task Report System Messages and LHN Display for Consistency #27827

Conversation

rayane-djouah commented Sep 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 22, 2023

rayane-djouah commented Sep 23, 2023

eVoloshchak commented Sep 24, 2023

rayane-djouah commented Sep 24, 2023

eVoloshchak commented Sep 25, 2023

rayane-djouah commented Sep 26, 2023

eVoloshchak commented Sep 27, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak commented Sep 27, 2023

rayane-djouah commented Sep 27, 2023

rayane-djouah commented Sep 27, 2023

eVoloshchak left a comment

Choose a reason for hiding this comment

rayane-djouah commented Sep 27, 2023

rayane-djouah commented Sep 27, 2023

dangrous commented Sep 28, 2023

rayane-djouah commented Sep 28, 2023 • edited Loading

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

rayane-djouah commented Sep 20, 2023 •

edited

Loading

eVoloshchak commented Sep 27, 2023 •

edited

Loading

rayane-djouah commented Sep 28, 2023 •

edited

Loading