Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-12] [TS migration] Migrate 'compose.js' lib to TypeScript #24788

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 19 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/compose.js 1
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label Sep 11, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Sep 26, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 2, 2023

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@mananjadhav
Copy link
Collaborator

@stitesExpensify Can you assign this issue to me so that it is easier to track the payout?

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 5, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'compose.js' lib to TypeScript [HOLD for payment 2023-10-12] [TS migration] Migrate 'compose.js' lib to TypeScript Oct 5, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 5, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 5, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 16, 2023

@mananjadhav, @stitesExpensify Huh... This is 4 days overdue. Who can take care of this?

@stitesExpensify stitesExpensify added the External Added to denote the issue can be worked on by a contributor label Oct 16, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 16, 2023

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 16, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 16, 2023

Current assignee @mananjadhav is eligible for the External assigner, not assigning anyone new.

@stitesExpensify
Copy link
Contributor

Marking external to get a bug zero team member

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@stitesExpensify stitesExpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Oct 16, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 16, 2023

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 16, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Oct 16, 2023

Payment summary:

@mananjadhav
Copy link
Collaborator

@MitchExpensify I think the payout would be $250 and not $500. Can you please update the payout summary?

@MitchExpensify
Copy link
Contributor

huh, why so out of curiosity? @mananjadhav Trying to find the announcement to catch myself up

@MitchExpensify
Copy link
Contributor

While I can;'t track that announcement down, I have updated the payment summary all the same

@mananjadhav
Copy link
Collaborator

@MitchExpensify The general payout is $500, only TS migration PRs are at $250. That too I think we don't review, but just the checklist. Here's the link for the announcement. Also tagging @JmillsExpensify for the future reference.

@JmillsExpensify
Copy link

Agree that $250 is correct for TS migration. $250 payment approved for @mananjadhav based on summary above.

@MitchExpensify
Copy link
Contributor

Thank you for pointing me to the announcement, @mananjadhav! Much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

5 participants