Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250][HOLD for payment 2023-11-09] [TS migration] Migrate 'RenderHTML.js' component to TypeScript #24982

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/RenderHTML.js 4
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@blazejkustra
Copy link
Contributor

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 23, 2023

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@roryabraham roryabraham moved this from Todo to In Progress in Typescript migration Oct 26, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 2, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'RenderHTML.js' component to TypeScript [HOLD for payment 2023-11-09] [TS migration] Migrate 'RenderHTML.js' component to TypeScript Nov 2, 2023
Copy link
Author

melvin-bot bot commented Nov 2, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 2, 2023
Copy link
Author

melvin-bot bot commented Nov 2, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@marcaaron
Copy link
Contributor

I think we can close it out as no payment required.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Typescript migration Nov 3, 2023
@ntdiary
Copy link
Contributor

ntdiary commented Nov 7, 2023

I think we can close it out as no payment required.

Hi, @marcaaron, can I get paid for being a c+ reviewer? 😂

@marcaaron
Copy link
Contributor

I think so. Leave a comment sooner next time please.

@marcaaron marcaaron reopened this Nov 8, 2023
@marcaaron
Copy link
Contributor

I'm not too sure what the payout for this is so will let you discuss with the Bug Zero.

@marcaaron marcaaron added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 8, 2023
Copy link
Author

melvin-bot bot commented Nov 8, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 8, 2023
@marcaaron marcaaron assigned ntdiary and unassigned jliexpensify Nov 8, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 8, 2023

This comment was marked as resolved.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels Nov 8, 2023
@jliexpensify
Copy link
Contributor

jliexpensify commented Nov 8, 2023

@marcaaron we usually pay $500 for C+ - unless it was an easy review or small job, the engineer (e.g. Vit does this) might edit the GH title to reflect a lower price (e.g. $125 or $250).

Do you have any input on the price? If not, I'll pay $500 to @ntdiary

@marcaaron
Copy link
Contributor

Here's a similar issue to compare: #24788 (comment)

Sounds like $250.

@jliexpensify jliexpensify changed the title [HOLD for payment 2023-11-09] [TS migration] Migrate 'RenderHTML.js' component to TypeScript [$250][HOLD for payment 2023-11-09] [TS migration] Migrate 'RenderHTML.js' component to TypeScript Nov 9, 2023
Copy link
Author

melvin-bot bot commented Nov 9, 2023

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@jliexpensify
Copy link
Contributor

Thanks Marc, I'll sort this out!

@jliexpensify
Copy link
Contributor

Payment Summary

Upworks job

@ntdiary
Copy link
Contributor

ntdiary commented Nov 9, 2023

Payment Summary

Upworks job

@jliexpensify, thank you! Have accepted. : )

@jliexpensify
Copy link
Contributor

Cheers, paid and closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants