-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250][HOLD for payment 2023-11-09] [TS migration] Migrate 'RenderHTML.js' component to TypeScript #24982
Comments
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue! |
Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.94-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-11-09. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
I think we can close it out as no payment required. |
Hi, @marcaaron, can I get paid for being a c+ reviewer? 😂 |
I think so. Leave a comment sooner next time please. |
I'm not too sure what the payout for this is so will let you discuss with the Bug Zero. |
Triggered auto assignment to @jliexpensify ( |
This comment was marked as resolved.
This comment was marked as resolved.
@marcaaron we usually pay $500 for C+ - unless it was an easy review or small job, the engineer (e.g. Vit does this) might edit the GH title to reflect a lower price (e.g. $125 or $250). Do you have any input on the price? If not, I'll pay $500 to @ntdiary |
Here's a similar issue to compare: #24788 (comment) Sounds like $250. |
|
Thanks Marc, I'll sort this out! |
Payment Summary
|
@jliexpensify, thank you! Have accepted. : ) |
Cheers, paid and closed! |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
The text was updated successfully, but these errors were encountered: