Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-21] [TS migration] Migrate 'Device' lib to TypeScript #24877

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 16 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/actions/Device/index.js 5
Issue OwnerCurrent Issue Owner: @conorpendergrast
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@fvlvte
Copy link
Contributor

fvlvte commented Sep 18, 2023

I am Kacper Fałat from Callstack - expert contributor group. I'd like to work on this job

@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 18, 2023

📣 @fvlvte! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Sep 27, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 27, 2023

Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Oct 20, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 20, 2023

This issue has not been updated in over 15 days. @mountiny eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Oct 20, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Nov 14, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'Device' lib to TypeScript [HOLD for payment 2023-11-21] [TS migration] Migrate 'Device' lib to TypeScript Nov 14, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 14, 2023
Copy link
Author

melvin-bot bot commented Nov 14, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Nov 14, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @fvlvte does not require payment (Contractor)

@mountiny mountiny added the NewFeature Something to build that is a new item. label Nov 15, 2023
Copy link
Author

melvin-bot bot commented Nov 15, 2023

@mountiny
Copy link
Contributor

@conorpendergrast the only payment here is $250 to @0xmiroslav for review and testing of the TS migration PR. Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 21, 2023
@conorpendergrast
Copy link
Contributor

@0xmiroslav Offer sent!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 23, 2023
@conorpendergrast
Copy link
Contributor

@0xmiroslav bump on accepting the offer please

@melvin-bot melvin-bot bot removed the Overdue label Nov 27, 2023
@0xmiros
Copy link
Contributor

0xmiros commented Nov 27, 2023

Sorry, I have issue on my side. Let's just close this GH. I am tracking locally.

@conorpendergrast
Copy link
Contributor

If you're going to be paid for this, I'd rather keep it open to make sure I can pay it! Otherwise, it'll almost certainly get lost

@melvin-bot melvin-bot bot added the Overdue label Nov 29, 2023
@conorpendergrast
Copy link
Contributor

@0xmiroslav bump on this please: do you want to be paid for this (in which case I'll move this to Weekly until the issues you mentioned are resolved), or not (in which case I'll retract the offer in Upwork and close this issue out)?

@melvin-bot melvin-bot bot removed the Overdue label Nov 29, 2023
@0xmiros
Copy link
Contributor

0xmiros commented Nov 29, 2023

Please just close this and retract the offer. I will ping you when I am ready. Sorry for inconvenience

@conorpendergrast
Copy link
Contributor

No trouble. Offer withdrawn, closing out!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

4 participants