Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change device type to CamelCase #596

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Change device type to CamelCase #596

merged 1 commit into from
Nov 6, 2023

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Nov 6, 2023

Updating the type to the Device lib output to match our code style before we start using it in TS App

Fixed Issues

Related to Expensify/App#24877

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?

There are no tests related to this, we will test it with the App PR Expensify/App#27709

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?

In the App PR Expensify/App#27709

@mountiny mountiny self-assigned this Nov 6, 2023
@mountiny mountiny requested a review from a team as a code owner November 6, 2023 06:43
@melvin-bot melvin-bot bot requested review from youssef-lr and removed request for a team November 6, 2023 06:43
@Beamanator Beamanator merged commit 886f90c into main Nov 6, 2023
5 checks passed
@Beamanator Beamanator deleted the vit-updateDeviceType branch November 6, 2023 06:46
@mountiny mountiny changed the title Change device type to CamleCase Change device type to CamelCase Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants