Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-28] [TS migration] Migrate 'PersonalDetailsUtils.js' lib to TypeScript #24884

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Monthly KSv2 Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/libs/PersonalDetailsUtils.js 6
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@BartoszGrajdek
Copy link
Contributor

Hey! I’m Bartosz from Software Mansion, an expert agency, and I’d like to work on this issue!

@blazejkustra
Copy link
Contributor

@BartoszGrajdek No longer blocked, you can start working on it.

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 27, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Nov 24, 2023
Copy link
Author

melvin-bot bot commented Dec 10, 2023

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 21, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'PersonalDetailsUtils.js' lib to TypeScript [HOLD for payment 2023-12-28] [TS migration] Migrate 'PersonalDetailsUtils.js' lib to TypeScript Dec 21, 2023
Copy link
Author

melvin-bot bot commented Dec 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 21, 2023
Copy link
Author

melvin-bot bot commented Dec 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 27, 2023
@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 27, 2023
@MonilBhavsar
Copy link
Contributor

This was internal. No action required here

@thesahindia
Copy link
Member

Hey @MonilBhavsar, I reviewed the PR and eligible for C+ compensation. I am sending $250 money request on New dot. Can you please add a comment for the confirmation? It will be needed to get the payment approved.

@JmillsExpensify
Copy link

Awaiting payment confirmation. Opening the issue back up.

@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Jan 16, 2024

@thesahindia is eligible for payment for reviewing #30169 $250

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 16, 2024
@MonilBhavsar
Copy link
Contributor

Can we close this issue now?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 19, 2024
@MonilBhavsar MonilBhavsar added Weekly KSv2 Monthly KSv2 and removed Daily KSv2 Weekly KSv2 labels Jan 22, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 22, 2024
@MonilBhavsar
Copy link
Contributor

Bumping priority

@thesahindia
Copy link
Member

I think we can close it.

@JmillsExpensify
Copy link

Still unable to pay this issue until I get a payment summary. @thesahindia You still would like payment right?

@JmillsExpensify
Copy link

Ah nevermind! I see it here. $250 payment approved for @thesahindia.

@MonilBhavsar
Copy link
Contributor

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Monthly KSv2 Task Typescript Migration
Projects
Development

No branches or pull requests

5 participants