-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-28] [TS migration] Migrate 'PersonalDetailsUtils.js' lib to TypeScript #24884
Comments
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Hey! I’m Bartosz from Software Mansion, an expert agency, and I’d like to work on this issue! |
@BartoszGrajdek No longer blocked, you can start working on it. |
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-28. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
This was internal. No action required here |
Hey @MonilBhavsar, I reviewed the PR and eligible for C+ compensation. I am sending $250 money request on New dot. Can you please add a comment for the confirmation? It will be needed to get the payment approved. |
Awaiting payment confirmation. Opening the issue back up. |
@thesahindia is eligible for payment for reviewing #30169 $250 |
Can we close this issue now? |
Bumping priority |
I think we can close it. |
Still unable to pay this issue until I get a payment summary. @thesahindia You still would like payment right? |
Ah nevermind! I see it here. $250 payment approved for @thesahindia. |
Thank you all! |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
The text was updated successfully, but these errors were encountered: