Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [TS migration] Migrate 'SettingsAppDownloadLinks' page to TypeScript #25175

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 87 comments
Closed

[$250] [TS migration] Migrate 'SettingsAppDownloadLinks' page to TypeScript #25175

melvin-bot bot opened this issue Aug 17, 2023 · 87 comments
Assignees
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/settings/AppDownloadLinks.js 17
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014108b41d228e787e
  • Upwork Job ID: 1744724494902206464
  • Last Price Increase: 2024-01-09
  • Automatic offers:
    • yh-0218 | Contributor | 28092403
    • situchan | Contributor | 0
Issue OwnerCurrent Issue Owner: @bfitzexpensify
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@mountiny mountiny added External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. and removed Not a priority labels Jan 9, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'SettingsAppDownloadLinks' page to TypeScript [$500] [TS migration] Migrate 'SettingsAppDownloadLinks' page to TypeScript Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014108b41d228e787e

Copy link
Author

melvin-bot bot commented Jan 9, 2024

@melvin-bot melvin-bot bot added Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2 and removed Overdue Monthly KSv2 labels Jan 9, 2024
Copy link
Author

melvin-bot bot commented Jan 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 9, 2024
@hkopser99
Copy link
Contributor

@Julesssss here's the link. I had set it up but it looks like I needed to proceed with the next steps (adding screenshots, etc) before it would go to you (or whoever else) for review. Please confirm received and if submitted correctly whenever you have a chance. If you notice anything missing or done in a style not preferred by the team just let me know. It's my first job for Expensify and while I read through all the docs, I want to make sure everything I submit here and going forward is exactly what you're looking for.

@Julesssss
Copy link
Contributor

Great, thanks. I just approved the CI runs, and I can see @Santhosh-Sellavel was assigned correctly as the C+ reviewer. Just let them know when it is ready for review.

@Santhosh-Sellavel Santhosh-Sellavel removed their assignment Feb 15, 2024
@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Feb 15, 2024

@situchan Took over the review please assign them as C+ here

Copy link
Author

melvin-bot bot commented Feb 16, 2024

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

Julesssss added a commit that referenced this issue Feb 19, 2024
[TS migration] Migrate 'SettingsAppDownloadLinks' page to TypeScript #25175
@Julesssss
Copy link
Contributor

Merged, awaiting deploy

@situchan
Copy link
Contributor

situchan commented Mar 6, 2024

PR was deployed to production on Feb 26

@bfitzexpensify
Copy link
Contributor

Thanks for the bump @situchan - contract paid out.

@hkopser99
Copy link
Contributor

@bfitzexpensify @Julesssss Hi all, I see the note above to Situchan confirming contract paid. This was my first contract I handled for Expensify and there were issues getting Melvin to connect me to the contract in Upwork. Does something manual need to be done to get me paid?

@bfitzexpensify bfitzexpensify added Daily KSv2 and removed Weekly KSv2 labels Mar 12, 2024
@bfitzexpensify
Copy link
Contributor

Thanks for the bump @hkopser99

Reopening this and setting it to daily to action tomorrow

@hkopser99
Copy link
Contributor

Hey @bfitzexpensify thanks for reopening. Please let me know if there's anything I need to do here or in upwork

@hkopser99
Copy link
Contributor

Hi @bfitzexpensify just checking in again

@bfitzexpensify
Copy link
Contributor

Hey @hkopser99 - I'm not seeing your proposal on the Upwork job. I might need to recreate this manually and send a new invite. Can you please link your Upwork profile here?

@hkopser99
Copy link
Contributor

Hey @bfitzexpensify sure, here it is: https://www.upwork.com/freelancers/~0141fe061cf82b5462?

This was my first job on the Expensify project and I remember when Jules was assigning it to me there were some issues and it was expected that something manual might need to be done afterward to get me paid.

@Julesssss
Copy link
Contributor

Thanks Ben, yeah i think we had some issues creating the original UpWork job, a new one might be quicker.

@bfitzexpensify
Copy link
Contributor

@hkopser99 I sent over the offer yesterday, just flagging that here in case you missed it

@hkopser99
Copy link
Contributor

hkopser99 commented Apr 2, 2024

@bfitzexpensify thanks. Was on vacation for a few days over Easter. I went in and accepted. Looks like a different job was listed in Upwork. The one you sent via Upwork was #39117. I'd like to work on that one too if I'm allowed to, but this one I completed was #25175. Just wanted to mention before I "submit" and close it out in Upwork. If I can be assigned 39117 as well that would be great too, would love to do more work for Expensify.

@bfitzexpensify
Copy link
Contributor

Thanks @hkopser99. Contract paid out.

The one you sent via Upwork was #39117. I'd like to work on that one too if I'm allowed to, but this one I completed was #25175. Just wanted to mention before I "submit" and close it out in Upwork. If I can be assigned 39117 as well that would be great too, would love to do more work for Expensify.

It looks like the wrong issue number was pulled across, the payment was for this issue (#25175). I can't directly assign you to #39117, but feel free to comment there as well indicating your interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests