-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [TS migration] Migrate 'SettingsAppDownloadLinks' page to TypeScript #25175
Comments
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
Job added to Upwork: https://www.upwork.com/jobs/~014108b41d228e787e |
Triggered auto assignment to @bfitzexpensify ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel ( |
@Julesssss here's the link. I had set it up but it looks like I needed to proceed with the next steps (adding screenshots, etc) before it would go to you (or whoever else) for review. Please confirm received and if submitted correctly whenever you have a chance. If you notice anything missing or done in a style not preferred by the team just let me know. It's my first job for Expensify and while I read through all the docs, I want to make sure everything I submit here and going forward is exactly what you're looking for. |
Great, thanks. I just approved the CI runs, and I can see @Santhosh-Sellavel was assigned correctly as the C+ reviewer. Just let them know when it is ready for review. |
@situchan Took over the review please assign them as C+ here |
📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
[TS migration] Migrate 'SettingsAppDownloadLinks' page to TypeScript #25175
Merged, awaiting deploy |
PR was deployed to production on Feb 26 |
Thanks for the bump @situchan - contract paid out. |
@bfitzexpensify @Julesssss Hi all, I see the note above to Situchan confirming contract paid. This was my first contract I handled for Expensify and there were issues getting Melvin to connect me to the contract in Upwork. Does something manual need to be done to get me paid? |
Thanks for the bump @hkopser99 Reopening this and setting it to daily to action tomorrow |
Hey @bfitzexpensify thanks for reopening. Please let me know if there's anything I need to do here or in upwork |
Hi @bfitzexpensify just checking in again |
Hey @hkopser99 - I'm not seeing your proposal on the Upwork job. I might need to recreate this manually and send a new invite. Can you please link your Upwork profile here? |
Hey @bfitzexpensify sure, here it is: https://www.upwork.com/freelancers/~0141fe061cf82b5462? This was my first job on the Expensify project and I remember when Jules was assigning it to me there were some issues and it was expected that something manual might need to be done afterward to get me paid. |
Thanks Ben, yeah i think we had some issues creating the original UpWork job, a new one might be quicker. |
@hkopser99 I sent over the offer yesterday, just flagging that here in case you missed it |
@bfitzexpensify thanks. Was on vacation for a few days over Easter. I went in and accepted. Looks like a different job was listed in Upwork. The one you sent via Upwork was #39117. I'd like to work on that one too if I'm allowed to, but this one I completed was #25175. Just wanted to mention before I "submit" and close it out in Upwork. If I can be assigned 39117 as well that would be great too, would love to do more work for Expensify. |
Thanks @hkopser99. Contract paid out.
It looks like the wrong issue number was pulled across, the payment was for this issue (#25175). I can't directly assign you to #39117, but feel free to comment there as well indicating your interest! |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @bfitzexpensifyThe text was updated successfully, but these errors were encountered: