Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'WorkspaceNewRoom' page to TypeScript #25188

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 9 comments
Closed

[TS migration] Migrate 'WorkspaceNewRoom' page to TypeScript #25188

melvin-bot bot opened this issue Aug 17, 2023 · 9 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/workspace/WorkspaceNewRoomPage.js 24
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@pac-guerreiro
Copy link
Contributor

I am Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this job!

@melvin-bot melvin-bot bot added the Overdue label Jan 16, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 Overdue labels Jan 23, 2024
@arosiclair arosiclair self-assigned this Jan 23, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Feb 16, 2024
Copy link
Author

melvin-bot bot commented Feb 16, 2024

This issue has not been updated in over 15 days. @arosiclair eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@Christinadobrzyn
Copy link
Contributor

hey @arosiclair we have a possible regression reported here - #37360

Can you take a peek and see if this needs to be resolved in this PR?

@situchan
Copy link
Contributor

situchan commented Mar 6, 2024

There was no regression - #37360 (comment)
PR was deployed to production on Feb 28

@arosiclair arosiclair added Bug Something is broken. Auto assigns a BugZero manager. and removed Reviewing Has a PR in review Weekly KSv2 labels Mar 7, 2024
Copy link
Author

melvin-bot bot commented Mar 7, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@arosiclair
Copy link
Contributor

@garrettmknight can you just do payment for @situchan's C+ review?

@garrettmknight
Copy link
Contributor

Paid, done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

5 participants