[TS migration] Migrate 'WorkspaceNewRoom' page to TypeScript #34742

pac-guerreiro · 2024-01-18T16:33:04Z

Details

Fixed Issues

$#25188
PROPOSAL: N/A

Tests

Make sure you're a member of a workspace or create one first!
On homepage, press ( + ) button and select Start chat
Select Room tab
Check that the page renders correctly and that the inputs work correctly
Fill the necessary data and then press Create room below.
Check that the room was created with the data that you filled on the previous step.

Offline tests

Same as tests.

QA Steps

Same as tests.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

pac-guerreiro · 2024-01-18T16:37:03Z

This work is blocked by #31972

src/components/ScreenWrapper.tsx

src/pages/workspace/WorkspaceNewRoomPage.tsx

VickyStash

LGTM

melvin-bot · 2024-01-23T10:04:03Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

arosiclair · 2024-01-23T16:39:21Z

Code seems good on first glance.

@VickyStash @filip-solecki can one of you complete the checklist please? Thanks!

situchan · 2024-01-23T16:41:11Z

C+ is supposed to checklist on TS migration PRs but seems missing here.
I can do if needed.

arosiclair · 2024-01-24T15:29:19Z

@situchan please review

situchan

Code looks good. Testing

src/pages/workspace/WorkspaceNewRoomPage.tsx

situchan · 2024-01-25T15:47:13Z

@pac-guerreiro please pull main. Context here, thanks!

…oompage-to-typescript

situchan · 2024-01-26T16:59:43Z

ok, so TS check failing after pull main.
Also fix conflict.

…oompage-to-typescript # Conflicts: # src/pages/workspace/WorkspaceNewRoomPage.tsx

pac-guerreiro · 2024-01-29T23:07:38Z

@situchan Typescript issues and conflicts resolved! Thanks 😄

situchan

please resolve conflict

situchan · 2024-02-05T21:01:47Z

src/pages/workspace/WorkspaceNewRoomPage.tsx

                                    label={translate('workspace.common.workspace')}
                                    items={workspaceOptions}
                                    value={policyID}
-                                    onValueChange={setPolicyID}
+                                    onValueChange={(value) => setPolicyID(value as typeof policyID)}


No way to avoid this typecast? I don't see such pattern throughout the app.

@situchan Sadly, it's not possible at the moment 😞

onValueChange type is hardcoded to expect an unknown value, which creates a type error.

This should be resolved when #35584 is merged!

Looks like it was just merged a few days ago. You mind updating this now?

@pac-guerreiro bump ^

@arosiclair @situchan type assertion is still needed 😅

…oompage-to-typescript # Conflicts: # src/libs/ErrorUtils.ts # src/libs/ValidationUtils.ts # src/pages/workspace/WorkspaceNewRoomPage.tsx

pac-guerreiro · 2024-02-07T12:51:05Z

Conflicts resolved!

pac-guerreiro · 2024-02-12T16:22:10Z

@situchan Conflicts resolved 😄

situchan · 2024-02-13T14:05:49Z

@pac-guerreiro conflicts again

…oompage-to-typescript # Conflicts: # src/pages/workspace/WorkspaceNewRoomPage.tsx

pac-guerreiro · 2024-02-13T22:26:44Z

@situchan Conflicts resolved again

…oompage-to-typescript

situchan · 2024-02-15T22:31:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

arosiclair · 2024-02-16T16:38:16Z

@situchan please prioritize this review so we can close this out without more conflicts, thanks

situchan

melvin-bot · 2024-02-19T08:33:34Z

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #36789.

situchan · 2024-02-19T08:33:49Z

@arosiclair all yours

situchan · 2024-02-19T14:06:10Z

Also, hoping this PR would get merged sooner than #34654

situchan · 2024-02-19T16:09:00Z

#34654 was merged earlier.
@pac-guerreiro please sync main again

…oompage-to-typescript

pac-guerreiro · 2024-02-21T17:54:16Z

@situchan conflicts resolved!

situchan · 2024-02-21T18:05:02Z

@pac-guerreiro please avoid force-push once review started.

Is this just your change?

pac-guerreiro · 2024-02-21T22:05:59Z

@situchan Sorry, I won't do it again! I just wanted to make amends to my last commit 😅

Those were my changes!

…oompage-to-typescript

situchan · 2024-02-22T14:22:50Z

@arosiclair all yours

OSBotify · 2024-02-22T16:11:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:04:53Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:53:29Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

iwiznia · 2024-02-29T22:59:34Z

src/pages/workspace/WorkspaceNewRoomPage.tsx

+        if (!(((wasLoading && !isLoading) || (isOffline && isLoading)) && isEmptyObject(errorFields))) {
            return;
        }
        Navigation.dismissModal(newRoomReportID);
        // eslint-disable-next-line react-hooks/exhaustive-deps -- we just want this to update on changing the form State
-    }, [props.formState]);
+    }, [isLoading, errorFields]);


I am working on a PR and I am seeing a lint failure in this file: https://github.com/Expensify/App/actions/runs/8103662907/job/22148730565?pr=37556#step:4:19

Warning: 147:8 warning React Hook useEffect has missing dependencies: 'isOffline', 'newRoomReportID', and 'wasLoading'. Either include them or remove the dependency array react-hooks/exhaustive-deps

Questions are:

Should I include those other variables like it is suggesting?

Why is this failing lint now and not when this PR was merged?

// eslint-disable-next-line react-hooks/exhaustive-deps

@iwiznia because you removed this comment in your PR

https://github.com/Expensify/App/pull/37556/files#diff-80df02834ebf2f103e25089bc976474c23f483a5c1188f54eb1f48f847860849L147

Oh thanks! 🤦
For some reason my IDE was marking that line as an error... thanks!

refactor(typescript): migrate workspacenewroompage

31581f9

pac-guerreiro force-pushed the pac-guerreiro/refactor/migrate-workspacenewroompage-to-typescript branch from 21a8ee6 to 31581f9 Compare January 18, 2024 16:38

VickyStash reviewed Jan 19, 2024

View reviewed changes

refactor(typescript): apply pull request feedback

d9fb612

VickyStash approved these changes Jan 22, 2024

View reviewed changes

filip-solecki approved these changes Jan 23, 2024

View reviewed changes

pac-guerreiro marked this pull request as ready for review January 23, 2024 10:03

pac-guerreiro requested a review from a team as a code owner January 23, 2024 10:03

melvin-bot bot requested review from arosiclair and removed request for a team January 23, 2024 10:04

arosiclair requested a review from situchan January 24, 2024 15:25

situchan reviewed Jan 24, 2024

View reviewed changes

src/pages/workspace/WorkspaceNewRoomPage.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into pac-guerreiro/refactor/migrate-workspacenewr…

9c6d75c

…oompage-to-typescript

pac-guerreiro added 4 commits January 26, 2024 18:07

refactor: apply pull request feedback

4542a8f

Merge branch 'main' into pac-guerreiro/refactor/migrate-workspacenewr…

11cd608

…oompage-to-typescript # Conflicts: # src/pages/workspace/WorkspaceNewRoomPage.tsx

refactor(typescript): fix types

da4ffd7

chore: resolve linter issues

c8fa793

pac-guerreiro force-pushed the pac-guerreiro/refactor/migrate-workspacenewroompage-to-typescript branch from 9039af6 to c8fa793 Compare January 29, 2024 23:02

situchan reviewed Feb 5, 2024

View reviewed changes

Merge branch 'main' into pac-guerreiro/refactor/migrate-workspacenewr…

5483c04

…oompage-to-typescript # Conflicts: # src/libs/ErrorUtils.ts # src/libs/ValidationUtils.ts # src/pages/workspace/WorkspaceNewRoomPage.tsx

blazejkustra mentioned this pull request Feb 12, 2024

[TS migration] Migrate 'NewChatSelector' page to TypeScript #34859

Closed

50 tasks

Merge branch 'main' into pac-guerreiro/refactor/migrate-workspacenewr…

8e29ce7

…oompage-to-typescript # Conflicts: # src/pages/workspace/WorkspaceNewRoomPage.tsx

Merge branch 'main' into pac-guerreiro/refactor/migrate-workspacenewr…

16f86e3

…oompage-to-typescript

situchan approved these changes Feb 19, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Feb 19, 2024

[PAID] Payment issue for E/App PR#34742 #36789

Closed

situchan mentioned this pull request Feb 19, 2024

[TS migration] Migrate 'ValuePicker' component to TypeScript #34654

Merged

50 tasks

Merge branch 'main' into pac-guerreiro/refactor/migrate-workspacenewr…

4e062c4

…oompage-to-typescript

pac-guerreiro force-pushed the pac-guerreiro/refactor/migrate-workspacenewroompage-to-typescript branch from 93dd85a to 4e062c4 Compare February 21, 2024 17:49

Merge branch 'main' into pac-guerreiro/refactor/migrate-workspacenewr…

2f466c3

…oompage-to-typescript

arosiclair approved these changes Feb 22, 2024

View reviewed changes

arosiclair merged commit 440c43e into Expensify:main Feb 22, 2024
15 checks passed

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

lanitochka17 mentioned this pull request Feb 27, 2024

Android - Room - Creating room offline,infinite loading appears until get online #37360

Closed

6 tasks

iwiznia reviewed Feb 29, 2024

View reviewed changes

[TS migration] Migrate 'WorkspaceNewRoom' page to TypeScript #34742

[TS migration] Migrate 'WorkspaceNewRoom' page to TypeScript #34742

Conversation

pac-guerreiro commented Jan 18, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

pac-guerreiro commented Jan 18, 2024

VickyStash left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 23, 2024

arosiclair commented Jan 23, 2024

situchan commented Jan 23, 2024

arosiclair commented Jan 24, 2024

situchan left a comment

Choose a reason for hiding this comment

situchan commented Jan 25, 2024

situchan commented Jan 26, 2024 • edited Loading

pac-guerreiro commented Jan 29, 2024

situchan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pac-guerreiro commented Feb 7, 2024

pac-guerreiro commented Feb 12, 2024

situchan commented Feb 13, 2024

pac-guerreiro commented Feb 13, 2024

situchan commented Feb 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

arosiclair commented Feb 16, 2024

situchan left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Feb 19, 2024

situchan commented Feb 19, 2024

situchan commented Feb 19, 2024

situchan commented Feb 19, 2024

pac-guerreiro commented Feb 21, 2024

situchan commented Feb 21, 2024

pac-guerreiro commented Feb 21, 2024

situchan commented Feb 22, 2024

OSBotify commented Feb 22, 2024

OSBotify commented Feb 26, 2024

OSBotify commented Feb 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pac-guerreiro commented Jan 18, 2024 •

edited

Loading

situchan commented Jan 26, 2024 •

edited

Loading

situchan commented Feb 15, 2024 •

edited

Loading